Bug 142095 - Symbols catalog shows Greek symbol set without taking into account the document's GreekCharStyle
Summary: Symbols catalog shows Greek symbol set without taking into account the docume...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Formula Editor (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Formula-Editor
  Show dependency treegraph
 
Reported: 2021-05-05 09:58 UTC by Mike Kaganski
Modified: 2021-05-07 13:31 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2021-05-05 09:58:11 UTC
When in Math you open Tools->Symbols, a Symbols dialog is opened. It allows to see, edit, and insert the elements from three symbol sets: Greek, iGreek, and Special.

The Greek symbol set inserts entities like %OMEGA or %pi. Those elements' look depends on the document's GreekCharStyle setting (initialized from corresponding global setting - see tdf#52225 and tdf#136251). Namely, uppercase Greek characters are normal, and lowercase characters are italic, unless 'nitalic ' keyword is used.

However, the dialog doesn't show these characters in this form (it should show italic for lowercase by default). They are all normal in the dialog, and that doesn't change whatever value is set for GreekCharStyle in the document.

Expected result: the characters of Greek symbol set in Symbols dialog must be shown according to the document's GreekCharStyle settings: all normal when GreekCharStyle = 0; all italics when GreekCharStyle = 1; uppercase normal and lowercase italics when GreekCharStyle = 2.
Comment 1 dante19031999 2021-05-05 13:18:43 UTC
That's confusing.
What's the point of having normal greek characters and italic greek characters if after LO is gonna make whatever it wants with them?
I would just remove the feature and let the user choose from the table.

For the UX team. Is it save to remove the feature?
Comment 2 Mike Kaganski 2021-05-05 13:21:47 UTC
(In reply to dante19031999 from comment #1)
> That's confusing.
> What's the point of having normal greek characters and italic greek
> characters if after LO is gonna make whatever it wants with them?

See the See Also for the rationale.

> I would just remove the feature and let the user choose from the table.

Choose from *which* table?

> For the UX team. Is it save to remove the feature?

Well, you likely not only want feedback from UX, but also from dev PoV: how are you going to provide compatibility.
Comment 3 V Stuart Foote 2021-05-05 13:55:16 UTC
Seems this is about the rendering the Symbols dialog character chart receives is not following the GreekCharStyle mode '2' as set.  I'm sure the linkage to do so is not there. So chart rendering either needs to be done static (Normal for Uppercase, italic for Lowers) or should idealy be refactored to follow the GreekCharStyle mode value.  

That way a symbol picked from the dialog is shown as it would be rendered, and user would know to apply nitalic or italic if needed.

The Symbols dialog needs to be changed to match the GreekCharStyle mode selector, not drop the mode selector.
Comment 4 Heiko Tietze 2021-05-07 08:15:53 UTC
(In reply to V Stuart Foote from comment #3)
> The Symbols dialog needs to be changed to match the GreekCharStyle mode
> selector, not drop the mode selector.

Nothing to add from UX POV
Comment 5 V Stuart Foote 2021-05-07 13:13:23 UTC
Removing the bug 109232 Special Character dialog meta. The Formula Editor's Symbols dialog is not linked to the general use Special Character picker dialog, and probably can't be. 

The UI names/abreviations for sm formula entry are localized. That localization is reflected in the sm Symbols dialog--the general use Special Character dialog uses the default Unicode names; glyph names that are not appropriate for the sm Formula editor.

Issue here only applies to the rendering of the glyphs on the charts of the sm Symbols dialog. The rendering needs to follow the setting of the 'GreekCharStyle' expert configuration stanza so the charts reflect the setting.