Bug 142268 - [EMF] Arc with bottom corner above the top one
Summary: [EMF] Arc with bottom corner above the top one
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
6.2.8.2 release
Hardware: All All
: medium normal
Assignee: Bartosz
URL:
Whiteboard: target:7.2.0 target:7.1.5
Keywords:
Depends on:
Blocks: EMF-WMF
  Show dependency treegraph
 
Reported: 2021-05-13 23:23 UTC by Valek Filippov
Modified: 2021-05-21 09:00 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
EMF sample with a single Arc entry (264 bytes, image/x-emf)
2021-05-13 23:24 UTC, Valek Filippov
Details
Screenshot of the sample EMF file opened in MS Paint (1.16 KB, image/png)
2021-05-13 23:25 UTC, Valek Filippov
Details
EMF sample with right point on the left of the left one (264 bytes, image/x-emf)
2021-05-14 01:30 UTC, Valek Filippov
Details
EMF with Chord instead of Arc (264 bytes, image/x-emf)
2021-05-14 01:35 UTC, Valek Filippov
Details
EMF with Pie instead of Arc (264 bytes, image/x-emf)
2021-05-14 01:35 UTC, Valek Filippov
Details
Screenshot with Chord and Pie (2.07 KB, image/png)
2021-05-14 01:37 UTC, Valek Filippov
Details
EMF sample with full arc (start/end angles are the same), right point left to the left point (300 bytes, image/x-emf)
2021-05-18 18:39 UTC, Valek Filippov
Details
EMF sample with full arc (start/end angles are the same), "normal" positions of points (300 bytes, image/x-emf)
2021-05-18 18:40 UTC, Valek Filippov
Details
Screenshot of fullarc sample (907 bytes, image/png)
2021-05-18 18:41 UTC, Valek Filippov
Details
EMF sample of the full chord, normal placement of points (300 bytes, image/x-emf)
2021-05-18 18:47 UTC, Valek Filippov
Details
EMF sample of full pie, normal placement of points (300 bytes, image/x-emf)
2021-05-18 18:48 UTC, Valek Filippov
Details
Screenshot of full chord and full pie samples opened in MS Paint (2.79 KB, image/png)
2021-05-18 18:50 UTC, Valek Filippov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Valek Filippov 2021-05-13 23:23:32 UTC
Description:
LO seems to fail to properly handle Arc if 'bottom right' corner of the BBox is set to be above 'top left' one.

Steps to Reproduce:
Open attached EMF file

Actual Results:
Empty image is shown.

Expected Results:
It should show an arc.


Reproducible: Always


User Profile Reset: No



Additional Info:
This is not a recent regression (doesn't work in 6.2.8, 6.4.x, 7.0.5 and 7.2.master).

It probably would fail the same way for "right" point placed on the left of the "left" point.
Chord and Pie are likely to fail the same way too.
Comment 1 Valek Filippov 2021-05-13 23:24:36 UTC
Created attachment 171981 [details]
EMF sample with a single Arc entry
Comment 2 Valek Filippov 2021-05-13 23:25:55 UTC
Created attachment 171982 [details]
Screenshot of the sample EMF file opened in MS Paint
Comment 3 Valek Filippov 2021-05-13 23:28:10 UTC
Fixing that will likely improve handling of the sample attached to 55007.
Comment 4 Valek Filippov 2021-05-14 01:30:27 UTC
Created attachment 171984 [details]
EMF sample with right point on the left of the left one

LO fails to properly handling Xs > Xe too.
Comment 5 Valek Filippov 2021-05-14 01:35:30 UTC
Created attachment 171985 [details]
EMF with Chord instead of Arc
Comment 6 Valek Filippov 2021-05-14 01:35:56 UTC
Created attachment 171986 [details]
EMF with Pie instead of Arc
Comment 7 Valek Filippov 2021-05-14 01:37:40 UTC
Created attachment 171987 [details]
Screenshot with Chord and Pie
Comment 8 Valek Filippov 2021-05-18 18:39:42 UTC
Created attachment 172148 [details]
EMF sample with full arc (start/end angles are the same), right point left to the left point
Comment 9 Valek Filippov 2021-05-18 18:40:29 UTC
Created attachment 172149 [details]
EMF sample with full arc (start/end angles are the same), "normal" positions of points
Comment 10 Valek Filippov 2021-05-18 18:41:51 UTC
Created attachment 172150 [details]
Screenshot of fullarc sample

Both normal and inverted arc sample should look like a circle.
Comment 11 Commit Notification 2021-05-18 18:43:13 UTC
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/39369c6e67dffe04acc4abb678c1a94526237fd8

tdf#55007 tdf#142263 tdf#142268 EMF Properly display ARC and CHORD

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Valek Filippov 2021-05-18 18:47:49 UTC
Created attachment 172151 [details]
EMF sample of the full chord, normal placement of points
Comment 13 Valek Filippov 2021-05-18 18:48:15 UTC
Created attachment 172152 [details]
EMF sample of full pie, normal placement of points
Comment 14 Valek Filippov 2021-05-18 18:50:15 UTC
Created attachment 172153 [details]
Screenshot of full chord and full pie samples opened in MS Paint

Pie has a line connecting its center with the outer
Comment 15 Commit Notification 2021-05-21 05:31:38 UTC
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fb5247bf587518eaa01cf5d54dceddf73827d740

tdf#55007 tdf#142263 tdf#142268 EMF ARC, PIE, CHORD allow to draw circle

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Commit Notification 2021-05-21 08:21:26 UTC
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/71edc1d1af9691f7b5067579f22d3d8677c1608c

tdf#55007 tdf#142263 tdf#142268 EMF Properly display ARC and CHORD

It will be available in 7.1.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.