Description: Plus icon zooms out, minus icon zooms in. Probably only the assingment of icons is wrong. Plus icon is on the left (see screenshot), minus icon is on the right. Writer has plus icon on the right and minus icon on the left. Zoom directions are correct for Writer. Steps to Reproduce: 1. Open Calc 2. Fill some cells with arbitrary content 3. Open print preview 4. Zoom in and zoom out Actual Results: Icon to zoom in triggers zoom out, icon to zoom out triggers zoom in Expected Results: Icons appear in swapped order and trigger the corresponding actions correctly Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.3.2.0+ / LibreOffice Community Build ID: 162213c78ede269b255c1eddaaac013975a34ee2 CPU threads: 8; OS: Mac OS X 10.15.7; UI render: GL; VCL: osx Locale: de-DE (en_US.UTF-8); UI: en-US Calc: threaded
Created attachment 172379 [details] Screenshot
Reproduced with 7.2/master daily build: Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 18e5e948dd66e41f17b0a63bf631d98aee84a03b CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: threaded But not reproduced (toolbar icons work as expected) with 7.0.6: Version: 7.0.6.2 (x64) Build ID: 144abb84a525d8e30c9dbbefa69cbbf2d8d4ae3b CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: default; VCL: win Locale: zh-CN (zh_CN); UI: en-US Calc: threaded In both cases the plus icon is always on the left, so unlikely wrong assignment of icon images. Also I'm using elementary icon theme for 7.0.6 and Yaru (via extension) theme for 7.2, so not icon theme specific either. Requesting for bibisection. Note that this bug is about the two icons with magnifying glass and plus/minus as indicated in the attached screenshot in comment #1. The widget with just plus/minus icon (no magnifying glass) and a slide scale thing to the right on the same toolbar works correctly.
Confirming, but icons and commands haven't changed. Jim, is this issue related to your patch in https://gerrit.libreoffice.org/c/core/+/104196?
Linux 7.1: commit 8a2dd7cb300c0ffdafd7d5f3a4b2ce9778783ed1 Date: Fri Nov 13 19:09:27 2020 +0100 source 95b27dd2e5b5bdcb39962f72882dcdf406bcb393 previos d40f2d02df26e216f367b5da3f9546b73f250469 author Jim Raykowski <raykowj@gmail.com> 2020-10-11 16:15:47 -0800 committer Jim Raykowski <raykowj@gmail.com> 2020-11-13 17:53:20 +0100 commit 95b27dd2e5b5bdcb39962f72882dcdf406bcb393 (patch) tree 84c49a7daadf1ce908a9f5608d40494af164917d parent d40f2d02df26e216f367b5da3f9546b73f250469 (diff) tdf#45705 rework zoom in and zoom out UI commands in Calc CC Jim, please see this.
Looks like I got the zoom in/out reversed. Here is a fix for both print preview and calc canvas zooming: https://gerrit.libreoffice.org/c/core/+/116287
*** Bug 142690 has been marked as a duplicate of this bug. ***
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ec629c5ee22d02f99d66a5cf975ce239876b7f4d Resolves tdf#142513 fix zoom caller handling It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I see it's OK, thanks for speedy fix, I guess we can close.
Unfortunately not: (1) Order of plus and minus icons is swapped compared with the zoom slider on the right (see screenshot from Calc attached). Writer has the plus sign on the right too (see screenshot from Writer attached). (2) Background of zoom slider became white (on macOS at least, see screenshot from Calc attached). Zooming itself works now as expected again. So, buttons need to be swapped (including their functionality) and background of zoom slider needs to be restored as before (see first screenshot when opening this ticket).
Created attachment 172681 [details] Screenshot from Calc with patch
Created attachment 172682 [details] Screenshot from Writer
Thanks to Thorsten for additional check. (1) Order of plus and minus icons is swapped, should be - left and + right. Yes, although not a regression but Inherited. If Jim would confirm fixing it here, fine, if not, another bug. (2) Background of zoom slider became white. Not only macOS but also Lin and Win, that's bug 136766.
Zoom In was always left of Zoom Out. Nothing to say against swapping it, will submit a patch. The transparency issue is clearly not related to this bug.
Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e0900c497a65af2e45c7cff3211b340bf14c4324 Resolves tdf#142513 - Order of ZoomIn and ZoomOut at Print Preview It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Backport to 7.1: https://gerrit.libreoffice.org/c/core/+/116702
*** Bug 142803 has been marked as a duplicate of this bug. ***
*** Bug 142853 has been marked as a duplicate of this bug. ***
Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/3d4c284f087010e9590460f98052438526e14c00 Resolves tdf#142513 fix zoom caller handling It will be available in 7.1.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Tested in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: c703b2d22c3f45825d9c9d790c3b5a4b6f97e776 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: ro-RO (ro_RO); UI: en-US Calc: threaded But of course was fixed also in 7.2
*** Bug 143141 has been marked as a duplicate of this bug. ***
*** Bug 143529 has been marked as a duplicate of this bug. ***
*** Bug 146600 has been marked as a duplicate of this bug. ***