Bug 142709 - Slide show has no Tiles slide transition
Summary: Slide show has no Tiles slide transition
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.2.0.0 alpha1+
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-08 07:40 UTC by Telesto
Modified: 2022-09-06 18:10 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (13.69 KB, application/vnd.oasis.opendocument.presentation)
2021-06-08 07:44 UTC, Telesto
Details
Bibisect log (3.53 KB, text/plain)
2021-06-27 09:10 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-06-08 07:40:27 UTC
Description:
Slide show drops to desktop in the middle of the presentation (press still active in background)

Steps to Reproduce:
1. open the attached file
2. Press F5


Actual Results:
Should drop to desktop after first sheet animation finishes

Expected Results:
Should stay on top 


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 3b57ebb445df8a2bc3d916ea79f8af45e20e4e62
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

After profile reset, but not happening in safe-mode
Comment 1 Telesto 2021-06-08 07:44:21 UTC
Created attachment 172691 [details]
Example file
Comment 2 Timur 2021-06-08 13:19:30 UTC Comment hidden (obsolete)
Comment 3 Telesto 2021-06-08 14:27:03 UTC
(In reply to Timur from comment #2)
> No repro. I don't see animation on slides.

I meant: Slide transition

And please copy the about. Pretty sure you tested with Windows, but Raster or Vulkan? Windows 10 or lower? And which build..
Comment 4 Timur 2021-06-09 08:28:34 UTC
I don't repro show drop but I don't see Tiles slide transition in Windows 7, both Skia and Gdi, LO 7.2+ UI render: default; VCL: win.
Tiles were seen with 7.0.6, although with flickering which is sometimes a drop to desktop.

I see Tiles in Linux, so I set New regression for Windows in 7.2 for Tiles transition. 
After that one is resolved, flickering and drop can be tested.
Comment 5 Timur 2021-06-10 06:52:07 UTC
Telesto, do you reproduce "no Tiles in slide transition"? 
Please do bibisect for what you do.
Comment 6 Telesto 2021-06-27 09:10:14 UTC
Created attachment 173230 [details]
Bibisect log

This worked fine until
author	Noel Grandin <noelgrandin@gmail.com>	2021-01-18 18:27:19 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2021-05-17 12:56:51 +0200
commit 9090dc1f3b27195f5defd35586ac79357992be21 (patch)
tree d39f4b624ae337d5c9ce76eba8521b76e53afa05
parent c8cf2e0e088b74afa52564945a9c005b3b86bf7e (diff)
split OutputDevice from Window
as part of a longer-term goal of doing our
widget rendering only inside a top-level render-
context.

I moved all of the OutputDevice-related code that existed in vcl::Window
into a new subclass of OutputDevice called WindowOutputDevice.


(*) not sure why we are getting an 1x1 surface in
    SvpSalGraphics::releaseCairoContext, but to fix it I clamp
    the size there

(*) might have to dump VCLXDevice, and move it's code down into VCLXWindow and VCLXVirtualDevice

(*) can we remove use of VCLXDevice in other places, in favour of just talking to the VCL code?

https://cgit.freedesktop.org/libreoffice/core/commit/?id=9090dc1f3b27195f5defd35586ac79357992be21

After this commit:
1. First start of presentation crashes
2. Second run, the effect being replaced by functional one

Somewhere the right effect is re-introduced.. (different bibisect?) but not showing in Windows 7 and showing in 8.1 but dropping presentation to desktop
Comment 7 Telesto 2021-06-27 09:48:43 UTC
Adding CC to: Noel Grandin

To be clear:
Current condition: no slide transition on Windows 7 (comment 4). Windows 8.1 as transition but drops to desktop at the end of each slide transition effect.

I bibisected where this initially started. The issue got partially resolved in the mean time (not crashing anymore) 

Observations related to the commit in question.
1. First start of presentation (F5) crashes 
2. Second run, the effect being replaced by different (functional) effect (entry for the side?). This is apparently stored in the user profile (had to delete the profile for the bibisect)

The flickering in comment 4 is a long standing issue (probably: bug 99685 see also: bug 91456 )
Comment 8 Justin L 2022-03-05 14:53:34 UTC
Please retest this. I can't reproduce in Linux (although I note it does say Windows only). Another bug report suggests there have been follow-up patches to Noel's commit.
Comment 9 QA Administrators 2022-09-02 03:39:10 UTC Comment hidden (obsolete)
Comment 10 Timur 2022-09-05 13:47:40 UTC
No Tiles slide transition in Windows and Linux with LO 7.5+. I set New again.
Comment 11 Noel Grandin 2022-09-05 14:41:48 UTC
I get a slide on both Windows and Linux on current master
Comment 12 Noel Grandin 2022-09-05 14:42:07 UTC
Sorry, mean to say "I get a slide transition effect"
Comment 13 Aron Budea 2022-09-05 15:41:24 UTC
(In reply to Noel Grandin from comment #12)
> Sorry, mean to say "I get a slide transition effect"
Do you get two, though? Once when the first slide gets shown, and once for the second?

(In reply to Timur from comment #10)
> No Tiles slide transition in Windows and Linux with LO 7.5+. I set New again.
I get a transition when showing the first slide, but not for the second, and only on Windows, Linux is fine (the flicker is also only on Windows).

Interestingly, for me, while 7.2.0.4 and 7.4.0.3 skips the second Tiles transition, 7.3.0.3 does show both. Perhaps this is a different regression.

And while I don't get thrown to the desktop in either case, that might depend on the graphics driver. It also depends on whether Skia software rendering is forced, it's actually fine for me with that setting (bar the flicker), and I only get skipped second transition with Skia/Vulkan.
Comment 14 Telesto 2022-09-05 17:46:44 UTC
The issue is gone
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: dc92a4d973086ce8a6a5f75ba0f4d4c9ca05537a
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL threaded

Except for the flickering, but that was present before. No issue with the slide animation either.. 

Closing this bug as WFM.
Comment 15 Timur 2022-09-06 10:37:44 UTC
Telesto literally understood "me" in WFM and closed.. but bug shows is doesn't work for me and partially works for Aron. 
If I click on Tiles, I see flickering. 
I confirm Tiles was OK in 7.3, with filckering (same GDI and Skia).
Not sure what's going on, but I set New again.
Comment 16 Aron Budea 2022-09-06 10:58:08 UTC
(In reply to Timur from comment #15)
> Telesto literally understood "me" in WFM and closed.. but bug shows is
> doesn't work for me and partially works for Aron. 
> If I click on Tiles, I see flickering. 
The flickering was reported separately in bug 137666, and it seems bug 122737 is about the same thing as well, with some great recent insight from Mike.

> I confirm Tiles was OK in 7.3, with filckering (same GDI and Skia).
> Not sure what's going on, but I set New again.
Actually, for my part, I checked again, and in the 7.3 build I checked I had Skia/Raster, that's why I saw both Tiles animations, once switching to Skia/Vulkan, I only saw one, ie. my experience is the same as in other versions, and it seems to go back to when Skia was introduced.

I'm going to report the bug I'm facing separately, since it's different from yours. Perhaps you could consider reporting yours as well, as it's also different from what Telesto reported, and it seems we've managed to separate the various problems.
Comment 17 Timur 2022-09-06 13:02:46 UTC
Let's close then. Aron, please connect via See Also.