Bug 143048 - Autofilter dropdown window width is not resizable
Summary: Autofilter dropdown window width is not resizable
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Heiko Tietze
URL:
Whiteboard: target:7.3.0
Keywords: needsUXEval
: 143829 (view as bug list)
Depends on:
Blocks: AutoFilter
  Show dependency treegraph
 
Reported: 2021-06-24 13:24 UTC by documentfoundation
Modified: 2022-01-31 13:12 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Patch applied (29.38 KB, image/png)
2021-07-20 09:43 UTC, Heiko Tietze
Details
Calc file containing list with much text to filter (16.16 KB, application/vnd.oasis.opendocument.spreadsheet)
2021-08-13 13:32 UTC, Gabriel Dorante
Details
Screenshot showing current wrong behavior (Libreoffice calc 7.2) (71.36 KB, image/png)
2021-08-13 13:33 UTC, Gabriel Dorante
Details
Screenshot showing correct behavior (Excel 2013) (88.23 KB, image/png)
2021-08-13 13:34 UTC, Gabriel Dorante
Details
attachment 174255 opened in recent nightly of trunk against 7.3.0 with current handling (403.48 KB, image/jpeg)
2021-08-19 13:01 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description documentfoundation 2021-06-24 13:24:54 UTC
Hi !

Autofilter drop-down settings window (Sort Asc...|Sort Desc...|First 10.. and other items) often narrow than a column width and even not resizable, so there is no possibility to view long strings in filtered data to select/unselect them - they look the same.

Example:

Some autofiltered column Data:
aaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbbbb cccccccccccccccccccccccc 10x15
aaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbbbb cccccccccccccccccccccccc 11x15
aaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbbbb cccccccccccccccccccccccc 11x16

Autofilter dropdown window:
Sort Asc
Sort Desc
First 10
---
Empty
Not Empty
Standart filter
Search ...
All +-
---
aaaaaaaaaaaaaaaaaaa
aaaaaaaaaaaaaaaaaaa
aaaaaaaaaaaaaaaaaaa
---

It would be nice if user can resize this window

PS. Sorry, if i do here something wrong.
Comment 1 Buovjaga 2021-07-19 15:56:32 UTC
You did not provide your Help - About version info. For me, your test data is not truncated.

Let's ask UX about resizability.

NixOS
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: b1df9c67349cf4cc5be4128d797aefb87f50e38f
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: x11
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Comment 2 Roman Kuznetsov 2021-07-19 16:48:23 UTC
It was the same bug report and Caolan did Autofilter window the same by width as is the column width with many symbols
Comment 3 Heiko Tietze 2021-07-20 06:59:39 UTC
(In reply to Roman Kuznetsov from comment #2)
> It was the same bug report...

Do you have a bug number for the duplicate at hand?
Comment 4 Heiko Tietze 2021-07-20 07:04:50 UTC
Found bug 49813 and bug 133160, one of these?
Comment 5 Roman Kuznetsov 2021-07-20 07:07:39 UTC
(In reply to Heiko Tietze from comment #4)
> Found bug 49813 and bug 133160, one of these?

Yep, I meaned a bug 49813. But I agree, Autofilter window should be resizable, a sit's in Excel.
Comment 6 Heiko Tietze 2021-07-20 09:43:29 UTC
Created attachment 173701 [details]
Patch applied

Patch submitted at https://gerrit.libreoffice.org/c/core/+/119242 (the widget grows with long text; and becomes smaller again) but it looks ugly. And I'm not sure that this works on all platforms (does well with kf5 and gen).
Comment 7 Heiko Tietze 2021-07-20 13:24:18 UTC
Code submitted, please review this solution with the next nightly build. My take: revert and keep the constant width.
Comment 8 Commit Notification 2021-07-20 13:24:27 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/427d4b30a66bade5a9f3b0da337e1644f5dd7c8a

Resolves tdf#143048 - Make autofilter popop resizable

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 V Stuart Foote 2021-07-20 13:44:18 UTC
Sufficient width was already addressed at 6.4.0 and 6.3.4, and revised at 7.1.0

Now need ability to resize the droplist width. When widget becomes too wide bcz of a column's cells with overly long values. For a given column's droplist need to be able to reduce its width as well--not always just match its widest value.

That's looks like what Heiko is attempting.
Comment 10 V Stuart Foote 2021-07-20 14:27:01 UTC
Adjusting summary, width will be up to 1024px as dictated by width of cell content. Remaining issue is to be able to resize the droplist widget.
Comment 11 Heiko Tietze 2021-07-20 15:24:44 UTC
(In reply to V Stuart Foote from comment #10)
> Remaining issue is to be able to resize the droplist widget.

No way, and again: I vote to resolve this as WF and revert the submitted patch that adjusts the autofilter widget.
Comment 12 V Stuart Foote 2021-07-20 15:35:38 UTC
(In reply to Heiko Tietze from comment #11)
> (In reply to V Stuart Foote from comment #10)
> > Remaining issue is to be able to resize the droplist widget.
> 
> No way, and again: I vote to resolve this as WF and revert the submitted
> patch that adjusts the autofilter widget.

Is that "No way" as in there is no effective means without major refactoring? Or is that "No way" as in you are opposed to attempting it? ;-)

But probably best to revert the Gtk UI tweak and accept the droplist matching the column width out to 1024+70 px.
Comment 13 Heiko Tietze 2021-07-20 15:43:30 UTC
The control is a GtkPopup which has no resizable capabilities. We would have to change this to a GtkWindow and make this behave like a pop-up. At least I haven't found a resize solution (which would be better than auto-size).
Comment 14 V Stuart Foote 2021-08-11 21:12:03 UTC
*** Bug 143829 has been marked as a duplicate of this bug. ***
Comment 15 Gabriel Dorante 2021-08-13 13:32:46 UTC
Created attachment 174255 [details]
Calc file containing list with much text to filter
Comment 16 Gabriel Dorante 2021-08-13 13:33:35 UTC
Created attachment 174256 [details]
Screenshot showing current wrong behavior (Libreoffice calc 7.2)
Comment 17 Gabriel Dorante 2021-08-13 13:34:02 UTC
Created attachment 174257 [details]
Screenshot showing correct behavior (Excel 2013)
Comment 18 Heiko Tietze 2021-08-19 10:43:28 UTC
(In reply to Gabriel Dorante from comment #16)
> Screenshot showing current wrong behavior (Libreoffice calc 7.2)
> Screenshot showing correct behavior (Excel 2013)

Apples and oranges. With "wrong" do you mean the large autofilter dialog over-shooting the right window corner?
Comment 19 Gabriel Dorante 2021-08-19 12:39:38 UTC
It is not only a "bigger" size problem, if you pay attention, even a large part of popup window is hidden and you can not make click on "OK" or "Cancel" buttons

Regarding "Apples and Oranges", well, we should have the right to choose one, just like we choose between Tabs and Classic Toolbars UI
Comment 20 V Stuart Foote 2021-08-19 13:01:54 UTC
Created attachment 174412 [details]
attachment 174255 [details] opened in recent nightly of trunk against 7.3.0 with current handling

(In reply to Gabriel Dorante from comment #15)
> Created attachment 174255 [details]
> Calc file containing list with much text to filter

Heiko's working patch is not present in a 7.2.0 build, please retest with current trunk against 7.3.0

Consiterably more width available to the drop list, oddly not the full 1024px but 810px.  Don't see an issue compared to MS Excel handling