Bug 143055 - Snap-to-grid button should be on more toolbars, optionally or by default
Summary: Snap-to-grid button should be on more toolbars, optionally or by default
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: low enhancement
Assignee: Heiko Tietze
URL:
Whiteboard: target:7.5.0 target:7.4.0.0.beta2
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks: Object
  Show dependency treegraph
 
Reported: 2021-06-24 22:46 UTC by Eyal Rozenberg
Modified: 2023-04-20 22:03 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2021-06-24 22:46:17 UTC
There's already a Snap-to-Grid UNO command, but - one doesn't find it where one expects:

* In Writer, it should be on the Drawing toolbar, or at the very least in the optional drawing toolbar buttons. 

* In Draw and Impress, it should be either on the Drawing toolbar, the standard toolbar, or both (e.g. default-on in one and default-of in the other or vice-versa).


Now, it's true, that if you customize your toolbars you can add it there, but:

1. It should be there by default
2. It may not occur to people that it exists, but isn't on those toolbars even optionally - especially since it's available as a preference in Tools | Options. (That's what happened to me; see bug 143012)
Comment 1 V Stuart Foote 2021-06-25 13:52:31 UTC
Well in Writer it is already on the 'Drawing Object Properties' TB; but it would make sense to be added to the 'Drawing' TB and include the 'Grid' visible toggle, though neither set visible by default.

Likewise in sd for Draw/Impress on the 'Drawing' TB, the visible 'Grid' and 'Snap to Grid' actions, should be available by default (as oposed to needing to customize). +1

But consider the 'Edit Points' TB and the 'Glue Points' TB--seems needed there as well.

So which TB, if any, should 'Snap to Grid' be set visible by default?
Comment 2 Eyal Rozenberg 2021-06-25 14:51:38 UTC
(In reply to V Stuart Foote from comment #1)
> So which TB, if any, should 'Snap to Grid' be set visible by default?

For Writer, I'd put it on the Drawing toolbar, visible by default, and close to the beginning (before actual shape buttons).

For Impress and Write... maybe on the default toolbar, right next to the grid visibility icon? I'm less sure here.

Also, can you confirm the issue?
Comment 3 V Stuart Foote 2021-06-25 15:00:53 UTC
(In reply to Eyal Rozenberg from comment #2)

> For Impress and Write... 

Imress and Draw?
 
> Also, can you confirm the issue?

Nope. It is open for UX-Advise, only goes to => WF, or to => NEW should there be concensus to proceed and how.  For now UNCONFIRMED is correct.
Comment 4 Eyal Rozenberg 2021-06-25 15:15:15 UTC
(In reply to V Stuart Foote from comment #3)
> (In reply to Eyal Rozenberg from comment #2)
> 
> > For Impress and Write... 
> 
> Imress and Draw?

Impress and Draw.
Comment 5 Heiko Tietze 2021-07-01 13:47:40 UTC
We discussed this topic in the design meeting.

The pure "Snap to Grid" (.uno:UseGrid) function without accompanying "Show Grid" makes not much sense. And we have both in the main menu under View > Grid, which is sufficient for Writer and Calc. That means removing the items from the toolbars, even when hidden, sounds like a plan here. For Draw/Impress it should be  made more easy to toggle the settings and in addition to the main menu we should add the command to the toolbar.

Code pointer: 

git grep ".uno:UseGrid" * (and the same for show)
Comment 6 Eyal Rozenberg 2021-07-01 20:57:29 UTC
(In reply to Heiko Tietze from comment #5)
> The pure "Snap to Grid" (.uno:UseGrid) function without accompanying "Show
> Grid" makes not much sense. 

Proof that it makes sense:

1. When you disable snapping, you have no need/motivation to start seeing the grid, since you don't interact with it.
2. When we enable snapping again, we're back to the default state of affairs: By default, there is snapping, even though we don't see the grid. And people aren't clamoring for LO to show them the grid.

So, all the sense of turning snapping on and off remains even if we don't touch the Show Grid setting. QED.


> And we have both in the main menu under View Grid, which is sufficient for Writer and Calc. 

It's sufficient when you're writing, but insufficient when you're _drawing_ - even if it's in Writer (or Calc, though I never draw in Calc so I wouldn't know.

Snap-to-Grid is on the ribbons - albeit in menubutton - in MS Office:

https://support.microsoft.com/en-us/topic/turn-the-snap-to-grid-and-snap-to-object-options-on-or-off-in-excel-817da2d4-40cc-4cff-b0de-1359ecbe95e3

and I think that's in all Office apps - when you're drawing.

> For
> Draw/Impress it should be  made more easy to toggle the settings and in
> addition to the main menu we should add the command to the toolbar.

Ok, so we half-agree on this at least... perhaps I'll manage to convince you of the other half.

> Code pointer: 
> 
> git grep ".uno:UseGrid" * (and the same for show)

Wish I had the time to dabble in this right now... :-(
Comment 7 Heiko Tietze 2022-06-24 09:11:29 UTC
Added Display Grid and Snap To Grid to the Drawing toolbar in Writer but invisible and at the end since the toolbar is quite large right now and it follows the Form Design.

For Draw/Impress Snap To Grid comes now after Display Grid on the Standard toolbar, at the page context menu and at the Line & Filling toolbar.
Comment 8 Commit Notification 2022-06-24 11:26:11 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b1c6b936a74e41655e6ba6680654d21d019e5256

Related tdf#143055 - Grid and Snap to Grid on Drawing toolbar

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-06-25 06:12:04 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e18d8bf5cfdb12b75888c2ddd25a829cf5c66305

Resolves tdf#143055 - Make Snap-to-grid easier to access

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2022-06-25 07:03:26 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/4cd7489f5898394730b794bdecbc29800cf23627

Resolves tdf#143055 - Make Snap-to-grid easier to access

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2022-06-25 07:04:34 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/2088f9b4762dcb1009f0030801d641db2bc626ab

Related tdf#143055 - Grid and Snap to Grid on Drawing toolbar

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Stéphane Guillou (stragu) 2023-01-02 14:00:32 UTC
Fix verified in:

Version: 7.4.3.2 / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thanks Heiko!