Bug 154946 - Draw/Impress Standard toolbar missing many icons
Summary: Draw/Impress Standard toolbar missing many icons
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:7.6.0 target:7.5.3.2 target:7....
Keywords: bibisected, bisected, regression
: 154935 (view as bug list)
Depends on:
Blocks: ImpressDraw-Toolbars
  Show dependency treegraph
 
Reported: 2023-04-20 22:03 UTC by Stéphane Guillou (stragu)
Modified: 2023-05-03 10:09 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
7.3 and 7.4 compared (55.01 KB, image/png)
2023-04-20 22:03 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2023-04-20 22:03:11 UTC
Created attachment 186827 [details]
7.3 and 7.4 compared

Bibisected with linux-64-7.4 to first bad commit fc4c7349ed516cba4c93815326500316a8801686 which points to core commit 4cd7489f5898394730b794bdecbc29800cf23627 which is a cherrypick of:

commit da284326961c2e3cfe48cd05b1ea6a51f33a0124
author	Heiko Tietze <tietze.heiko@gmail.com>	Fri Jun 24 11:04:31 2022 +0200
committer	Heiko Tietze <tietze.heiko@gmail.com>	Fri Jun 24 11:04:31 2022 +0200
Resolves tdf#143055 - Make Snap-to-grid easier to access

Since this fix for bug 143055, many icons are missing for Impress and Draw's Standard toolbar. Not sure why I didn't catch it when verifying the fix back then.

Heiko, maybe various missing trailing "/" in https://git.libreoffice.org/core/+/4cd7489f5898394730b794bdecbc29800cf23627%5E%21/ ?

Repro on Ubuntu 20.04 with GNOME 3.36.8 + Wayland and:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 61b41646c5a93ca24f2c9f143cdb0da2c9258989
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Julien Nabet 2023-04-21 07:33:45 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Comment 2 Julien Nabet 2023-04-21 07:34:48 UTC
You're right indeed about the commit you quoted, it brought the regression.

I've submitted https://gerrit.libreoffice.org/c/core/+/150747 on master branch on gerrit.
Comment 3 Heiko Tietze 2023-04-21 08:04:57 UTC
(In reply to Julien Nabet from comment #2)
> I've submitted https://gerrit.libreoffice.org/c/core/+/150747 on master
> branch on gerrit.

I almost started to patch this but you were faster, thank you!
Comment 4 Julien Nabet 2023-04-21 08:10:12 UTC
(In reply to Heiko Tietze from comment #3)
> (In reply to Julien Nabet from comment #2)
> > I've submitted https://gerrit.libreoffice.org/c/core/+/150747 on master
> > branch on gerrit.
> 
> I almost started to patch this but you were faster, thank you!

You're welcome :-)
Comment 5 Commit Notification 2023-04-21 09:05:23 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/593130b0df424a40983b67ce3224dbb40a69556e

tdf#154946: Draw/Impress Standard toolbar missing many icons

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Julien Nabet 2023-04-21 09:08:01 UTC
Xisco did the cherry-pick for 7.5:
https://gerrit.libreoffice.org/c/core/+/150726
and 7.4:
https://gerrit.libreoffice.org/c/core/+/150727
=> let's put this one to FIXED then.
Comment 7 Commit Notification 2023-04-21 12:10:51 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/540c8a86719ca6fdc2163b5057274228cf3db477

tdf#154946: Draw/Impress Standard toolbar missing many icons

It will be available in 7.4.8.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2023-04-21 12:10:54 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/6593cb8b936b4327fb892a6fea80d95d8bb1e32b

tdf#154946: Draw/Impress Standard toolbar missing many icons

It will be available in 7.5.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2023-04-21 12:15:57 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b1d341738d0902e3f71635b16d2d0f9ff63feb79

related tdf#154946: check syntax in git pre-commit hook

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Stéphane Guillou (stragu) 2023-04-24 18:24:14 UTC
*** Bug 154935 has been marked as a duplicate of this bug. ***
Comment 11 Commit Notification 2023-04-26 12:00:23 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-5-3":

https://git.libreoffice.org/core/commit/bc461c45d1a97e0bc1e17cc49e53afbf8f9fcdc2

tdf#154946: Draw/Impress Standard toolbar missing many icons

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Julien Nabet 2023-04-26 12:02:05 UTC
just simplify a bit targets
Comment 13 Commit Notification 2023-05-02 07:27:37 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-4-7":

https://git.libreoffice.org/core/commit/471ff2b0218df3e9b922de1ec28934dd53c77b90

tdf#154946: Draw/Impress Standard toolbar missing many icons

It will be available in 7.4.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.