Bug 143108 - PolyLine appearing/disappearing depending on zoom-level with Skia and anti-aliasing disabled
Summary: PolyLine appearing/disappearing depending on zoom-level with Skia and anti-al...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Skia
  Show dependency treegraph
 
Reported: 2021-06-28 17:58 UTC by Telesto
Modified: 2023-10-09 17:34 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (8.78 KB, application/vnd.oasis.opendocument.graphics)
2021-06-28 17:58 UTC, Telesto
Details
Screencast (381.67 KB, video/mp4)
2021-06-29 06:24 UTC, Telesto
Details
Bibisect log (3.05 KB, text/plain)
2021-06-29 06:53 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-06-28 17:58:05 UTC
Description:
PolyLine appearing/disappearing depending on zoom-level with Skia and anti-aliasing disabled

Steps to Reproduce:
1. Open the attached file
2. Zoom in-out

Actual Results:
A nearly closed shape

Expected Results:
Missing lines


Reproducible: Always


User Profile Reset: No



Additional Info:
Repro with
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c38d0d501f5eca648bdf0fd2914b57e06f505f7e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

not with

Version: 7.1.0.0.beta1+ (x64)
Build ID: f9fab4203c1aa0b9a3f27ce2713b6d5addc7df19
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL
Comment 1 Telesto 2021-06-28 17:58:41 UTC
Created attachment 173250 [details]
Example file
Comment 2 m_a_riosv 2021-06-28 21:30:10 UTC
Please can you detail a bit, the issue.
Comment 3 Telesto 2021-06-29 06:24:44 UTC
Created attachment 173261 [details]
Screencast
Comment 4 Telesto 2021-06-29 06:53:09 UTC
Created attachment 173262 [details]
Bibisect log

Bisected to:
author	Luboš Luňák <l.lunak@collabora.com>	2020-09-25 13:30:11 +0200
committer	Luboš Luňák <l.lunak@collabora.com>	2020-09-29 09:54:42 +0200
commit 4deadc3c78949c18bb886eb1f66caa8f3cd7a2df (patch)
tree c6c17519268c9adaf382f2dd07f71787e2d8cff5
parent cd85546a2fbdade42f80fd3b6bd650791db9f32d (diff)
disentangle AA and B2D use in VCL drawing
A number of powerful functions using B2D polygons such as
OutputDevice::DrawPolyLineDirect() were used only if AA was enabled.
So e.g. dashing for an AA-ed polyline could be drawn directly
using the function, but with AA disabled had to be done manually
by a number of polygon operations. Which doesn't make much sense,
surely these powerful functions can also draw without AA if set so
(and indeed that's mostly the case). And DrawPolyLineDirect() even
had a flag to bypass the check.
So simply try to use B2D-based drawing whenever possible, AA or not.
The previous commit had already changed the naming of the AA option
to not include B2D in the name.

This seems to come from https://bz.apache.org/ooo/show_bug.cgi?id=88795,
which doesn't explain why AA only. There are other bugreports such as
https://bz.apache.org/ooo/show_bug.cgi?id=101491 and
https://bz.apache.org/ooo/show_bug.cgi?id=98289 that are related, but
there I cannot see any difference with this patch. And all unit tests
pass.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4deadc3c78949c18bb886eb1f66caa8f3cd7a2df
Comment 5 m_a_riosv 2021-06-29 11:48:16 UTC
I can't see such behavior. Zooming with the mouse or the keyboard.
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 3618d847a44bb485a3564c600d5005797934b9bb
CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: threaded
Comment 6 Telesto 2021-06-29 13:46:39 UTC
(In reply to m.a.riosv from comment #5)
> I can't see such behavior. Zooming with the mouse or the keyboard.
> Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
> Build ID: 3618d847a44bb485a3564c600d5005797934b9bb
> CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Vulkan; VCL:
> win
> Locale: es-ES (es_ES); UI: en-US Calc: threaded

The major difference might be: Skia Vulkan versus Raster. [Assuming that anti-aliasing being disabled; default is enabled]

I have no clue if the profile is involved too, could be the case
Comment 7 Buovjaga 2022-05-10 06:47:34 UTC
Telesto: can you re-test as I can't repro with Skia/Raster?

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: cdf8e971d5d46df4bcab35a99c4254df9459213f
CPU threads: 2; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: fi-FI (fi_FI); UI: en-US
Calc: threaded Jumbo
Comment 8 Telesto 2022-05-10 07:02:57 UTC
(In reply to Buovjaga from comment #7)
> Telesto: can you re-test as I can't repro with Skia/Raster?
> 
> Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
> Build ID: cdf8e971d5d46df4bcab35a99c4254df9459213f
> CPU threads: 2; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL:
> win
> Locale: fi-FI (fi_FI); UI: en-US
> Calc: threaded Jumbo

I still reproduce

1. Open Draw
2. Tools -> Options -> View -> Uncheck Use Anti-aliasing & Press OK
3. Open the attached file
4. Zoom in-out

It's working fine with Anti-aliasing
Comment 9 Buovjaga 2022-05-10 08:28:44 UTC
Sorry, I forgot to uncheck anti-aliasing as it wasn't in the steps. I do reproduce like that.

Let's ask Luboš his opinion.