Created attachment 173513 [details] Test document to show the problem The parameter "Height" of an image is set to the value of width when any value in the tab "Type" of the image properties dialog is changed. Reproducing the problem: - open the attached document "Test_Bildgröße_V2.odt" - select the image and open the properties dialog - go to tab "Type" - change any value except "Height" or click into one of the listboxes (Position Horizontal, Vertical, ...) What happens: the height value is set (7,50 cm) is changed to the width value (10,00 cm) Expected: Height value remains unchanged. The problem also exists in LOdev 7.3.0.0 but not in LO 7.1 until recent build of LOdev 7.1.6.
Confirmed, Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 0fc020fb73c86a20608e8dff12af607e60327379 CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: threaded
On pc Debian x86-64 with master sources updated today, I could reproduce this with gen rendering and with kf5 not with gtk3 rendering.
Caolán: thought you might be interested in this one since it can't be reproduced with gtk3 but it can be reproduced with gen and kf5 renderings. remark: gtk4 hasn't been available yet on Debian testing. I suppose it's due to hard freeze of testing so I'll got to wait until Bullseyes version is released then gtk4 package should be available.
Created attachment 173518 [details] Bibisect log Bisected to author Miklos Vajna <vmiklos@collabora.com> 2021-06-07 18:03:33 +0200 committer Miklos Vajna <vmiklos@collabora.com> 2021-06-07 18:49:07 +0200 commit 02c435082058ecf7f9d4d73cb47d31d0218dc10d (patch) tree 4331d97262dc82150152d2cb93c68a2813bfcb53 parent a0bbeef0a8d9eeccc9ab9857851e0658139f2e1c (diff) sw keep aspect ratio: add filter for this setting SwViewOption::IsKeepRatio() was only in-memory, so ticking that checkbox and restarting soffice disabled it again. Handle this similar to e.g. the zoom factor which is mapped to a view-specific settings.xml key. https://cgit.freedesktop.org/libreoffice/core/commit/?id=02c435082058ecf7f9d4d73cb47d31d0218dc10d
Adding CC to: Miklos Vajna
Your document explicitly enables KeepRatio in settings.xml: <config:config-item config:name="KeepRatio" config:type="boolean">true</config:config-item> That is why master enables that checkbox for the image. 7.1 behaves differently because it ignores that setting. That being said this looks working as intended. If you disable that Keep Ratio checkbox once, it'll be also remembered in the document. Does that help? Thanks.
(In reply to Miklos Vajna from comment #6) > Your document explicitly enables KeepRatio in settings.xml: > > <config:config-item config:name="KeepRatio" > config:type="boolean">true</config:config-item> > > That is why master enables that checkbox for the image. 7.1 behaves > differently because it ignores that setting. That being said this looks > working as intended. If you disable that Keep Ratio checkbox once, it'll be > also remembered in the document. > > Does that help? Thanks. Many thanks, but the answer is not completely helpful. It is good that the entry "KeepRatio" was introduced in settings.xml with LO 7.2. Until LO 7.1 this setting from "Image Properties" did exist in the memory only but was not saved in the document. But IMHO the current solution isn't perfect: 1. When "Keep Ratio" in Image Properties dialog is switched off and the document is saved (!) the behavior described in the bug report doesn't exist - OK! 2. But: In my understanding Keep Ratio means the proportion between width and heigt is kept when one of both is changed - not both are set equal! This cannot be correct. 3. To prevent the behavior described in the bug report I must save the document with "Keep Ratio" off always. When I want to change image size with keep the ratio I must switch on "Keep Ratio" temporarily for the change but I must switch of before the document is saved. Am I right? If yes the current solution is not really better as it was until LO 7.1 without the new settings entry.
Amendment/Correction to point 1. in Comment 7: 1. Immediately after "Keep Ratio" has been switched off in the Image Properties dialog (even without saving the document), the behavior described in the bug report does not exist - OK!
In further tests I have found that Undo/Redo for checking and unchecking KeepRatio in the Image Properties dialog is not properly handled. This problem is described as separate Bug 143340. OK?
[Automated Action] NeedInfo-To-Unconfirmed
(In reply to Stefan_Lange_KA@T-Online.de from comment #9) > In further tests I have found that Undo/Redo for checking and unchecking > KeepRatio in the Image Properties dialog is not properly handled. This > problem is described as separate Bug 143340. OK? Sounds like a good idea to me. (In reply to Stefan_Lange_KA@T-Online.de from comment #8) > Amendment/Correction to point 1. in Comment 7: > 1. Immediately after "Keep Ratio" has been switched off in the Image > Properties dialog (even without saving the document), the behavior described > in the bug report does not exist - OK! Fine, then closing this.
Not a bug - seriously? Please watch points 2. and 3. of Comment 7 (here more precisely): 2. But: In my understanding Keep Ratio means the proportion between width and height will be kept when one of both is changed [by proportional changing the other]. Set both equal cannot be correct! 3. To prevent the behavior described in the bug report I must save the document with "Keep Ratio" off always. When I want to change image size with keep the ratio I must switch on "Keep Ratio" temporarily for the change but I must switch of before I exit the dialog [instead "before the document is saved"]. Am I right? If yes the current solution is not really better as it was until LO 7.1 without the new settings entry.
This bug was marked as a regression. I understood comment 7 says at the end you get the idea why the keep ratio checkbox works the way it does in newer vs older versions, so the regression concern is addressed. Feel free to file a follow-up non-regression bug in case you have further concerns; alternatively you can also mark this bug as a non-regression and reopen it. Thanks. And yes, you're right, the only change is that the setting no longer reset to "false" after restarting Writer. Anything else: it's as good/bad as it was before.
The main problem (see the title of the bug report) is that width and height are set equal when Keep Ratio is switched on and position (left, right etc.) or anchoring (page, paragraph etc.) are changed - or Keep Ratio is switched off. Ratio is not kept but set to 1! IMHO these actions never should change the size of the image even if Keep Ratio is switched on or off. Keep Ratio only should influence the change of the image size (width and height are changed proportionally [on] or not [off]). The erroneous behavior is new and it was introduced with LO 7.2. Therefore I think it is correct when I reopen the bug with the marker "regression".
(In reply to Stefan_Lange_KA@T-Online.de from comment #14) > The main problem (see the title of the bug report) is that width and height > are set equal when Keep Ratio is switched on and position (left, right etc.) > or anchoring (page, paragraph etc.) are changed - or Keep Ratio is switched > off. Ratio is not kept but set to 1! > > IMHO these actions never should change the size of the image even if Keep > Ratio is switched on or off. > Keep Ratio only should influence the change of the image size (width and > height are changed proportionally [on] or not [off]). > > The erroneous behavior is new and it was introduced with LO 7.2. Therefore I > think it is correct when I reopen the bug with the marker "regression". Lets set it simply to NEW. This is a true bug. 1. Open attachment 173542 [details] 2. Select the image -> Image properties 3. Type Tab 4. Ratio is disabled (in this document) 5. Say you want to resize: select keep ratio 6. Resize Height or width -> (fine) 7. Press OK 8. Reopen the Image properties dialog (keep ratio checked) 9. Click inside the Height box (or select the Margin drop down'). Now it's broken
1. Open attachment 173985 [details] (this simply another file.. not that important) 2. Select the image and press F4 3. Type tab 4. Check keep ratio 5. Press OK 6. Press F4 again 7. Uncheck keep ratio Height changes from 8,25 to 5,54 cm
After I have reproduced the bug some days ago still with LO 7.2.0 release I have retested today [28.08.2021] with recent builds (7.2.1 rc1, dev 7.2.2, dev 7.3.0). In these tests the problem occured no longer - neither with my own files (test and "productive") nor with the simple test file attached by Telesto (see Comment 16). Therefore I change the status to RESOLVED WORKSFORME. OK?
(In reply to Stefan_Lange_KA@T-Online.de from comment #17) > After I have reproduced the bug some days ago still with LO 7.2.0 release I > have retested today [28.08.2021] with recent builds (7.2.1 rc1, dev 7.2.2, > dev 7.3.0). In these tests the problem occured no longer - neither with my > own files (test and "productive") nor with the simple test file attached by > Telesto (see Comment 16). > Therefore I change the status to RESOLVED WORKSFORME. OK? Based on the range I would say it was fixed by bug 143633. But need reverse bibisect to be sure..