Description: Translation is not applied in some UI such as 'Option dialog' This also happens in languages other than Japanese Steps to Reproduce: 1. Start LibreOffice 2. Choose Menu [Tools]-[Options] 3. Translation not applied in the menu on the left of 'Options dialog' Writer style name is also not displayed 1. Start Writer 2. Select 'style' button in the 'Sidebar' 3. Style name translation not applied Actual Results: Translation is not applied to part of the UI. Even though it is translated by Weblate. Expected Results: Translation applies to all UI Reproducible: Always User Profile Reset: No Additional Info: Nishibori-san discovered that the problem had occurred since the following build. https://git.libreoffice.org/core/+/0771ac00acc8730f77db76b901724f1513a32723 It didn't happen in the following build, which was the previous patch. https://git.libreoffice.org/core/+/0d97abc8ef890b2e2ead34c449f2a140e22dd5ee He showed us at the demo of Japanese online hackfest #60. https://youtu.be/E55TLUp3gW0?t=4846 It is occurring in my environment below: Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 1115d4d5ac63394ca0f3f1b75dc81916cdbeebe9 CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-07-13_16:10:25 Calc: threaded In my environment, it does not reproduce in the following versions: Version: 7.1.4.2 / LibreOffice Community Build ID: a529a4fab45b75fefc5b6226684193eb000654f6 CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP Calc: threaded Version: 7.2.0.1 / LibreOffice Community Build ID: 32efc3b7f3a71cfa6a7fa3f6c208333df48656cc CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: zh-TW (ja_JP.UTF-8); UI: zh-TW Calc: threaded
Created attachment 173638 [details] Screenshot of version comparison Comparison by version in 'Option dialog'
Created attachment 173640 [details] screenshot with French UI On pc Debian x86-64 with master sources updated today, I could reproduce this. I removed my dev LO profile so it generates a brand new one. The screenshot shows: - the French menu at top of the screen (OK) - the French menu at right of dialog Tools/Options (OK) - the English menu at left of dialog Tools/Options (KO) - the English menu at right of the screen on sidebar/styles (KO)
Xisco/Heiko: before asking localization people, thought you might be interested in this one as "UI guys". BTW, the screenshot was done with gtk3 rendering but I can reproduce this too with gen rendering.
It seems that this issue has come up since rev. 0771ac00acc8, but never had done until rev. 0d97abc8ef89. And the 0d97abc8ef89 is the parent of the 0771ac00acc8.
I'm sorry, I didn't read Shinji Enoki's report well. Comment 4 was a duplication of what he said. Please ignore the Comment 4.
*** This bug has been marked as a duplicate of bug 142973 ***
Created attachment 173645 [details] Screenshot with Win-x86_64@tb77-TDF ja Reproduced also in Windows. (But behavior seems to be a little bit different in the "Option" dialog.) It is occurring in my environment below (daily master Win-x86_64@tb77-TDF 2021-06-18_05.27.46): Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: a78510ab673dd0d827efeb00873d5d9137813be7 CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: ja-JP (ja_JP); UI: ja-JP Calc: CL In my environment, it does not reproduce in the following version (daily master Win-x86_64@tb77-TDF 2021-06-17_05.25.14): Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: c703b2d22c3f45825d9c9d790c3b5a4b6f97e776 CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: ja-JP (ja_JP); UI: ja-JP Calc: CL
I overlooked a duplicate comment. Excuse me.
Created attachment 173651 [details] comparison between 0771ac00acc8 and ac6c82452405 In my humble opinion, if the commit 0771ac00acc8 was reverted, the lost translation would be shown again in the UI anyway. My process of examining to show the lost translation again was: 1. git checkout master 2. git pull 3. git checkout -b fix-143409 4. git revert 0771ac00acc8 # And a local commit ac6c82452405 was created. 5. ./autogen.sh 6. make As the result, Please see the attached image. I'm sorry, I'm not a programmer, and cannot explain why it worked and am not sure if the way is smart or rational.
Created attachment 173652 [details] commit log of ac6c82452405 The attachment is the log for my local commit ac6c82452405.
(In reply to Kiyotaka Nishibori from comment #9) > ... > I'm sorry, I'm not a programmer, and cannot explain why it worked and am not > sure if the way is smart or rational. Just for info, there's a fix here waiting for review: https://gerrit.libreoffice.org/c/core/+/119120 You can see last info about this bug in https://bugs.documentfoundation.org/show_bug.cgi?id=142973
Thank you Shinji Enoki and Kiyotaka Nishibori for having spotted the culprit commit! It helped a lot to find the location to fix.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7712eb23bc97090fdd655a36dfca0019d43799e6 tdf#143409: fix Translation is not applied in some UI It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
It's already RESOLVED FIXED at #142973, but I confirmed by the daily build that the bug has been fixed. Thank you for fixing the bug. Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: c5ca46e75e28ba4245d8544ca53c71fea87d1bbd CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-07-20_00:22:42 Calc: threaded
Thank you for your feedback! Let's put this one to VERIFIED then.