Bug 144444 - [UI] Inconsistency in UI for curve points
Summary: [UI] Inconsistency in UI for curve points
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: HelpGaps-NewFeatures
  Show dependency treegraph
 
Reported: 2021-09-11 15:29 UTC by Olivier Hallot
Modified: 2023-12-12 11:08 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2021-09-11 15:29:22 UTC
Description:
Same command has 2 UI names

Steps to Reproduce:
String  'aEwRC' refers to "Points" (of a curve) and displays "Points (F8)" in curve context menu, toolbar tootip and may be elsewhere.

https://translations.documentfoundation.org/translate/libo_ui-master/officecfgregistrydataorgopenofficeofficeui/en/?checksum=dbc4806f6c7101fc&q=+note%3AaEwRC+&sort_by=-priority%2Cposition

String 'YBFJB' refer to the same command and is listed in the Visible buttons of the Drawing toolbar and list named "Edit Points (F8)"

https://translations.documentfoundation.org/translate/libo_ui-master/officecfgregistrydataorgopenofficeofficeui/en/?checksum=c8fb89ae4edf3860&q=+note%3AYBFJB&sort_by=-priority%2Cposition


Actual Results:
Different strings for same command

Expected Results:
Please make it just one.


Reproducible: Always


User Profile Reset: No



Additional Info:
As user, I prefer
"Edit curve points"
"Edit curve control points"
Comment 1 Heiko Tietze 2021-09-15 08:56:37 UTC
The command .uno:ToggleObjectBezierMode comes with 

Label: YBFJB‖Edit Points
Tooltip: aEwRC‖Points

(the F8 shortcut is added on-the-fly according the local customization).

It's indeed not a verbose tip. The function does not edit actually but toggle the mode from object to point and shows the Edit Points toolbar. So my take is 

"Toggle point edit mode"


Code pointer: ".uno:ToggleObjectBezierMode" in officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
Comment 2 Commit Notification 2023-10-24 07:17:09 UTC
Cosmin Humeniuc committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/59ce453ea5ed5227633f44bb86545d122d48de01

tdf#144444 Use same strings for same command

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Buovjaga 2023-10-24 07:35:28 UTC
Has to stay open as Help needs to be updated
Comment 4 Commit Notification 2023-10-24 20:28:39 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/e423f2a7995db5bd4da002309afdd5efaf06af21

tdf#144444 tdf#155877 Toggle edit points
Comment 5 Adolfo Jayme Barrientos 2023-10-24 23:19:19 UTC
A command name should be written in Title Case.
Comment 6 Commit Notification 2023-10-30 13:32:01 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/acb9fd45cdf33a7ad567dad95dfea0ad33a6b915

tdf#144444 Use title case Toggle Point Edit Mode
Comment 7 Commit Notification 2023-10-30 19:24:35 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a18174e807e8704c385637b8a53c45b9608bfa42

tdf#144444 Use title case Toggle Point Edit Mode

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 sdc.blanco 2023-12-11 14:12:56 UTC
(In reply to Heiko Tietze from comment #1)
> So my take is 
> "Toggle point edit mode"
(before the paint dries on this change) -- Maybe it should be:

"Toggle Edit Points Mode"

Reason:  Several online help files already refer to "Edit Points" mode. (see [1])
Given that "point edit mode" was just invented, it seems better to use a term that is consistent with already existing help pages (rather than changing these existing pages to keep consistency). 

[1] https://help.libreoffice.org/24.2/en-US/search?P=%22edit+points+mode%22&DEFAULTOP=and&xP=Bedit%09Fedit%09Sedit%09edit%09Bpoints%09Fpoints%09Spoints%09points%09Bmode%09Fmode%09Smode%09mode&xFILTERS=.%7E%7E
Comment 9 Heiko Tietze 2023-12-11 15:50:18 UTC
(In reply to sdc.blanco from comment #8)
> (before the paint dries on this change)
Isn't it totally dry?

> "Toggle Edit Points Mode"
Depends on whether you have an "edit-point" (don't think plural makes sense here) or and "edit-mode". Quite some bike-shedding to me, and "fixed" for good by translators anyway.
Comment 10 sdc.blanco 2023-12-12 10:20:15 UTC
(In reply to Heiko Tietze from comment #9)
> Quite some bike-shedding to me.
Yes, your analysis looks like that, by focusing on some grammatical issues, when my question was the exact opposite, namely to look at the consequence of the choice in relation to other existing help pages. Did you look at the examples given in the link?

> and "fixed" for good by translators anyway.
But it was you who proposed the new label, presumably without looking at the bigger consequences, and it does not matter who made the change, if they did not look at the consequences. 

ftr, the wording does not matter to me, but given that there is already "Edit Points" mode appearing in about 5 or 6 different help pages, it seems silly to introduce a new term such as "point edit" (or any of the other variations you mentioned in comment 9). My point was only that there is already an existing terminology in the help pages, "edit point" mode, so why not use this same label in the new toggle, rather than introduce an ambiguity about the relation/difference between "point edit" mode and "edit point" mode?
Comment 11 Heiko Tietze 2023-12-12 11:08:09 UTC
(In reply to sdc.blanco from comment #10)
> Did you look at the examples given in the link?
Briefly, didn't get the point.

> My point was only that there is already an existing terminology 
> in the help pages, "edit point" mode...
Makes sense. And since I still believe the translators will "fix" all issues with create with the labels it shouldn't be a big deal. 

(In reply to sdc.blanco from comment #8)
> "Toggle Edit Points Mode"
Sounds better than what we have "The [Edit Points] mode enables..." in Show Draw Functions and clicking on the link gives "Choose Edit - Toggle Point Edit Mode". 

However, I believe it was never an "Edit-Point" but the function "Edit (the) Points". All other commands around use different verbs like "Insert Point" and not "Insert Edit-Point".

How much effort is it to change the five help pages?