Description: LibreOffice Writer crashes when I try to modify a style Steps to Reproduce: 1. Open a new text document 2. Open the stylist and select a style 3. right click and choose "Modify" Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: a78190da867864485b5d0a91238616bd4090b5b5 CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: en-US Ubuntu_20.04_x86-64 Calc: threaded In the console, I get the following error messages: (soffice:3939551): Gdk-WARNING **: 00:49:32.937: Couldn't map window 0x557f24f31440 as subsurface because its parent is not mapped. (soffice:3939551): Gdk-WARNING **: 00:49:32.937: Couldn't map as window 0x557f24f31440 as popup because it doesn't have a parent (soffice:3939551): GLib-GObject-CRITICAL **: 00:49:32.939: g_object_get_qdata: assertion 'G_IS_OBJECT (object)' failed Same crash in LO 7.2.3.0.0+ Version: 7.2.3.0.0+ / LibreOffice Community Build ID: a928bab9fb68ff8fe45aca212b3c794799db31f6 CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Ubuntu_20.04_x86-64 Calc: threaded
Created attachment 175277 [details] bt with debug symbols On pc Debian x86-64 with master sources updated today and with gtk3 rendering only (not with kf5 or gen rendering), I could reproduce this. Here's an even more straightforward to reproduce this. - launch Writer - Click Style menu - Select Edit Style... => Crash
I don't reproduce this with LO Debian package 7.2.1.2
Here's a straightforward patch but is it the right way to fix this? diff --git a/svx/source/dialog/frmsel.cxx b/svx/source/dialog/frmsel.cxx index 435cd489d482..361503690f9b 100644 --- a/svx/source/dialog/frmsel.cxx +++ b/svx/source/dialog/frmsel.cxx @@ -824,6 +824,7 @@ bool FrameSelectorImpl::SelectedBordersEqual() const FrameSelector::FrameSelector() { + mxImpl.reset( new FrameSelectorImpl( *this ) ); } void FrameSelector::SetDrawingArea(weld::DrawingArea* pDrawingArea)
I'd just move the line to before the set_size_request which triggers the crashign callback
https://gerrit.libreoffice.org/c/core/+/122631
(In reply to Caolán McNamara from comment #5) > https://gerrit.libreoffice.org/c/core/+/122631 This patch fixes the crash for me. Best regards. JBF
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c92a29fd6ef341a1657f90759d20e4f052b45843 tdf#144729 create FrameSelectorImpl before setting size request It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
done in trunk, backport to 7-2 in gerrit
I confirm I don't reproduce the crash after your patch Caolán, thank you! :-)
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/2b96bf1fd8f4287a06b79dbec14114ca6c035731 tdf#144729 create FrameSelectorImpl before setting size request It will be available in 7.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2-2": https://git.libreoffice.org/core/commit/44dd4ea32bf4b21385f6eb8e96aa4115291adebf tdf#144729 create FrameSelectorImpl before setting size request It will be available in 7.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Julien Nabet from comment #9) > I confirm I don't reproduce the crash after your patch Caolán, thank you! :-) Idem for me on both master and LO 7.2.3.0.0+. Thank you very much Caolán! Best regards. JBF
*** Bug 144791 has been marked as a duplicate of this bug. ***