Description: When trying to add a new word to the dictionary (right-click on the word and select the line "add to dictionary" (by the way, this line is not translated)), a small sign appears with the inscription "The dictionary is already filled in" (I use the Russian version). What to do? Steps to Reproduce: 1.Hover the cursor over a word that is missing in the dictionary (it is underlined) 2.Right-click 3.Selecting the line "add to dictionary" + left click Actual Results: A small window appears with the inscription "The dictionary is already filled in" Expected Results: I pressed the "OK" button in the window Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.1.2 (x64) / LibreOffice Community Build ID: 87b77fad49947c1441b67c559c339af8f3517e22 CPU threads: 6; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: CL
Created attachment 175500 [details] A window with the inscription "The dictionary is already filled in"
Does this only happen with the Russian dictionary? I can't reproduce the problem with English (USA). Arch Linux 64-bit Version: 7.4.2.3 / LibreOffice Community Build ID: 40(Build:3) CPU threads: 8; OS: Linux 6.0; UI render: default; VCL: kf5 (cairo+xcb) Locale: fi-FI (fi_FI.UTF-8); UI: en-US 7.4.2-1 Calc: threaded
I assume the string is "The dictionary is already full" in English. It is defined here: https://opengrok.libreoffice.org/xref/core/include/editeng/editrids.hrc?r=f7f0f399#308 And it is only used here: https://opengrok.libreoffice.org/xref/core/editeng/source/misc/unolingu.cxx?r=91fef4a4#738 This is triggered if the dictionary has 30,000 or more entries. Size is checked in DictionaryNeo::isFull() here: https://opengrok.libreoffice.org/xref/core/linguistic/source/dicimp.cxx?r=3d236177#920 DIC_MAX_ENTRIES limit of 30,000 is defined here: https://opengrok.libreoffice.org/xref/core/linguistic/source/dicimp.hxx?r=fd3888c6&fi=DIC_MAX_ENTRIES#33 Not sure why this hard limit. I don't see it documented: https://help.libreoffice.org/7.4/en-US/text/shared/optionen/01010400.html Any reason for this hard 30,000 limit? Should this report be changed into a documentation issue?
If the issue is the 30,000 limit we could just remove the limit. Its unclear why there is a limit there. https://gerrit.libreoffice.org/c/core/+/145916 would do that, and presumably let us find out why there is a limit :-)
A workaround is to create a new custom dictionary that will allow another set of 30,000 words! I think there is no need of such restriction. I can reproduce using Marathi(IN) Dictionary. Version: 7.4.3.2 (x64) / LibreOffice Community Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890 CPU threads: 1; OS: Windows 10.0 Build 14393; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bd0b3aac25b5163ae21fff613131cb3ff068e816 tdf#144915 effectively remove limit on number of words in dictionary It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.