Bug 145655 - Add animation button only has the "Add" label
Summary: Add animation button only has the "Add" label
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
(earliest affected) alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Caolán McNamara
Whiteboard: target:7.3.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: GTK3 Sidebar-Animation
  Show dependency treegraph
Reported: 2021-11-13 09:18 UTC by Aron Budea
Modified: 2021-11-15 14:02 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Screenshot (106.01 KB, image/png)
2021-11-13 09:18 UTC, Aron Budea

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2021-11-13 09:18:05 UTC
Created attachment 176227 [details]

The plus symbol in the animation sidebar pane has changed to "Add" recently, see attached screenshot.

If I look at it in Windows, or with VCL plugin set to 'gen', both the + sign and the "Add" label are visible, thus I assume that is the desired output.
It also looks weird that one button only has text, while the others only have icons.

This is a regression from the following commit. Adding CC: to
author		Heiko Tietze <tietze.heiko@gmail.com>	2021-10-18 12:50:26 +0200
committer	Heiko Tietze <heiko.tietze@documentfoundation.org>	2021-10-20 07:12:28 +0200

Related tdf#145037 and tdf#145028 - Animation sidebar usability
Comment 1 Caolán McNamara 2021-11-13 21:39:05 UTC
Well, https://bugs.documentfoundation.org/show_bug.cgi?id=145028#c3 has "The patch adds a label to the Add button" so it seems intentional so it wouldn't be right to revert it out of hand because its now different that what it was. If we wanted gtk to show the icon *and* the text we can toggle on always-show-image, I think that's not contentious so I proposed that as https://gerrit.libreoffice.org/c/core/+/125174 to resolve this
Comment 2 Commit Notification 2021-11-14 19:13:21 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":


tdf#145655 toggle on always-show-icon for animation panel 'add' button

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:

Affected users are encouraged to test the fix and report feedback.
Comment 3 Aron Budea 2021-11-15 14:02:10 UTC
Verified in LO Version: (e6968f0485cfb2f6c941d11c438386e14a47095d) / Ubuntu.
Thanks for fixing, Caolán!