Bug 145733 - Calc: Shrink to cell size results in tiny ###
Summary: Calc: Shrink to cell size results in tiny ###
Status: VERIFIED DUPLICATE of bug 143978
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.2.0.4 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-17 11:03 UTC by Jernej Simončič
Modified: 2021-11-17 14:01 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the problem (25.98 KB, image/png)
2021-11-17 11:03 UTC, Jernej Simončič
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jernej Simončič 2021-11-17 11:03:24 UTC
Description:
When you have a cell with "Shrink to fit cell size" formatting, numbers and dates that exceed cell width appear as tiny ### text instead of displaying with smaller font size.

Steps to Reproduce:
1. format a cell with "Shrink to fit cell size"
2. enter a number or date wider than the width of cell


Actual Results:
Calc shows very small ### in cell

Expected Results:
Date or number visible in shrunken font


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.2.2 (x64) / LibreOffice Community
Build ID: 02b2acce88a210515b4a5bb2e46cbfb63fe97d56
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: sl-SI (sl_SI); UI: sl-SI
Calc: threaded
Comment 1 Jernej Simončič 2021-11-17 11:03:55 UTC
Created attachment 176310 [details]
Screenshot of the problem
Comment 2 Kevin Suo 2021-11-17 11:24:21 UTC
Do you have any idea which is the last version it ever worked?
Comment 3 Roman Kuznetsov 2021-11-17 11:41:21 UTC
For Numbers works fine in

Version: 7.3.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 7b8f630db30ee0066a9f4b6e540368d2fcad7fa8
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: threaded

and in

Version: 7.2.0.4 (x64) / LibreOffice Community
Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: threaded


But for Data I can confirm the problem in 7.2

but works fine in

Version: 7.1.0.3 (x86) / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: threaded

=> regression

but Data works fine again in 

Version: 7.3.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 7b8f630db30ee0066a9f4b6e540368d2fcad7fa8
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: threaded

Xisco, what should we do with this bug report?
Comment 4 Jernej Simončič 2021-11-17 11:55:56 UTC
I just tested in a VM, 7.1.5.2 works fine while 7.2.0.4 has the problem.
Comment 5 Kevin Suo 2021-11-17 13:08:58 UTC
I can confirm this issue exists in an earlier version of the master branch but was fixed somewhere on master. I am doing reverse-bibisecting to see which commit fixed this.
Comment 6 Kevin Suo 2021-11-17 13:20:39 UTC
Reverse-bibisected to range e95bcf952abfcde18caca2058260e9213003df8a..dc3d2a2dcc47a1220db43f1807d234a06fb78fe9:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=e95bcf952abfcde18caca2058260e9213003df8a..dc3d2a2dcc47a1220db43f1807d234a06fb78fe9

Within which the following commit:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=6ee4ce119b55d6e415696b23432fe65eabc94c17
(consider font when caching SalLayoutGlyphs in calc (tdf#143978) )
may have fixed this.

I see in bug 143978 that the commit was applied to version 7.2.3, so it may works fine if you upgrade to version 7.2.3.

Mark as a duplicate of bug 143978.

*** This bug has been marked as a duplicate of bug 143978 ***
Comment 7 Xisco Faulí 2021-11-17 13:29:46 UTC
(In reply to Kevin Suo from comment #6)
> Reverse-bibisected to range
> e95bcf952abfcde18caca2058260e9213003df8a..
> dc3d2a2dcc47a1220db43f1807d234a06fb78fe9:
> https://cgit.freedesktop.org/libreoffice/core/log/
> ?qt=range&q=e95bcf952abfcde18caca2058260e9213003df8a..
> dc3d2a2dcc47a1220db43f1807d234a06fb78fe9
> 
> Within which the following commit:
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=6ee4ce119b55d6e415696b23432fe65eabc94c17
> (consider font when caching SalLayoutGlyphs in calc (tdf#143978) )
> may have fixed this.

I do confirm the issue is fixed by the mentioned commit.
Bisected with bibisect-linux64-7.3
Comment 8 Kevin Suo 2021-11-17 13:58:26 UTC
But I am still confused: Why it works fine in 7.1 branch, but in bug 143978 it is indicated that the version affected is 5.4.0.3?
Comment 9 Xisco Faulí 2021-11-17 14:01:16 UTC
For the record, the issue started to happen after 

https://cgit.freedesktop.org/libreoffice/core/commit/?id=d62ad3efe3c8778cfda00799f1cd7bb3349e0b75

see also bug 143659