Bug 145848 - Don't close macro selector when editing macros
Summary: Don't close macro selector when editing macros
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.2.2.2 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 149682 (view as bug list)
Depends on:
Blocks: Beanshell-Editor
  Show dependency treegraph
 
Reported: 2021-11-23 07:56 UTC by Samuel Mehrbrodt (allotropia)
Modified: 2022-06-23 13:34 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Mehrbrodt (allotropia) 2021-11-23 07:56:49 UTC
1. Go to Tools->Macros->Organize Macros->Basic
2. Select one Macro and click "Edit"

The macro selector closes and the editor window opens.
If you want to go back and edit a different macro, you have to navigate through the menu again, which is rather annoying.

The macro selector should not be closed when clicking "Edit", so that viewing/editing different macros is easier.
Comment 1 Samuel Mehrbrodt (allotropia) 2021-11-23 08:12:15 UTC Comment hidden (no-value)
Comment 2 Caolán McNamara 2021-11-24 16:04:42 UTC
I'm added on cc here, and reference made to bug 126828 / https://git.libreoffice.org/core/commit/cac8694feab1ccb422294ed3e2f8b682e15835fb but this is not a regression from that commit, right? In other words it has always worked like the file open dialog and is dismissed when a new macro is selected to edit?
Comment 3 Samuel Mehrbrodt (allotropia) 2021-11-29 07:00:33 UTC
(In reply to Caolán McNamara from comment #2)
> I'm added on cc here, and reference made to bug 126828 /
> https://git.libreoffice.org/core/commit/
> cac8694feab1ccb422294ed3e2f8b682e15835fb but this is not a regression from
> that commit, right? In other words it has always worked like the file open
> dialog and is dismissed when a new macro is selected to edit?

Ok, I just checked an older version (4.3) and you are right, it has already behaved like that since ~forever.

So comment 1 is wrong.
Comment 4 Heiko Tietze 2021-11-29 08:43:03 UTC
Tools > Macro > Organize > Basic shows the organizer with a large tree with shipped macros. Select for example Gimmicks > Autotext and Edit. Open the navigator again and you get the tree at the same position. Seems reasonable to me. Or am I wrong?
Comment 5 Samuel Mehrbrodt (allotropia) 2021-11-30 07:00:51 UTC
(In reply to Heiko Tietze from comment #4)
> Tools > Macro > Organize > Basic shows the organizer with a large tree with
> shipped macros. Select for example Gimmicks > Autotext and Edit. Open the
> navigator again and you get the tree at the same position. Seems reasonable
> to me. Or am I wrong?

Opening the macro dialog is cumbersome, since you have to navigate 3 menu levels: Tools->Macros->Organize Macros->Basic.

If you want to edit several macros, this is really annoying, that the macro organizer dialog just doesn't stay there.
Comment 6 Heiko Tietze 2021-11-30 07:08:28 UTC
By default we show the Object Catalog left of the editor. Is this sufficient?
Comment 7 Samuel Mehrbrodt (allotropia) 2021-11-30 07:10:53 UTC
(In reply to Heiko Tietze from comment #6)
> By default we show the Object Catalog left of the editor. Is this sufficient?

Works for Basic, but not for Beanshell for example :)
Comment 8 Heiko Tietze 2021-11-30 07:21:00 UTC
Can we open bsh/js in the same editor as Basic? Would solve this issue as well as your bug 97638.
Comment 9 Leslie 2021-12-31 17:18:59 UTC
I am in favour of changing the way the Object Catalog behaves.  
In fact the best thing would be if the Object Catalog persisted in all cases. It should never act on its own opening and closing sub folders.  
It should even remember its place when the Libre Office component is closed and opened again.
Comment 10 Heiko Tietze 2022-01-31 13:35:13 UTC
Suggestion is to list bsh/js files similar to Basic, removing UX keyword now.
Comment 11 Caolán McNamara 2022-01-31 14:03:17 UTC
FWIW bsh/js are very obscure IMO, there is a recent suggestion listed in the ESC minutes wrt removing that from the default install and moving them into an extension
Comment 12 Heiko Tietze 2022-06-23 12:40:54 UTC
*** Bug 149682 has been marked as a duplicate of this bug. ***
Comment 13 Rafael Lima 2022-06-23 13:34:46 UTC
(In reply to Heiko Tietze from comment #12)
> *** Bug 149682 has been marked as a duplicate of this bug. ***

FTR the enhancement request in bug 149682 marked as duplicate of this one is about a different dialog, which is opened in:

Tools - Macros - Run Macro

This bug requests an enhancement in a different dialog:

Tools - Macros - Organize Macros - Basic

The requests are similar, but in two different dialogs. So I think it's OK to discuss both of them in a single ticket.