Bug 145910 - Half the Slide Transitions do not work any more - openGL configuration
Summary: Half the Slide Transitions do not work any more - openGL configuration
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.2.2.2 release
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:7.4.0 target:7.3.0.0.beta2
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-27 10:11 UTC by Alistair Saywell
Modified: 2024-03-01 17:19 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Test document with slides. Try Slide transitions, starting with "Tiles" (28.44 KB, application/vnd.oasis.opendocument.presentation)
2024-03-01 17:11 UTC, Robert Großkopf
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alistair Saywell 2021-11-27 10:11:18 UTC
In 7.2.2.2 and 7.3.0.0alpha1 all the Transitions after Diagonal (17 of them) do not work (except Honeycomb which has a partially successful transition but as a wipe in from side). Those slide transitions still fail in safe mode.

These slide transitions work correctly in 7.1.5.2 and 7.1.7.2

 To reproduce: 
1. Open Impress and create from template, for example, Focus
2. Select a slide transition from the last half of the selection (after Diagonal) and apply to all
3. Run slideshow and slides abruptly change to next slide without any transition effect. In fact, the lack of effect can be seen in step 2. 

Version: 7.2.2.2 (x64) / LibreOffice Community
Build ID: 02b2acce88a210515b4a5bb2e46cbfb63fe97d56
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: default; VCL: win
Locale: en-NZ (en_NZ); UI: en-GB
Calc: CL

Cheers, Al
Comment 1 Julien Nabet 2021-11-27 12:38:01 UTC
Could you give a try at brand new 7.2.3 and if you still reproduce this try https://wiki.documentfoundation.org/QA/FirstSteps ?
Comment 2 Alistair Saywell 2021-11-28 03:50:21 UTC
I probably should have said that the 7.2.2.2 was a new install with fresh profile and that I had tested in Safe mode too with same results. 

Clean install of 7.2.3.2 and still the same results: the transitions work up until and including Diagonal, after that they are a simple replacement. 
Same in Safe Mode and same with Skia disabled. Tested with Focus template and with Candy template

Just tested on another computer, similar set up and transitions work. I guess it is now my problem. Any clues on why only half the transitions work?
Comment 3 QA Administrators 2021-11-28 04:09:26 UTC Comment hidden (obsolete)
Comment 4 Julien Nabet 2021-11-28 10:15:42 UTC
For the test, could you do this:
- Menu Tools/Options/Advanced
- Click on "Open Expert Configuration"
- Search "Opengl" (without quotes)
- Check if the value is at true, if it's not the case, double-click on the line to change the value
- Click "Ok" twice to exit window and save
- Restart LO and give a new try.

The goal is to be sure it's not related to OpenGL.
If it's the case, please make sure your graphic driver is up-to-date.
Comment 5 Julien Nabet 2021-11-28 10:18:40 UTC
Adolfo: why did you remove OpenGL part in https://wiki.documentfoundation.org/QA/FirstSteps ?
Indeed, it's still used, just try this command on your local repository:
git grep -in opengl

and consider this:
https://cgit.freedesktop.org/libreoffice/core/log/?id=aa0a2266f0fd9f53b50944aa183b7e78fe675300&qt=grep&q=opengl
Comment 6 Alistair Saywell 2021-11-28 23:11:52 UTC
Thanks for feedback.
I set DisableOpenGL to TRUE as suggested as test. After restart there was no change, the last 17 effects still not working

I then restarted Windows in Safe Mode in case of interference from other programs, and retested in Normal and LO safe mode, with and without Skia and DisableOpenGL to True. Still no change. LO 7.1.5.2 still has all transitions working.

After that I searched for "transition" in Windows and discovered that the missing effects are the ones listed in ...\LibreOffice\share\config\soffice.cfg\simpress\transitions-ogl.xml . Is that useful? Cheers, Al
Comment 7 Julien Nabet 2021-11-29 08:40:38 UTC
Ok so it seems related to OpenGL since "ogl" in transitions-ogl.xml means OpenGL

1) Check you've got last stable driver for your graphic card since it includes OpenGL part
2) In your user LO profile (see https://wiki.documentfoundation.org/UserProfile#Default_locations), locate /cache/opengl_device.log and attach it to the bugtracker
Comment 8 Alistair Saywell 2021-11-29 10:12:23 UTC
1. Intel UHD Graphics 620, but on Acer laptop so Intel latest driver said it was a locked version and go to Acer. Acer Care Centre say I have latest driver. I found a slightly more recent driver on their site for this laptop but no change, still only half transitions in 7.2.3.2. Even after restart of laptop

2. opengl_device.log
DriverVersion: 26.20.100.7927
DriverDate: 2-25-2020
DeviceID: PCI\VEN_8086&DEV_5917&SUBSYS_12731025&REV_07
AdapterVendorID: 0x8086
AdapterDeviceID: 0x5917
AdapterSubsysID: 0x12731025
DeviceKey: System\CurrentControlSet\Control\Video\{2DDBD0DC-3806-11EB-B372-90718103A663}\0000
DeviceString: Intel(R) UHD Graphics 620

Was previously as above but 
DriverVersion: 23.20.16.4973
DriverDate: 2-28-2018

I have second graphics card on laptop, Nvidia MX150, which I believe is marginally more powerful, can I force this to do presentations?
Comment 9 Julien Nabet 2021-11-29 20:13:53 UTC
About the possibility that LO use the other graphic card for openGL rendering, I can't tell.

Taking a look at https://opengrok.libreoffice.org/xref/core/vcl/source/opengl/opengl_denylist_windows.xml?r=65b47341#51, I see:
     50         <!-- tdf#131221 -->
     51         <entry os="10" vendor="intel">
     52             <device id="0x5917"/>
     53         </entry>
So OpenGL is disabled in your case according to your log.

For the test, you can try to remove this part in the file opengl_denylist_windows.xml:
it's in LO program directory (not the LO profile directory), then share/opengl and  of course DisableOpenGL must be set at false.

Caolán: noticing this patch 175a039fe70ab33fc1a68e21043b086b67d602e4
"gtk4: make opengl slide transitions work again", any idea about Windows part or whom to ping?
Comment 10 Alistair Saywell 2021-11-29 21:58:16 UTC
Thank you so much.

I deleted the blacklist line in opengl_denylist_windows.xml and saved. Now on LO 7.2.3.2 Impress all transitions work correctly.

As a check for tdf#131221, I opened Draw and Line thickness in Sidebar and in Line and Filling toolbar work as expected too for both presets and custom line width.

I will leave setting in opengl_denylist_windows.xml with line removed and see if any problems arise.

Cheers, Al
Comment 11 Caolán McNamara 2021-12-06 09:02:51 UTC
my patch above is just about figring out how to get opengl slide transitions working under gtk4

For the general case here, my understanding is that: There have been two uses of OpenGL in libreoffice. The classic use was just for OpenGL slide transitions, then it began to be used as an optimized mode for the UI itself, typically on windows. But since db89f53c31af997b9bf422b0e784afba8d62a42e (towards 7.2) that was removed (in favor of the skia backend basically) and from 7.2 onwards the OpenGL stuff is again only used directly for OpenGL slide transitions.

What I don't know is if there is any relationship between vcl/source/opengl/opengl_denylist_windows.xml and skia (@llunak?) or if the denylist truly now only in practice disables opengl slide transitions.

If the denylist is now just for our direct opengl slide transitions then it suggests that if the support was disabled for some case seen in the now removed "OpenGL for UI" case but that driver family is good enough to run the transitions it can be removed again from the denylist, and it's fairly easy to quickly test all the transitions to determine that.
Comment 12 Luboš Luňák 2021-12-06 09:32:49 UTC
(In reply to Caolán McNamara from comment #11)

Your understanding is correct. And Skia does not use any OpenGL-related stuff (except for some code that's been made generic and shared), and it has its own list of HW to ignore, so anything you do with the OpenGL HW list should affect only OpenGL transitions.
Comment 13 Luboš Luňák 2021-12-06 09:36:00 UTC
Looking at db89f53c31af997b9bf422b0e784afba8d62a42e, it mentions that there's also OpenGL-based canvas, so technically this applies also to it, but the commit also says that oglcanvas doesn't work and I don't expect it even would, so in reality this actually is really only about transitions.
Comment 14 Caolán McNamara 2021-12-06 09:51:40 UTC
I think we can disregard the oglcanvas, I was unable to get it to do anything anyhow the last time I even tried to enable it.
Comment 15 Julien Nabet 2021-12-06 19:12:50 UTC
If OpenGL is only used now for slide transitions (since we can forget canvas part), what about modifying https://opengrok.libreoffice.org/xref/core/vcl/source/opengl/opengl_denylist_windows.xml?r=65b47341#51, to remove this part?
     50         <!-- tdf#131221 -->
     51         <entry os="10" vendor="intel">
     52             <device id="0x5917"/>
     53         </entry>

I mean perhaps a lot of stuff has been blacklisted to avoid pb with OpenGL rendering?
Comment 16 Caolán McNamara 2021-12-06 19:48:07 UTC
yeah, that's what I think too. If something was put into this list because of some glitch that didn't affect slide transitions then it could be removed again without ill effect.
Comment 17 Julien Nabet 2021-12-06 20:18:52 UTC
I submitted a patch for master sources here:
https://gerrit.libreoffice.org/c/core/+/126461
Comment 18 Commit Notification 2021-12-06 21:31:41 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3a61cce54277fd12570103a191c50d9b37ef3dd3

tdf#145910: relax a bit denylist about OpenGL

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Julien Nabet 2021-12-06 21:37:13 UTC
Patch waiting for review here for 7.3 branch:
https://gerrit.libreoffice.org/c/core/+/126440
Comment 20 Commit Notification 2021-12-07 07:22:18 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/69b3fcaa943d288b5dda7bc5c2da822dbb9f9f3a

tdf#145910: relax a bit denylist about OpenGL

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 Commit Notification 2021-12-07 17:07:50 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dd4120ce811b8530505650d481514009a441234f

Related tdf#145910: relax a bit more denylist about OpenGL

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 22 Commit Notification 2021-12-09 13:25:43 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/9f70be2c8867f6715f97b6d37e03cfc69ae1caaf

Related tdf#145910: relax a bit more denylist about OpenGL

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 23 Commit Notification 2021-12-16 17:09:19 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b8f68233b8dc5a009396141fba6e47867e70f342

Related tdf#145910: relax even more denylist about OpenGL

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 24 Commit Notification 2021-12-17 09:42:44 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/93cb5e38d0e62c85cd262a12a7dd45bdada1c97e

Related tdf#145910: relax even more denylist about OpenGL

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 25 Robert Großkopf 2024-03-01 17:09:29 UTC
Get exactly the same buggy behavior here - with all LO-Versions since LO 7.3.6.2. Transition works with LO 7.2.5.1 without problems, fails with all newer versions.

Note: The buggy behavior appears with all versions, which support
Tools → Options → LibreOffice → View → Run Graphics Test
The Graphics Test gives the following result:

Graphics Backend used: qt5svp
Passed Tests : 1
Quirky Tests : 0
Failed Tests : 0
Skipped Tests : 104

Current LO version:
Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 6; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: en-US
Calc: threaded

Running KDE with Intel Graphic.

Should I reopen this one or file a new bug?
Comment 26 Robert Großkopf 2024-03-01 17:11:11 UTC
Created attachment 192890 [details]
Test document with slides. Try Slide transitions, starting with "Tiles"
Comment 27 Robert Großkopf 2024-03-01 17:13:48 UTC
When looking at the version it seems to be the same buggy behavior, but another reason, because this bug appeared with LO 7.2.2.2

Set this bug back to RESOLVED and open a new bug.