Bug 146191 - Navigate By Comment does not scroll comment into view
Summary: Navigate By Comment does not scroll comment into view
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Bayram Çiçek
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Navigator Writer-Comments
  Show dependency tree / graph
 
Reported: 2021-12-12 03:27 UTC by Jim Raykowski
Modified: 2022-03-15 14:47 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
test file with repro steps (31.95 KB, application/vnd.oasis.opendocument.text)
2021-12-12 03:27 UTC, Jim Raykowski 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2021-12-12 03:27:21 UTC 
Created attachment 176880 [details]
test file with repro steps

Steps to repro:

1) Open attached test file
2) Open Navigator sidebar version (ctrl+F5)
3) Select ‘Comment’ in the ‘Navigate By’ drop down (top line first tool box item in the Navigator tool box)
4) Click on ‘Next Comment’ navigation button (top line third tool box item in the Navigator tool box)
Cursor focus is moved to ‘Page 1 comment’ comment
5) Repeat step 4

Result: Cursor focus is moved to ‘Page 2 comment’ comment but if ‘Page 2 comment’ comment is not visible on the screen it is not scrolled into view.

Expected result: Comment is scrolled into view.

Additional information:
Change of behavior occurred with merged commit 4bb59cd1f45133994d3d13642367470f528094f4

Proposal:
Previous behavior set focus in comment window and scrolled into view. Instead, do the same as double-clicking on a comment in the Navigator content tree, set cursor position to the comment anchor position in the document and scroll into view.
Comment 1 Rainer Bielefeld Retired 2021-12-12 16:35:52 UTC 
REPRODUCIBLE with Server Installation of Version: 7.4.0.0.alpha0+ (x64)  Build ID ae36ee4f3aa544e53e2edad93d6d79160b27bc9d
CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-US  |  Calc: CL  |  Colibri Theme  |  Special devUserProfile

Was still ok with Server Installation of Version 7.3.0.0.alpha1+ (x64)  |   Build ID b8d17d754830ab57099dcdfa72a96bfad404ab1a  |  CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win  |  Locale: de-DE (de_DE); UI: de-DE  |  Calc: CL  |  Colibri Theme  |  Special devUserProfile

I think this one is related to (or even a DUP of?) "Bug 102184 - Navigator: Document doesn't move to the selected page, if cursor is in a comment". This one is related to "Cursor/Caret in Comment", but jumping from comment to comment here startef somewhere in or after 7.3, while Bug 102184 indeed is already reproducible with LibO 4.0
Comment 2 Dieter 2021-12-12 16:45:21 UTC 
(In reply to Rainer Bielefeld Retired from comment #1)
> REPRODUCIBLE with Server Installation of Version: 7.4.0.0.alpha0+ (x64) 
> Build ID ae36ee4f3aa544e53e2edad93d6d79160b27bc9d
> CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL:
> win
> Locale: de-DE (de_DE); UI: en-US  |  Calc: CL  |  Colibri Theme  |  Special
> devUserProfile

=> NEW
Comment 3 Bayram Çiçek 2022-03-15 14:28:55 UTC 
Not reproducible with Version: 7.4.0.0.alpha0+ / LibreOffice Community

Build ID: 288c78cb990bc427055dea7d97748de5cc4b8ab0
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

---

could you please confirm? thanks.
Comment 4 Rainer Bielefeld Retired 2022-03-15 14:47:13 UTC 
NOT (no longer?) reproducible with Server Installation of Version 7.4.0.0.alpha0+ (x64)  Build ID c856f9bec12d98ed49f01578ded79f16ae7be051
CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-US  |  Calc: CL  |  Auto Colibre Theme  |  Special devUserProfile