Bug 146203 - Shapes that have a name don't "blink"
Summary: Shapes that have a name don't "blink"
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
(earliest affected) release
Hardware: All All
: medium normal
Assignee: Not Assigned
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Shapes
  Show dependency treegraph
Reported: 2021-12-13 11:35 UTC by Colin
Modified: 2023-09-30 18:30 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Supporting .ods (8.50 KB, application/vnd.oasis.opendocument.spreadsheet)
2021-12-13 11:36 UTC, Colin

Note You need to log in before you can comment on or make changes to this bug.
Description Colin 2021-12-13 11:35:57 UTC
Attached sample - NoBlink.ods.
Both cells have been established with blinking text but the text will only blink if their names are deleted. Re-establishing their names expunges the blink

Steps to Reproduce:
With the attached file
Satisfy yourself that all parameters are functionally correct for the inserted shapes
Right click either object
select name
Delete the name
Observe the object now blinks as commanded
Undo or give the object a new name
Observe the object no longer blinks
If, it's not a bug then perhaps the help should be updated to inform users of the restrictions

Actual Results:
Non-blinking text within the shape

Expected Results:
Blinking text within the shape

Reproducible: Always

User Profile Reset: No

OpenGL enabled: Yes

Additional Info:
Version: (x64) / LibreOffice Community
Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: sv-SE (en_GB); UI: en-GB
Calc: threaded
Comment 1 Colin 2021-12-13 11:36:52 UTC
Created attachment 176895 [details]
Supporting .ods
Comment 2 Colin 2021-12-13 11:43:54 UTC
It also will not blink for a shape inserted into a writer document but I have no idea how to find the "name" field as it doesn't appear when right clicking the object
Comment 3 Colin 2021-12-13 18:32:05 UTC
I'm a little confused. Reading the report Mike appended leaves me unsure whether the blinking shouldn't really exist in LO or just not in Writer.
Comment 4 Colin 2021-12-14 05:39:51 UTC
Not sure if this is the right forum for making a Related suggestion.
If the blink functionality is to be retained in CALC, would it be worth considering incorporating it into the style and conditional formatting protocols?
I would certainly use it as a means of drawing attention to pre-defined circumstances affecting individual (or ranges of) cells and I imagine other users, if aware of the facility, would also find it appealing.
Comment 5 zcrhonek 2021-12-30 07:42:27 UTC
This seems to have begun at the below commit.
Adding Cc: to Armin Le Grand; Could you possibly take a look at this one?
 e9c172564ab3d3acc38dc64da9247dd4bfc647a0 is the first bad commit
commit e9c172564ab3d3acc38dc64da9247dd4bfc647a0
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Fri Sep 18 10:43:53 2015 +0800

    commit eceecd4a3806f64c2e8fb0a3bcdcc43e1384779f
    Author:     Armin Le Grand <alg@apache.org>
    AuthorDate: Fri May 4 14:16:22 2012 +0000
    Commit:     Caolán McNamara <caolanm@redhat.com>
    CommitDate: Wed Mar 13 11:22:20 2013 +0000
        Related: #i119125# corrected gradient rendering
        and added stuff to add Title and Description to primitives for later usage
Comment 6 Regina Henschel 2021-12-30 20:47:43 UTC
It does not only happen for "Blink" but for the other text-animations (Text_Marquee) too.
It was OK in OOo3.2, it fails in AOO 4.1.6.
Comment 7 Armin Le Grand 2022-01-04 14:36:13 UTC
This commit was developed for another code base, and not merged by me. For complex changes like this, side-effects are to be expected; sadly I dont't have the cycles to deal with all the fallout. Un-Ccing myself for the while.