Bug 146272 - Empty image frame on file open/cut/paste frame will restore visibility
Summary: Empty image frame on file open/cut/paste frame will restore visibility
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Attila Bakos (NISZ)
URL:
Whiteboard: target:7.4.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: DOCX-Images
  Show dependency treegraph
 
Reported: 2021-12-16 16:08 UTC by Telesto
Modified: 2022-05-31 09:58 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (179.08 KB, application/vnd.oasis.opendocument.text)
2021-12-16 16:09 UTC, Telesto
Details
Bibisect log (2.79 KB, text/plain)
2021-12-16 16:19 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-12-16 16:08:50 UTC
Description:
Empty image frame on file open/cut/paste frame will restore visibility 

Steps to Reproduce:
1. Open the attached file
2. Page 1 & 2 should have an image

Actual Results:
Empty 

Expected Results:
Image


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: deea3b7471c3dab0220eca6146c225a2d47681a2
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-12-16 16:09:07 UTC
Created attachment 176970 [details]
Example file
Comment 2 Telesto 2021-12-16 16:19:53 UTC
Created attachment 176971 [details]
Bibisect log

Bisected to
commit 504d78acb866495fd954fcd6db22ea68f174a5ab	[log]
author	Attila Bakos (NISZ) <bakos.attilakaroly@nisz.hu>	Fri Aug 13 14:11:24 2021 +0200
committer	László Németh <nemeth@numbertext.org>	Wed Sep 01 10:09:37 2021 +0200
tree 454c012ca959cf144c3380a7e7b58561fac3704e
parent 9c9ff9e89fd50223b28f327d3a7e416ab0ae831f [diff]

tdf#143574 sw: textboxes in group shapes - part 1

Introduce SwTextBoxNode class to support grouped
textboxes, fixing the crash when entering a group
shape, trying to add a textbox to one of the shapes.

Test of crash fix: right click on a group shape.
Select the menu item "Enter group". Select one of
the shapes, and right click on it, and choose "Add
Text Box".

Note: textboxes in Writer are linked in SwFrameFormat
class. Each textbox consists of a text frame and a shape.
This object pair makes it possible to have complex
content inside any kind of shape (pictures, tables etc.
Group shapes have only one SwFrameFormat, but can have
many shapes so that means they can only have one textbox.
From now, each shape could have a textbox in a group.
Please note this is only a preparation for that. Filter
implementation and handlers are under development.

https://git.libreoffice.org/core/+/504d78acb866495fd954fcd6db22ea68f174a5ab
Comment 3 Regina Henschel 2021-12-16 23:17:36 UTC
Isn't this the same as your report bug 146267?
Comment 4 Telesto 2021-12-17 08:53:22 UTC
(In reply to Regina Henschel from comment #3)
> Isn't this the same as your report bug 146267?

Nearly identical, but somehow different. The image at bug 146267 doesn't show at all in any version I tried. The file here was bibisectable. But didn't do an in depth investigation how/what/why
Comment 5 Gabor Kelemen (allotropia) 2022-02-27 20:04:09 UTC
Confirming in current master

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: c97a3592c78ce276a353f95ce68c70a8a39174a0
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Looks like these were image caption frames saved to docx, then resaved to odt, so now they are images inside a shape - which is NOT a grouped shape. 
Resizing the shape a bit makes them appear.

Adding cc to: Attila Bakos
Comment 6 Commit Notification 2022-05-30 11:21:34 UTC
Attila Bakos (NISZ) committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e1f6b136fd125c5d3648c51b202a698d418afc18

tdf#146272 sw: fix fly in fly hid by incomplete z-ordering

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 NISZ LibreOffice Team 2022-05-31 09:58:41 UTC
Verified in:
Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: dfd5081ff3973d5d0f216b06dda6360fa490cc9c
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded