Bug 146297 - NB TABBED: Styles Preview Widget does not implement scaling (visible in qt / kf5)
Summary: NB TABBED: Styles Preview Widget does not implement scaling (visible in qt / ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.4.1 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 161162 (view as bug list)
Depends on:
Blocks: HiDPI Notebookbar-Tabbed Styles-Preview
  Show dependency tree / graph
 
Reported: 2021-12-18 12:53 UTC by richrocksmyworld
Modified: 2024-06-19 21:35 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
screenshot of problem (38.21 KB, image/avif)
2022-01-02 11:05 UTC, richrocksmyworld 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description richrocksmyworld 2021-12-18 12:53:53 UTC 
Description:
On a 4K display with 200% scaling, the Styles Picker Widget in the Tabbed UI is too narrow vertically.

Steps to Reproduce:
1.Run LibreOffice on KDE with 200% scaling

Actual Results:
Styles Picker takes up 50% of the vertical space in the Ribbon

Expected Results:
Styles Picker takes up ~80% of the vertical space in the Ribbon


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.2.4.1 / LibreOffice Community
Build ID: 20(Build:1)
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-GB (en_GB.UTF-8); UI: en-US
7.2.4-1
Calc: threaded
Comment 1 Dieter 2022-01-02 08:29:00 UTC 
Thank you for reporting the bug. Cpuild you please attach a screenshot to make problem more visible? thank you.
=> NEEDINFO
Comment 2 richrocksmyworld 2022-01-02 11:05:43 UTC 
Created attachment 177242 [details]
screenshot of problem

screenshot attached
Comment 3 Michael Weghorn 2022-01-04 13:00:21 UTC 
I can reproduce on a non-HiDPI screen that it looks as in the attached screenshot when using the kf5 VCL plugin with

    SAL_USE_VCLPLUGIN=kf5 QT_SCALE_FACTOR=2 ./instdir/program/soffice --writer

Full vertical space is used for the styles preview widget when using the gtk3 VCL plugin instead:

    GDK_SCALE=2 SAL_USE_VCLPLUGIN=gtk3 ./instdir/program/soffice --writer

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 7a4250b74b53c8f5d650319dfe0509ce9dd80900
CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded
Comment 4 Jan-Marek Glogowski 2022-04-08 08:29:33 UTC 
The main problem is, that the widget doesn't scale at all. It has a fixed size, which is forced by StylesPreviewWindow_Impl::SetOptimalSize (and set in svx/uiconfig/ui/stylespreview.ui). Each preview item is also fixed to 100, 30 in StylesPreviewWindow_Base::UpdateStylesList. Implementing scaling is some larger work.

For Qt we decided to rely on LO properly scaling stuff, while Gtk basically lets LO believe everything is 100% and the scales the output accordingly. And since Gtk just supports fixed scale sizes, that works in practice quite good (you can see this with a bit blurry images, like the large image in the About dialog, comparing GDK_SCALE=2 with QT_SCALE_FACTOR=2). Or the toolbar icons.
Comment 5 Stéphane Guillou (stragu) 2024-05-21 01:51:05 UTC 
*** Bug 161162 has been marked as a duplicate of this bug. ***