Bug 146466 - Inconsistent choices of borders between toolbar and sidebar
Summary: Inconsistent choices of borders between toolbar and sidebar
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.3.0.1 rc
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyMedium, easyHack, skillCpp, skillDesign
Depends on:
Blocks: Cell-Border Toolbar-Border-Controls
  Show dependency treegraph
 
Reported: 2021-12-29 09:35 UTC by Stéphane Guillou (stragu)
Modified: 2024-01-27 06:22 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Overview of options between toolbar, sidebar and dialog (LO 7.3) (61.67 KB, application/vnd.oasis.opendocument.spreadsheet)
2021-12-29 09:41 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2021-12-29 09:35:33 UTC
Description:
In Calc, the preset border options available via buttons are different between the toolbar, the sidebar and the format dialog.

It is expected for the cell format dialog ("Border" tab) to have different options as:
- it also gives the option to pick the borders by clicking in the preview
- and it changes depending on if the user has one single cell selected or several

However, the toolbar and sidebar options should be more consistent. They currently show different selections of options, in different orders, with different labels.

The sidebar has 16 presets, including 5 that the toolbar does not offer:
- Thick box border
- Thick bottom border
- Double bottom border
- Top and thick bottom borders
- Top and double bottom borders

The toolbar has 15 presets, including 4 that the sidebar does not offer:
- Top and bottom borders, and all horizontal lines
- Outer border and horizontal lines
- Outer border and vertical lines
- Criss-cross border

In total, the sidebar and the toolbar have 20 different presets.
It would make sense to have the same presets in both, presented in the same order.


Steps to Reproduce:
1. Open Calc
2. Click on Borders button, see options
3. Open the Properties sidebar, scroll to bottom, click on "Specify the borders of the selected cells" button, see options

Actual Results:
Options are different

Expected Results:
Options are the same


Reproducible: Always


User Profile Reset: No



Additional Info:
The options available have been different between the two for a while, at least since LO 6.4, but for the purpose of this bug, I am marking it as starting since 7.3 because that's when diagonal options started showing in the toolbar.

Version: 7.3.0.1 / LibreOffice Community
Build ID: 840fe2f57ae5ad80d62bfa6e25550cb10ddabd1d
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Stéphane Guillou (stragu) 2021-12-29 09:41:30 UTC
Created attachment 177185 [details]
Overview of options between toolbar, sidebar and dialog (LO 7.3)

This spreadsheet gives an overview of the border presets available in:

- sidebar
- toolbar
- format dialog (multiple cells)
- format dialog (single cell)

For version:

Version: 7.3.0.1 / LibreOffice Community
Build ID: 840fe2f57ae5ad80d62bfa6e25550cb10ddabd1d
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 2 BogdanB 2021-12-29 18:01:14 UTC
Confirm this
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: c13db6e792cc347ffff4585f23866f195651f21f
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 3 BogdanB 2021-12-29 18:02:03 UTC
Your document is very well documented.
Comment 4 Stéphane Guillou (stragu) 2022-01-02 03:15:13 UTC
(In reply to BogdanB from comment #3)
> Your document is very well documented.

Thanks BogdanB. Glad you think it might be useful.

I'm wondering if the toolbar and the sidebar could point to the exact same UI element to create the dropdown list? That would make the codebase more consistent and maintainable. Or de they have to be fundamentally different kinds of UI elements?
Comment 5 QA Administrators 2024-01-03 03:11:57 UTC Comment hidden (obsolete)
Comment 6 Stéphane Guillou (stragu) 2024-01-03 20:59:45 UTC
Situation hasn't changed in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 960e37af28807ed1b376e26c4504ab755a81dfd5
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Marking as an enhacenemt rather than a bug though.

UX/Design team, what do you think about unifying the two widgets, for simplification and consistency?
Comment 7 Heiko Tietze 2024-01-17 10:22:08 UTC
Seems to have been like this forever. I would rework both and clean-up the choices. Thickness can be changed separately, applying left/right and criss-cross could be done in two steps, and the "styled" variants in the sidebar are rather something for the autoformat/table style feature. However, we should consider a sane arrangement of items too. So ultimately I favor the sidebar with some changes in the 4x4 scheme

None, outside, all, criss-cross,
left, right, top, bottom, 
diagonal down, diagonal up, top-bottom, left-right

Some code pointer:

sc/uiconfig/scalc/ui/floatingborderstyle.ui
sc/source/ui/sidebar/CellBorderStyleControl.cxx

svx/uiconfig/ui/floatingframeborder.ui
svx/source/tbxctrls/tbcontrl.cxx
https://gerrit.libreoffice.org/c/core/+/118951