Bug 146468 - Use same border preset tooltips between toolbar and sidebar
Summary: Use same border preset tooltips between toolbar and sidebar
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.2.4.1 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Kira Tubo
URL:
Whiteboard: reviewed:2022 target:25.2.0 target:24...
Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
Depends on:
Blocks: Sidebar-Properties Toolbar-Border-Controls
  Show dependency treegraph
 
Reported: 2021-12-29 10:48 UTC by Stéphane Guillou (stragu)
Modified: 2024-06-21 12:03 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Overview of options between toolbar, sidebar and dialog (LO 7.3) (61.85 KB, application/vnd.oasis.opendocument.spreadsheet)
2021-12-29 11:10 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2021-12-29 10:48:11 UTC
Description:
The cell border presets available in both the toolbar and the sidebar should use the same tooltip if they use the same function.



Steps to Reproduce:
1. open Calc
2. Open the border dropdown, see tooltips for presets
3. Open the Properties sidebar, click the cell borders button, see tooltips for presets

Actual Results:
Some presets have different tooltips depending on if they are in the toolbar or the sidebar

Expected Results:
All buttons that use the same function should use the same tooltip. Ideally, this would be only changed in one spot in the codebase (instead of maintaining two separate strings in two separate spots).

In particular:

- All the tooltips that finish with the word "only" in the toolbar should have that word removed. That's for two reasons: (1) it would be more accurate (given that, by default, it does not replace the existing borders, unless you press Shift when clicking), and (2) it would make most match the tooltips in the sidebar.
- The sidebar preset "Side borders" should be called "Outer borders", because (1) the word "side" is not used anywhere else, and (2) it would match the toolbar better.

There are a total of 20 different present across the toolbar and the sidebar. Unifying their tooltips would help making the codebase more maintainable, and would prevent having new discrepancies popping up.


Reproducible: Always


User Profile Reset: No



Additional Info:
Tooltips visible since:

Version: 7.2.4.1 / LibreOffice Community
Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

But examples used here are from:

Version: 7.3.0.1 / LibreOffice Community
Build ID: 840fe2f57ae5ad80d62bfa6e25550cb10ddabd1d
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Stéphane Guillou (stragu) 2021-12-29 11:10:26 UTC
Created attachment 177189 [details]
Overview of options between toolbar, sidebar and dialog (LO 7.3)

This spreadsheet shows the differences between toolbar, sidebar and cell format dialog.

The cells sharing a background colour are the ones that currently have different tooltips when they should probably have the same one.
Comment 2 Rafael Lima 2022-10-20 21:16:52 UTC
I support this request. As a user, I also find it weird to have so many differences between the toolbar and the sidebar.

Let's add the UX team in the loop.
Comment 3 Heiko Tietze 2022-11-03 10:56:57 UTC
The toolbar button uses include/svx/strings.hrc starting with #define RID_SVXSTR_TABLE_PRESET_NONE while the sidebar is defined in a ui file with tooltips for each item. I suggest to assign the RID_SVXSTR* tooltips per code like 

sc/source/ui/sidebar/CellBorderStyleControl.cxx

#include <svx/strings.hrc>
#include <svx/dialmgr.hxx>

void CellBorderStylePopup::Initialize()
{
    mxTBBorder1->connect_clicked ( LINK(this, CellBorderStylePopup, TB1SelectHdl) );
    mxTBBorder1->set_item_tooltip_text(0, SvxResId(RID_SVXSTR_TABLE_PRESET_NONE));
    mxTBBorder1->set_item_tooltip_text(1, SvxResId(
    ...

Perhaps it makes sense to clean up tooltip from the ui file to remove confusion.
Comment 4 Radhey Parekh 2023-02-03 17:32:54 UTC
I would like to look into this. One doubt, till what index, do we need to assign the RID_SVXSTR to the code line? Like you have started from (0,...) then '(1,....)', so till which index we need to assign this? Thanks :)
Comment 5 Heiko Tietze 2023-02-06 12:01:04 UTC
(In reply to Radhey Parekh from comment #4)
> ...till what index, do we need to assign the RID_SVXSTR to the code line?

Why not use all 20?
Comment 6 Khushi Gautam 2023-10-17 08:37:32 UTC
I guess the presets are more than 20 , because when we select 2 adjecent cells, the presets are different which are not included in the excel sheet
Comment 7 Commit Notification 2024-06-20 07:12:19 UTC
Kira Tubo committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/14231e45ce5c8f2615fc5a448479960dfe1ed22b

tdf#146468: Match border tooltips in toolbar/sidebar

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Kira Tubo 2024-06-20 23:22:54 UTC
Note: Tooltip values now controlled in svx/strings.hrc instead of sc/uiconfig/scalc/ui/floatingborderstyle.ui, accessible names will be added in context of tdf#161648"
Comment 9 Kira Tubo 2024-06-21 01:06:13 UTC
Addressing some minor comments in the last patch before closing this ticket. See: 
https://gerrit.libreoffice.org/c/core/+/169308

Regardless, the bug should have been fully resolved in the last patch.
Comment 10 Commit Notification 2024-06-21 05:41:32 UTC
Kira Tubo committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e5c55b2cfc47dcc5b711811fedc75ee982e3d46e

tdf#146468: Fix typo and move comments

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Stéphane Guillou (stragu) 2024-06-21 05:56:11 UTC
Thank you Kira! I tested the patch in my own build, looks good.
Comment 12 Commit Notification 2024-06-21 11:30:09 UTC
Kira Tubo committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/4ab9fea75f552dcaa52e1c25d2bc841e965e0b4e

tdf#146468: Match border tooltips in toolbar/sidebar

It will be available in 24.8.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2024-06-21 12:03:18 UTC
Kira Tubo committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/9b2d11fcdcdc5f75caf3e7645f795011afd4aef2

tdf#146468: Fix typo and move comments

It will be available in 24.8.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.