Description: The cell border presets available in both the toolbar and the sidebar should use the same tooltip if they use the same function. Steps to Reproduce: 1. open Calc 2. Open the border dropdown, see tooltips for presets 3. Open the Properties sidebar, click the cell borders button, see tooltips for presets Actual Results: Some presets have different tooltips depending on if they are in the toolbar or the sidebar Expected Results: All buttons that use the same function should use the same tooltip. Ideally, this would be only changed in one spot in the codebase (instead of maintaining two separate strings in two separate spots). In particular: - All the tooltips that finish with the word "only" in the toolbar should have that word removed. That's for two reasons: (1) it would be more accurate (given that, by default, it does not replace the existing borders, unless you press Shift when clicking), and (2) it would make most match the tooltips in the sidebar. - The sidebar preset "Side borders" should be called "Outer borders", because (1) the word "side" is not used anywhere else, and (2) it would match the toolbar better. There are a total of 20 different present across the toolbar and the sidebar. Unifying their tooltips would help making the codebase more maintainable, and would prevent having new discrepancies popping up. Reproducible: Always User Profile Reset: No Additional Info: Tooltips visible since: Version: 7.2.4.1 / LibreOffice Community Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded But examples used here are from: Version: 7.3.0.1 / LibreOffice Community Build ID: 840fe2f57ae5ad80d62bfa6e25550cb10ddabd1d CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded
Created attachment 177189 [details] Overview of options between toolbar, sidebar and dialog (LO 7.3) This spreadsheet shows the differences between toolbar, sidebar and cell format dialog. The cells sharing a background colour are the ones that currently have different tooltips when they should probably have the same one.
I support this request. As a user, I also find it weird to have so many differences between the toolbar and the sidebar. Let's add the UX team in the loop.
The toolbar button uses include/svx/strings.hrc starting with #define RID_SVXSTR_TABLE_PRESET_NONE while the sidebar is defined in a ui file with tooltips for each item. I suggest to assign the RID_SVXSTR* tooltips per code like sc/source/ui/sidebar/CellBorderStyleControl.cxx #include <svx/strings.hrc> #include <svx/dialmgr.hxx> void CellBorderStylePopup::Initialize() { mxTBBorder1->connect_clicked ( LINK(this, CellBorderStylePopup, TB1SelectHdl) ); mxTBBorder1->set_item_tooltip_text(0, SvxResId(RID_SVXSTR_TABLE_PRESET_NONE)); mxTBBorder1->set_item_tooltip_text(1, SvxResId( ... Perhaps it makes sense to clean up tooltip from the ui file to remove confusion.
I would like to look into this. One doubt, till what index, do we need to assign the RID_SVXSTR to the code line? Like you have started from (0,...) then '(1,....)', so till which index we need to assign this? Thanks :)
(In reply to Radhey Parekh from comment #4) > ...till what index, do we need to assign the RID_SVXSTR to the code line? Why not use all 20?
I guess the presets are more than 20 , because when we select 2 adjecent cells, the presets are different which are not included in the excel sheet