Bug 146579 - (Enhancement) Show the current View Layout option in the status bar, without relying on color.
Summary: (Enhancement) Show the current View Layout option in the status bar, without ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: accessibility
Depends on: 153344
Blocks: Statusbar a11y, Accessibility
  Show dependency treegraph
 
Reported: 2022-01-05 04:30 UTC by MarjaE
Modified: 2024-01-31 14:39 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description MarjaE 2022-01-05 04:30:15 UTC
(Forked from bug 146380.)

The LibreOffice Writer status bar includes icons for Single-Page View, Multiple-Page View, and Book View, just left of the Zoom slider.

I can't see any difference if I select either Single-Page, or Multiple-Page. The page stays the same, and the icon stays the same. If the icon for the current View Layout were bolder than the others, it would help users figure out if they are in Single-Page, or Multiple-Page, or Auto, for other features which only work with certain View Layouts.

There was a visible difference in 3.3.0.4, up through 6.4.7.2.

No visible difference as of 7.0.0.0.alpha1.
Comment 1 Mike Kaganski 2022-01-05 07:15:21 UTC
Note that the color of the current layout is different - it is not the same. It's shown on your attachment 174749 [details]; but maybe adding bold to color highlight is not a bad idea accessibility-wise.
Comment 2 MarjaE 2022-01-05 14:34:38 UTC
Ah.

I get awful eye-strain from conventional monitors, so I turn brightness down to 0%, contrast down to 0%, and
Comment 3 MarjaE 2022-01-05 14:40:17 UTC
Okay, I was saying that I get awful eye-strain and migraines from conventional monitors, so I turn brightness down to 0%, contrast down to 0%, red 15%, green 15%, and blue 5%. As a result it's hard to distinguish blue from black.

A fair number of users use blue-blocking monitor settings, software, or glasses.

Another solution is to switch to an e-ink monitor, most of which are grayscale.

So using bold as well as color would be clear for more users.
Comment 4 Dieter 2022-12-21 10:40:17 UTC
(In reply to MarjaE from comment #3)
> So using bold as well as color would be clear for more users.

I agree that we should take into account accessibility here
cc: Design-Team for further input and decision
Comment 5 Heiko Tietze 2022-12-21 14:02:11 UTC
Bold is not a good solution. How about using a (red) rectangle around the active mode icon?
Comment 6 Heiko Tietze 2023-01-19 08:23:02 UTC
We discussed the topic in the design meeting. 

Changing the icons is welcome but in addition (or until then) we should try to add a rectangle around the active element.

A similar issue exists for the view mode (single/multiple page/book mode) that fully relies on color (blue in this case).
Comment 7 Heiko Tietze 2023-01-19 08:24:44 UTC
Mixing things up. This one is the layout mode, the other is bug 152947 regarding the save state.
Comment 8 Jim Raykowski 2023-01-20 00:51:28 UTC
This can be done programmatically without need to modify the existing images used to indicate active view mode (emptypage_a_10x14.png, twopages_a_10x24.png, and doublepage_a_10x22.png)

Code pointers:

Images for SwViewLayoutControl are drawn in:
void SwViewLayoutControl::Paint sw/source/uibase/utlui/viewlayoutctrl.cxx

A rectangle of chosen color can be drawn around the active image using OutputDevice::DrawRect. Optionally, OutputDevice::DrawBorder can be used but the line color can not be changed, it is set in the function as light grey and grey to, I suppose, provide a border effect.
Comment 9 Heiko Tietze 2023-01-25 16:42:02 UTC
The active icon has a rectangle now in addition to the color.
Comment 10 Commit Notification 2023-01-25 16:42:20 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3fffe54bb19e387b6b56ac897a7e9cf8ebcc18d6

Resolves tdf#146579 - Accessibility for statusbar icons

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Dieter 2023-02-12 10:23:35 UTC
(In reply to Heiko Tietze from comment #6)
> Changing the icons is welcome but in addition (or until then) we should try
> to add a rectangle around the active element.

Rectangle verified with

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a834bbad8295cba0ca88a91a524aad48640271ec
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (de_DE); UI: en-GB
Calc: CL threaded

But what about idea to change icons. Should we open a new bug report or is it still existing?

But since, you've changed status to RESOLVED, Heiko, I've changed it to VERIFIED
Comment 12 Heiko Tietze 2023-02-13 08:21:35 UTC
(In reply to Dieter from comment #11)
> But what about idea to change icons. Should we open a new bug report or is
> it still existing?

In fact I changed the icons, the rectangles are not drawn extra but added to the active variant ;-)
Comment 13 Heiko Tietze 2023-02-23 11:23:26 UTC
Going to revert this solution. The rectangle makes the icon even more tiny as today. Will find a better solution after resolving bug 153344.
Comment 14 Commit Notification 2023-02-23 15:42:04 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d9865bd5276542ebeea8df79cc1724ae7fbbc2e8

Revert "Resolves tdf#146579 - Accessibility for statusbar icons"

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Heiko Tietze 2024-01-31 14:39:56 UTC
Icons must not rely on color only. Rizal, do you have spare cycles?