Bug 152947 - Icon in the status bar indicating document saved status not suitable for color blinds
Summary: Icon in the status bar indicating document saved status not suitable for colo...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.2.2 release
Hardware: x86-64 (AMD64) All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: accessibility
Depends on: 153344
Blocks: Statusbar a11y, Accessibility
  Show dependency treegraph
 
Reported: 2023-01-09 13:31 UTC by Harald Freunbichler
Modified: 2024-01-31 10:41 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Screencast tooltip with qt5 VCL plugin (108.36 KB, video/x-matroska)
2023-01-10 13:52 UTC, Michael Weghorn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Freunbichler 2023-01-09 13:31:05 UTC
Description:
In the left bottom corner the diskette icon has RED as signal for NOT SAVED.
Color Blinds (not me) are not able to see the difference!

Please use a icon changing to crossed out. (example)

Actual Results:
no action required

Expected Results:
no action required


Reproducible: Always


User Profile Reset: No

Additional Info:
no action required for this.
Comment 1 Buovjaga 2023-01-09 13:36:39 UTC
Good point -> NEW
Comment 2 V Stuart Foote 2023-01-09 22:22:22 UTC
Invalid. Users can select from any number of project Icon themes--most of which have distinct shape modifications and not color alone when the document has changes to be saved.

Sifr for example (our default when system Assistive Technologies are signaled active) shows a circle when the document has been saved.

The project is mindful of the need, but the choice is the Icon theme designer.
Comment 3 V Stuart Foote 2023-01-09 22:25:17 UTC
(In reply to V Stuart Foote from comment #2)
s/has been saved/has not been saved/
Comment 4 Buovjaga 2023-01-10 06:57:25 UTC
Nothing to do about the icon theme, back to NEW
Comment 5 Heiko Tietze 2023-01-10 07:23:22 UTC
We show the non-saved status also with a (colored) dot at the toolbar Save icon.

The statusbar panel should have a tooltip according SvxModifyControl::StateChangedAtStatusBarControl() with RID_SVXSTR_DOC_MODIFIED_YES/_NO but it wont show up, at least for me on Linux/qt5.

The images are svx/res/doc_modified_yes_14.png, svx/res/doc_modified_no_14.png, and svx/res/doc_modified_feedback.png - and therefore themed. So it does depend on the icon theme, and if we recommend Sifr for color blind users, the distinction between yes and no must not be the colorization.

See also: "Asterisk in the filename" (WF in bug 123559) and "Tiny icon in statusbar" (WFM in bug 84198; actually WF, this ticket could be a DUP).
Comment 6 Michael Weghorn 2023-01-10 13:52:14 UTC
Created attachment 184559 [details]
Screencast tooltip with qt5 VCL plugin
Comment 7 Michael Weghorn 2023-01-10 13:55:51 UTC
(In reply to Heiko Tietze from comment #5)
> The statusbar panel should have a tooltip according
> SvxModifyControl::StateChangedAtStatusBarControl() with
> RID_SVXSTR_DOC_MODIFIED_YES/_NO but it wont show up, at least for me on
> Linux/qt5.

That works for me with kf5 or qt5, s. screencast attachment 184559 [details].

> The images are svx/res/doc_modified_yes_14.png,
> svx/res/doc_modified_no_14.png, and svx/res/doc_modified_feedback.png - and
> therefore themed. So it does depend on the icon theme, and if we recommend
> Sifr for color blind users, the distinction between yes and no must not be
> the colorization.

+1 (haven't looked into that, but sounds reasonable to me)



Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d2318503d559c3797965da777627e4ee45143043
CPU threads: 12; OS: Linux 6.0; UI render: default; VCL: qt5 (qfont+xcb)
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded
Comment 8 Heiko Tietze 2023-01-10 14:16:13 UTC Comment hidden (off-topic)
Comment 9 V Stuart Foote 2023-01-10 14:26:27 UTC Comment hidden (off-topic)
Comment 10 Heiko Tietze 2023-01-10 14:31:42 UTC Comment hidden (off-topic)
Comment 11 Heiko Tietze 2023-01-25 16:42:45 UTC
The active icon has a rectangle now in addition to the color.
Comment 12 Commit Notification 2023-01-25 16:43:23 UTC Comment hidden (obsolete)
Comment 13 Heiko Tietze 2023-02-23 11:23:51 UTC
Going to revert this solution. The rectangle makes the icon even more tiny as today. Will find a better solution after resolving bug 153344.
Comment 14 Commit Notification 2023-02-23 15:42:01 UTC Comment hidden (obsolete)
Comment 15 Heiko Tietze 2024-01-31 10:41:17 UTC
Icons must not rely on color only, Sifr is a good example how to solve the problem. Rizal, do you have spare cycles?