Created attachment 177342 [details] Sample document with section footnote/endnote Create a new section in document. Add either a footnote or an endnote. Go into section options, and under the footnotes/endnotes tab, enable/disable the footnotes/endnotes option "Collect at end of text". In version 7.1 or greater, changing the option has no effect once the section has already been created. The options must be set when the section is initially created. It works properly in version 7.O.6 and below.
regression from commit 2e32f4ed5af16a68c97a50806a42ffa2d10f1d7a get rid of long deprecated SwModify::BroadcastModify i have something to fix that, although its not pretty...
In version 7.3 beta 1, I think the new regression mentioned in bug 145773 will block a fix of this previous regression.
Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cb188ce336e434c2b7002b3d8a41a681e73ae51a tdf#146605 sw: try to fix SwSectionFormat notifications It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
hope its fixed on master, maybe Bjoern wants to add a unit test...
Looks good! Thanks Michael!
There is still a bit of a problem. Now when creating a new document, endnotes are only collected at the end of the section if the option for collecting footnotes at the end of the section is also enabled.
(In reply to David from comment #6) > There is still a bit of a problem. Now when creating a new document, > endnotes are only collected at the end of the section if the option for > collecting footnotes at the end of the section is also enabled. i have investigated and it looks like it's another regression, now tracked separately in: https://bugs.documentfoundation.org/show_bug.cgi?id=146704
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/b14f5424dde966fa3764a7e5c813dc727390354c tdf#146605 sw: try to fix SwSectionFormat notifications It will be available in 7.3.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 145773 has been marked as a duplicate of this bug. ***
Verified in Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 2d11710df6d81c03007d136667a443e09cc70eed CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: es-ES (es_ES.UTF-8); UI: en-US Calc: threaded @Michael Stahl, thanks for fixing this issue!!
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/58d4b1aae1a599322b27ec388b62d8a6ed158ef9 tdf#146605 sw: try to fix SwSectionFormat notifications It will be available in 7.2.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/44cf7a7f3cd585b442b404ff9e791dc7df513a51 tdf#146605: sw: Add UItest It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I guess we can remove needUITest as it's there.