Bug 145773 - Section endnotes not collected at end of section
Summary: Section endnotes not collected at end of section
Status: RESOLVED DUPLICATE of bug 146605
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.3.0.0 beta1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bibisectRequest, regression
Depends on:
Blocks: 146605
  Show dependency treegraph
 
Reported: 2021-11-19 09:31 UTC by David
Modified: 2022-01-12 11:16 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
sample document (8.71 KB, application/octet-stream)
2021-11-19 09:31 UTC, David
Details
document created after the commit (9.14 KB, application/octet-stream)
2021-12-11 07:49 UTC, David
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David 2021-11-19 09:31:41 UTC
Created attachment 176357 [details]
sample document

Create a new section in a document.
Edit the options for the section to enable collecting the endnotes at the end of the section rather than at the end of the document.
Enter some text and an endnote into the section.
The endnote appears at the end of the document instead of at the end of the section as specified.
This is a regression beginning with version 7.3 alpha.
This regression prevents creating a properly formatted document and severely breaks existing documents. See attachment.
Comment 1 David 2021-11-22 16:28:06 UTC
A likely candidate for this regression seems to be commit https://git.libreoffice.org/core/+/4c31b4ef2083087a822c3ae648fd09acc67d2f88%5E%21.
Comment 2 David 2021-11-29 17:58:57 UTC
Verified fixed with https://gerrit.libreoffice.org/c/core/+/125442
Comment 3 David 2021-12-11 07:49:23 UTC
Created attachment 176859 [details]
document created after the commit

It looks like I was too quick in marking this bug is fixed. This section endnotes are collected properly at the end of the section if the document was created before the commit, as in the first attachment. But if a document is created now after the commit, the endnotes are collected at the end of the document even though the option is enabled to collect at the end of section.  See attachment.
Comment 4 David 2021-12-17 07:20:04 UTC
@szucs.attila3, xiscofauli
Section endnotes collected at end of section in newly created files are still not fixed by https://gerrit.libreoffice.org/c/core/+/125442.
Comment 5 David 2021-12-28 07:56:48 UTC
The option to collect endnotes at the end of a section in new documents works again after making the following changes in the code for the recent commit:

In sw/source/uibase/uno/SwXDocumentSettings.cxx, under the "case HANDLE_FOOTNOTE_IN_COLUMN_TO_PAGEEND:" statement on line 1025, change

  bool bTmp;

to:
  return; 
  bool bTmp;


In sw/source/uibase/app/docshini.cxx, line 292, change

   m_xDoc->getIDocumentSettingAccess().set( DocumentSettingId::FOOTNOTE_IN_COLUMN_TO_PAGEEND, true);

to:

 m_xDoc->getIDocumentSettingAccess().set( DocumentSettingId::FOOTNOTE_IN_COLUMN_TO_PAGEEND, false);
Comment 6 David 2022-01-11 11:46:09 UTC
This now looks to be fixed after commit https://git.libreoffice.org/core/commit/cb188ce336e434c2b7002b3d8a41a681e73ae51a.
Comment 7 Xisco Faulí 2022-01-12 11:16:56 UTC
(In reply to David from comment #6)
> This now looks to be fixed after commit
> https://git.libreoffice.org/core/commit/
> cb188ce336e434c2b7002b3d8a41a681e73ae51a.

Closing as duplicated of bug 146605 then. Thanks for the analysis

*** This bug has been marked as a duplicate of bug 146605 ***