Bug 146758 - Option to Reload a document is missing with Notebookbar enabled
Summary: Option to Reload a document is missing with Notebookbar enabled
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: Notebookbar
  Show dependency treegraph
 
Reported: 2022-01-14 10:16 UTC by SwanS
Modified: 2023-10-17 21:07 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SwanS 2022-01-14 10:16:46 UTC
According to the 7.2 version documentation, it is supposed to exist the menu "File > Reload", but it is inaccesible in any way when Notebookbar is enabled.
Comment 1 V Stuart Foote 2022-01-15 00:18:57 UTC
So, pop-open the standard menu and use from ther--done with the first button on the Tabbed NB

MUFFIN NB is not required to hold all widgets of the Standard Menu & TB UI, lower frequency commands are simply not available.

But, the .uno:Reload command might be a valid addition to the NB, probably disabled by default and available to Customize visible.
Comment 2 Heiko Tietze 2022-01-17 10:46:54 UTC
What's your use case for Reload, SwanS? I would keep the UI clean and add it to the context menu (expecting it to be aligned to the standard File menu).
Comment 3 SwanS 2022-01-18 22:35:41 UTC
Totally agree, Heiko. I expected to find it in the context menu (i.e. the drop-down menu on the far left of the NB labeled "File"), as the "Reload" action is not very common and I always found that menu aligned to standard menu bar section. 

Stuart, just out of curiosity: isn't the first button on the Tabbed NB to reveal the classic menu bar a safeguard and is bound to go some day when NB is enabled?

Thanks!
Comment 4 V Stuart Foote 2022-01-18 23:07:55 UTC
(In reply to SwanS from comment #3)
> Stuart, just out of curiosity: isn't the first button on the Tabbed NB to
> reveal the classic menu bar a safeguard and is bound to go some day when NB
> is enabled?

Nope, the MUFFIN NB is limited in that it is an assemblage of UNO controls. The default Standard UI (Menus, Toolbars & Dialogs) are fully instrumented. Ability to reach/show the default Main Menu will always remain--and is why we insisted all of the NB assemblages provide efficient means to redisplay.

Work on bug 90195 provided the .uno:MenuBar toggle control, and we have bug 107343 open to address the lack of consistent shortcut--preferably to overload F10 to toggle the main menu visible.
Comment 5 SwanS 2022-01-19 09:59:19 UTC
Thanks for the explanation, Stuart.

So in brief, the "Reload" action should be added to the context menu of the "File" tab, shouldn't it?

BTW, Heiko, my use case is to drop the latest changes at once (I could use Ctrl+Z, Ctrl+Z, ... but it is not as fast :) ) in a doc and get back to the saved version.

BTW2, I use a uncommon setup on my workstation: Ubuntu 18.04 + Canonical Unity. This causes the classical menu bar to never be shown. That's why using the first button on the Tabbed NB to reveal the classic menu bar is not an option for me and I miss having the "Reload" action integrated in the NB somehow.
Comment 6 Heiko Tietze 2022-01-19 10:12:04 UTC
(In reply to SwanS from comment #5)
> BTW, Heiko, my use case is to drop the latest changes at once (I could use
> Ctrl+Z, Ctrl+Z, ... but it is not as fast :) ) in a doc and get back to the
> saved version.

Ctrl+W + Ctrl+O... a bit slower but Reload sounds like feature-creep.
Comment 7 Heiko Tietze 2022-01-20 07:36:50 UTC
So let's add it to the menu. Code pointer is:

The command .uno:Reload needs to be added to sw/uiconfig/swriter/ui/notebookbar.ui (and other variants) under <object class="GtkMenu" id="Menu File">. 

To compare with the common standard menu see sw/uiconfig/swriter/menubar/menubar.xml and sc/.., sd/.., and */*/<variants>/menubar...
Comment 8 Justin L 2023-06-16 14:10:45 UTC
repro 24.2.
Comment 9 Justin L 2023-06-29 16:26:35 UTC
Note that bug 126006 indicates that doing this in Calc is a bad idea...
Comment 10 Justin L 2023-10-17 21:07:06 UTC
With the options to close a document/open recent document being readily available, I do not see reasonable value in providing a reload button.