Bug 146781 - Function wizard - allow search description of functions.
Summary: Function wizard - allow search description of functions.
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Andreas Heinisch
URL:
Whiteboard: target:7.5.0 inReleaseNotes:7.5 targe...
Keywords:
Depends on:
Blocks: Function-Wizard
  Show dependency treegraph
 
Reported: 2022-01-15 13:34 UTC by raal
Modified: 2023-11-21 16:20 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
example - prinrscreens (161.14 KB, application/vnd.oasis.opendocument.text)
2022-01-15 13:35 UTC, raal
Details
Search always in the description (47.26 KB, image/png)
2022-07-05 19:05 UTC, Andreas Heinisch
Details
Older LO versions don't have any order (26.37 KB, image/png)
2022-07-05 19:16 UTC, Andreas Heinisch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description raal 2022-01-15 13:34:29 UTC
Description:
When searching in function wizard, Calc search only in function names. Search also in description, it should help find correct function. Searching in description can be optional.

Steps to Reproduce:
1.open calc
2.function wizard
3.enter string to search field

Actual Results:
Search only names of functions

Expected Results:
Search description too


Reproducible: Always


User Profile Reset: No



Additional Info:
.
Comment 1 raal 2022-01-15 13:35:05 UTC
Created attachment 177562 [details]
example - prinrscreens
Comment 2 Roman Kuznetsov 2022-01-15 16:04:51 UTC
Agree
Comment 3 Andreas Heinisch 2022-07-05 19:05:15 UTC
Created attachment 181129 [details]
Search always in the description
Comment 4 Andreas Heinisch 2022-07-05 19:07:40 UTC
As shown in the attachment, should we always search in the description, or just if we don't find any match in the function name?
Comment 5 Andreas Heinisch 2022-07-05 19:11:03 UTC
To better understand: if I search for SUM, the windows shows me DEVSQ, DSUM, etc. and from a user perspective I would expect SUM first.
Comment 6 Andreas Heinisch 2022-07-05 19:16:21 UTC
Created attachment 181130 [details]
Older LO versions don't have any order

So I think searching in the descritpion to should be fine. Raal what did you mean with can be optional? Should we insert a flag or something?
Comment 7 raal 2022-07-05 19:31:34 UTC
(In reply to Andreas Heinisch from comment #6)
> Created attachment 181130 [details]
> Older LO versions don't have any order
> 
> So I think searching in the descritpion to should be fine. Raal what did you
> mean with can be optional? Should we insert a flag or something?

I thought add new checkbox "search in description too", but maybe it's too complicated in UI. If you add function names which contains search string at top and then functions, where search string is in the description after, IMHO it's clear. Thank you for taking the bug.
Comment 8 Roman Kuznetsov 2022-07-05 20:11:49 UTC
(In reply to Andreas Heinisch from comment #5)
> To better understand: if I search for SUM, the windows shows me DEVSQ, DSUM,
> etc. and from a user perspective I would expect SUM first.

I think we should search in the function names list and then add search results from description
Comment 9 Andreas Heinisch 2022-07-07 14:30:20 UTC
The list of the functions is sorted, so either we disable the sorting for the searching proccess or we just include every function which contains the search string and keep the list sorted, for instance, search for "sum" leads to:

DEVQSUM
DSUM
IMSUM
...
SUM
...

Not sure which solution is correct.

We could even make the list unsorted for the search process, then create two sorted lists (one with the keyword in the titel one within the description) and then add both to the non sorted list.

If the user changes something (changes a category, deletes the search input) the list could be sorted again.

Imho, the easiest to understand change is to search in both title and description and show them in the sorted list.
Comment 10 Commit Notification 2022-07-09 12:40:45 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bb4314aa21baec08268e0f02b816a8cf05096ceb

tdf#146781 - Function wizard: search desired function also in the description

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 BogdanB 2022-08-03 14:00:43 UTC
Great feature!
Verified with
Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 5c68399e6bea3aa18477487400f8bb143d6ed84e
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 12 Stéphane Guillou (stragu) 2022-12-12 18:52:00 UTC
Added to the release notes:

https://wiki.documentfoundation.org/index.php?title=ReleaseNotes%2F7.5&type=revision&diff=594069&oldid=593791

Thanks Andreas!
Comment 13 Commit Notification 2022-12-20 15:26:28 UTC
Stéphane Guillou committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/826b1f36bd96328e198452e0f8d5c87b2f3fb203

tdf#146781 sc: update extended tip for function description search

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Commit Notification 2022-12-20 16:52:40 UTC
Stéphane Guillou committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/403909906c14483b310a6245a1b897f1e008d06b

tdf#146781 sc: update extended tip for function description search

It will be available in 7.5.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.