Bug 147016 - The document loses focus after closing the autofilter popup
Summary: The document loses focus after closing the autofilter popup
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.4.0 target:7.3.1
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2022-01-27 10:11 UTC by Xisco Faulí
Modified: 2022-01-30 21:01 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2022-01-27 10:11:25 UTC
Steps to reproduce:
1. Open attachment 177574 [details] from bug 146795 -> Focus in on B2
2. Click on the autofilter in Column B
3. Deselect 44 and press ok
4. Type something

-> Since the focus is on B2, the typing should be in B2 but it's not.
Reproduced with GEN and GTK3

Reproduced in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 2f4f4cbeb8e50081d607b86b0475b93971c40ab8
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: x11
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2022-01-27 10:12:46 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=29145df0977baa866e7da94d1d385b772ae1e6ce

author	Caolán McNamara <caolanm@redhat.com>	2021-11-29 12:55:38 +0000
committer	Caolán McNamara <caolanm@redhat.com>	2021-12-02 23:27:27 +0100
commit 29145df0977baa866e7da94d1d385b772ae1e6ce (patch)
tree ae4c89322b0879a1b8451d23158dcf8b65195d15
parent 5346168fa919ad98224c4d2079e738a4d0b8d164 (diff)
Resolves: tdf#144811 use the hover-style menu for color submenus

Bisected with: bibisect-linux64-7.4

Adding Cc: to Caolán McNamara
Comment 2 Caolán McNamara 2022-01-28 09:09:46 UTC
I think this only happens if the submenu pops up (even if only for a moment) and then focus is restored on popdown of the main menu to whatever had focus before the main menu, which is the submenu in that popup for a moment case.
Comment 3 Commit Notification 2022-01-28 20:36:10 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ac41defa75365451db264379c514993679618208

Resolves: tdf#147016 ensure focus returns to document after popup closes

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2022-01-28 20:36:37 UTC
done in trunk, backport to 7-3 in gerrit
Comment 5 Commit Notification 2022-01-30 21:01:46 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/10600d1988665bd950166891fa9df314bb847ac3

Resolves: tdf#147016 ensure focus returns to document after popup closes

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.