Bug 147102 - CRASH Deleting bookmark from Navigator
Summary: CRASH Deleting bookmark from Navigator
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Navigator
  Show dependency treegraph
 
Reported: 2022-01-31 22:50 UTC by Gabor Kelemen (allotropia)
Modified: 2022-09-02 20:52 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file with bookmark (11.08 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2022-01-31 22:50 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2022-01-31 22:50:24 UTC
Created attachment 177954 [details]
Example file with bookmark

Attached simple document has a _GoBack default bookmark made by Word.
When I right click this in the Navigator and select Delete, Writer crashes.

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: eb69767d7c1bb8e6e780fd9503f08c9d7f5ecb45
CPU threads: 13; OS: Windows 10.0 Build 19042; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

Not yet in 7.3.

Bibisected in windows-7.4 to:

https://git.libreoffice.org/core/+/7270ed7b81c12c8ba2e57b1a0d2ae084f8489d61

author	Jim Raykowski <raykowj@gmail.com>	Sun Dec 05 21:31:59 2021 -0900
committer	Jim Raykowski <raykowj@gmail.com>	Sat Jan 22 09:30:36 2022 +0100

SwNavigator: revamp SwContentType::HasContentChanged function

Adding CC to: Jim Raykowski
Comment 1 Jim Raykowski 2022-02-01 02:48:15 UTC
Hi Gabor,

This is odd, when I open the test file I don't see a bookmark listed in the Navigator.
Comment 2 Jim Raykowski 2022-02-01 06:30:25 UTC
Found out why I wasn't seeing the bookmark:
https://gerrit.libreoffice.org/c/core/+/129269

I don't get crash using STR with patch installed.
Comment 3 raal 2022-02-08 22:57:53 UTC
No crash with Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 24e6217c0abdaed703a077e77881ad6e8b4f6f0e
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo
Comment 4 Xisco Faulí 2022-02-09 08:45:28 UTC
No crash in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: fd2f6282cb898f4a356ea8acf3dd1129f09fc1e1
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

@Gabor, could you please try again with a recent daily build ?
Comment 5 QA Administrators 2022-08-09 03:39:13 UTC Comment hidden (obsolete)
Comment 6 Gabor Kelemen (allotropia) 2022-09-02 20:52:05 UTC
After a bit of bibisection, the crash stopped to be triggerable in commit

https://cgit.freedesktop.org/libreoffice/core/commit/?id=3771a81060f9e1f60ada37c3b7fa0a51b3042952
author	Jim Raykowski <raykowj@gmail.com>	2022-01-22 13:43:08 -0900
committer	Jim Raykowski <raykowj@gmail.com>	2022-01-27 21:36:02 +0100

SwNavigator: move content type init into SwContentType constructor

partly because the bookmark was not displayed in the Navigator anymore.
After that in commit 

https://cgit.freedesktop.org/libreoffice/core/commit/?id=b4d5b4bdf45f76832b4c2714244cb8bf302eb092
author	Jim Raykowski <raykowj@gmail.com>	2022-01-31 21:12:38 -0900
committer	Jim Raykowski <raykowj@gmail.com>	2022-02-02 06:29:13 +0100

SwNavigator: set bookmark member count

The bookmark became visible in the Navigator, but deleting it no longer causes a crash, also works in current nightly:

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 3e544b6938ee509a4f6df4c2e2996d71ce072506
CPU threads: 14; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: threaded

Thanks Jim for being thorough :)