Bug 147245 - Fileopen DOCX: Text in shape is not fully seen inside b/c empty paragraph size of 4 is larger
Summary: Fileopen DOCX: Text in shape is not fully seen inside b/c empty paragraph siz...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, filter:docx, regression
Depends on:
Blocks: DOCX
  Show dependency treegraph
 
Reported: 2022-02-07 11:03 UTC by Timur
Modified: 2024-09-06 03:17 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample compared in MSO, LO 6.0, 7.3, 7.4+ in Windows (135.91 KB, image/webp)
2022-02-07 11:25 UTC, Timur
Details
Sample DOCX from MSO with compatibility (87.82 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2022-02-07 11:26 UTC, Timur
Details
How it looks in Word and Writer 7.4 (299.20 KB, image/jpeg)
2022-02-07 13:59 UTC, Attila Bakos (NISZ)
Details
Sample compared in MSO, LO 6.0, 7.3, 7.4+ in Windows (137.09 KB, image/webp)
2022-02-07 14:19 UTC, Timur
Details
The problem enlarged (100.82 KB, image/jpeg)
2022-02-07 15:02 UTC, Attila Bakos (NISZ)
Details
Sample compared in MSO, LO 6.0, 7.3, 7.4+, 7.5+ in Windows (136.53 KB, image/webp)
2022-09-06 09:37 UTC, Timur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Timur 2022-02-07 11:03:36 UTC
Open attached DOCX (same for old and new format). 
See problem with text in diagram, regardless if grouped. 
DOCX is MSO extracted from bug 76513 larger DOCX.
Comment 1 Timur 2022-02-07 11:25:45 UTC
Created attachment 178111 [details]
Sample compared in MSO, LO 6.0, 7.3, 7.4+ in Windows

Ungrouped seems like always wrong, but text was seen in 5.2 and not all from 5.3. 

Grouped seemed better, looked good with 6.0, then also seen in 6.1 but somewhat changed to worse, then diagram wrong and text seen in 6.2, then diagram corrected up to 7.3, then text not seen in 7.4+.
Comment 2 Timur 2022-02-07 11:26:43 UTC
Created attachment 178112 [details]
Sample DOCX from MSO with compatibility
Comment 3 Timur 2022-02-07 11:37:47 UTC Comment hidden (obsolete)
Comment 4 Timur 2022-02-07 11:38:47 UTC Comment hidden (obsolete)
Comment 5 Attila Bakos (NISZ) 2022-02-07 13:59:09 UTC
Created attachment 178119 [details]
How it looks in Word and Writer 7.4

Hi! What is the exact problem?
All textboxes has the same parameters like in Word, so i do know what do you mean exactly?  If you attach an image marked with the problem and a good version, it could help. Thanks :) (During you attach that i try to fix the other regression )
Comment 6 Timur 2022-02-07 14:19:45 UTC
Created attachment 178120 [details]
Sample compared in MSO, LO 6.0, 7.3, 7.4+ in Windows

Here is a screenshot with marked text progblem.
Comment 7 Timur 2022-02-07 14:22:55 UTC Comment hidden (obsolete)
Comment 8 Timur 2022-02-07 14:29:45 UTC
As seen in attachment 178120 [details], in latest master I don't see text in Grouped (and it's not well in Ungrouped). 
In order to see text, I have to mark Grouped and press Arrow Down/Up.

But, I retested with a new profile and text is shown as in attachment 178119 [details].
So this bug boils down just to "text is there but not see all to the bottom".
Comment 9 Attila Bakos (NISZ) 2022-02-07 15:02:24 UTC
Created attachment 178124 [details]
The problem enlarged

Well i see. However that problem what you mention not really a textbox specific bug, rather it is a text handling problem. Later i will check it again.
Comment 10 Timur 2022-02-08 08:20:38 UTC
Text in Grouped became worse (touched the line), bibisect Lin-6.1:
commit f7f94bad44fb21c50b1aa01221cf61c739e19101
Date:   Wed Jan 16 15:54:35 2019 +0100
    source ba7435e5914a713730265c3378ce616de543667f
    prev 3376b0e94f0638c927a37c32322bf67d42ebb00f
author	Miklos Vajna <vmiklos@collabora.com>	2018-12-17
tdf#121804 DOCX import: handle sub/superscript inside group shapes

Text in Grouped became bad(out of the line), bibisect Lin-7.4:
commit a0018b7bdfa3b444f90e432d5a8e79ae55feb96d
Date:   Mon Jan 3 14:43:29 2022 +0100
    source 2951cbdf3a6e2b62461665546b47e1d253fcb834
    prev cce57fd94e9335c5dd5f3725a5fe54f5d3929e8d
author	Attila Bakos (NISZ) <bakos.attilakaroly@nisz.hu>	2021-11-10
tdf#143574 OOXML export/import of textboxes in group shapes
Comment 11 Attila Bakos (NISZ) 2022-02-14 08:46:13 UTC
(In reply to Timur from comment #10)
> Text in Grouped became worse (touched the line), bibisect Lin-6.1:
> commit f7f94bad44fb21c50b1aa01221cf61c739e19101
> Date:   Wed Jan 16 15:54:35 2019 +0100
>     source ba7435e5914a713730265c3378ce616de543667f
>     prev 3376b0e94f0638c927a37c32322bf67d42ebb00f
> author	Miklos Vajna <vmiklos@collabora.com>	2018-12-17
> tdf#121804 DOCX import: handle sub/superscript inside group shapes
> 
> Text in Grouped became bad(out of the line), bibisect Lin-7.4:
> commit a0018b7bdfa3b444f90e432d5a8e79ae55feb96d
> Date:   Mon Jan 3 14:43:29 2022 +0100
>     source 2951cbdf3a6e2b62461665546b47e1d253fcb834
>     prev cce57fd94e9335c5dd5f3725a5fe54f5d3929e8d
> author	Attila Bakos (NISZ) <bakos.attilakaroly@nisz.hu>	2021-11-10
> tdf#143574 OOXML export/import of textboxes in group shapes

According to https://bugs.documentfoundation.org/attachment.cgi?id=178120 the text missing from the grouped shape what is now fixed by https://gerrit.libreoffice.org/c/core/+/129627/9 i think, and it opens as the ungrouped one (see https://bugs.documentfoundation.org/attachment.cgi?id=178124 ) So there is two problem: the first one has a fix in gerrit the second is independent from me as your attachment shows in 6.0) Which one is this bug-report about?
Comment 12 Timur 2022-02-14 13:57:43 UTC
This one is about original grouped shape, Ungrouped can be another bug. Thanks.
Comment 13 Timur 2022-04-25 15:02:35 UTC
Another file that regressed from 2951cbdf3a6e2b62461665546b47e1d253fcb834 in 7.4+ on fileopen is DOCX saved from FODT attachment 118188 [details].
Comment 14 Timur 2022-09-06 09:37:11 UTC
Created attachment 182247 [details]
Sample compared in MSO, LO 6.0, 7.3, 7.4+, 7.5+ in Windows

As explained, grouped now in 7.5+ opens as ungrouped, both missing a bottom. 
So this bug remains open.
Comment 15 Attila Bakos (NISZ) 2022-09-06 09:56:18 UTC
(In reply to Timur from comment #14)
> Created attachment 182247 [details]
> Sample compared in MSO, LO 6.0, 7.3, 7.4+, 7.5+ in Windows
> 
> As explained, grouped now in 7.5+ opens as ungrouped, both missing a bottom. 
> So this bug remains open.

Why opens that un-grouped? It is have to be grouped and having textbox for each shape having the text inside, what has the same behaviour like the simple shape with textbox had before, am i right?
Comment 16 Timur 2022-09-06 13:06:26 UTC Comment hidden (obsolete)
Comment 17 Attila Bakos (NISZ) 2022-09-06 13:41:51 UTC
(In reply to Timur from comment #16)
> (In reply to Attila Bakos (NISZ) from comment #15)
> > Why opens that un-grouped? It is have to be grouped and having textbox for
> > each shape having the text inside, what has the same behaviour like the
> > simple shape with textbox had before, am i right?
> 
> Sorry, I don' understand.

Sorry. I just wanted to ask you about the grouping of the shape. Because before when my patch has been merged, the group shape was still there and it was one group with as many text-frames, as many shapes supposed to have text inside. As I see in your picture the number of the frames sill the same, and i wonder if the shape has been grouped. If not, that means there is another regression as well. The current state have to be the same (or better if someone did a fix) as the single shape and frame has (The upper one is the single object if i remember well, the bottom is the group, and they looks the same) If i not clear just write back, thanks.
Comment 18 QA Administrators 2024-09-06 03:17:56 UTC
Dear Timur,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug