Bug 147515 - Column/Row headers have low contrast in dark mode when filtered
Summary: Column/Row headers have low contrast in dark mode when filtered
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Heiko Tietze
URL:
Whiteboard: target:7.4.0
Keywords:
: 150413 (view as bug list)
Depends on:
Blocks: Linux-Dark-Mode
  Show dependency treegraph
 
Reported: 2022-02-18 12:07 UTC by Rafael Lima
Modified: 2022-08-15 08:49 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot showing the problem (260.35 KB, image/png)
2022-02-18 12:07 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2022-02-18 12:07:07 UTC
Created attachment 178376 [details]
Screenshot showing the problem

In the attached screenshot I show the result of AutoFilter being applied when the system is set to dark mode. Hidden cells are numbered in dark blue (CALCHIDDENROWCOL), which does not have good contrast with the black background and makes it hard to read the actual number.

If a hidden cell is selected, the background of the row number gets the system's highlight color whereas the cells get a lighter highlight color.

I don't know the best way to solve it, but I'd like to suggest 2 possibilities for coloring the row number in dark mode:
1) The background could have another color (f.i. a dark grey color) instead of black and the font could retain the white color.
2) The background and font retain their black / white colors, hence without differentiation from hidden / visible cells.

System info:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 60f786bde4524bbba462eccc6578715f39020076
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL
Comment 1 Pedro 2022-03-22 14:29:20 UTC
Can confirm this. The contrast is horrible.
Comment 2 Heiko Tietze 2022-03-23 07:12:31 UTC
The newly introduced indicator for hidden row/col (bug 128258) don't affect the row/col headers. And in fact this color is a result of (any) filter, also true for versions <7.4.
Comment 3 Pedro 2022-03-23 08:30:30 UTC
Also couldn't find any way to change this color in Options -> Application colors
Comment 4 Commit Notification 2022-03-24 13:53:32 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/652772ee4e76ff5d3aa0c599ec0bbe11d7bbee94

Resolves tdf#147515 - Make header text readable on dark themes

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Heiko Tietze 2022-08-15 08:49:31 UTC
*** Bug 150413 has been marked as a duplicate of this bug. ***