Bug 147814 - Tabs dialog shows Left, Right but they're really Start, End
Summary: Tabs dialog shows Left, Right but they're really Start, End
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyMedium, easyHack, skillCpp, topicUI
Depends on:
Blocks: RTL-CTL RTL-UI
  Show dependency treegraph
 
Reported: 2022-03-06 19:55 UTC by Eyal Rozenberg
Modified: 2022-03-07 10:23 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2022-03-06 19:55:04 UTC
The tabs dialog (e.g. Paragraph | Tabs on the menu) shows four kinds of tabs: Left, Right, Centered and Decimal.

The "Left" and "Right" tabs are mis-named. When inserting a Left tab stop, in an LTR paragraph the tabbed text will be left-aligned; but in an RTL paragraph the text will be right-aligned. 

In other words: These are 'Start' and 'End' tab stops. LO doesn't currently support Left or Right tab stops. Please change the UI labels and the documentation accordingly.

Note that this situation is the converse of what we have for paragraph alignment! There, Left and Right are what's actually implemented, but Start and End - aren't. I find that amusing somehow :-)

Anyway, this is all further motivation for why bug 131192 needs to be worked on. We should have Left, Right, Start, End, Centered and Decimal as tab stop types.
Comment 1 Heiko Tietze 2022-03-07 09:52:23 UTC
Agreed. For the people ignorant of LTR/RTL duality I suggest to use "Start (Left)" and "End (Right)" resp. "Start (Right)" when the paragraph has RTL locale. Might be a bit tricky and just start/end are an improvement too.

Code pointer: 

cui/uiconfig/ui/paratabspage.ui

cui/source/tabpages/tabstpge.cxx
and maybe class SvxFrameDirection
Comment 2 Eyal Rozenberg 2022-03-07 10:23:51 UTC
(In reply to Heiko Tietze from comment #1)
> Agreed. For the people ignorant of LTR/RTL duality I suggest to use "Start
> (Left)" and "End (Right)" resp. "Start (Right)" when the paragraph has RTL
> locale. Might be a bit tricky

Probably not that tricky, since they'll always see the same thing - such people dont typically work with RTL documents at all.

Maybe you could even make the choice of labels depend on whether "complex scripts" are enabled or not; I think some RTL features depend on that.

> and just start/end are an improvement too.

Let's start with that then.

> 
> Code pointer: 
> 
> cui/uiconfig/ui/paratabspage.ui
> 
> cui/source/tabpages/tabstpge.cxx
> and maybe class SvxFrameDirection

I'll try and have a look this weekend maybe.