Bug 147998 - App overlay icons are blurry
Summary: App overlay icons are blurry
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
(earliest affected)
Hardware: All All
: medium normal
Assignee: Mike Kaganski
Whiteboard: target:7.4.0
Depends on:
Blocks: Start-Center
  Show dependency treegraph
Reported: 2022-03-15 09:18 UTC by Rizal Muttaqin
Modified: 2022-03-18 13:28 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:
Regression By:

Blurry Icons in Start Center (49.64 KB, image/png)
2022-03-15 09:18 UTC, Rizal Muttaqin
Before the fix (158.34 KB, image/png)
2022-03-16 06:10 UTC, Mike Kaganski
After the fix (164.10 KB, image/png)
2022-03-16 06:11 UTC, Mike Kaganski

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2022-03-15 09:18:56 UTC
Created attachment 178892 [details]
Blurry Icons in Start Center

In the Start Center, tdf#125756 give additional icon as a overlay. Assuming this icon is an app icon for now but they are somehow blurry. This is occurs in my work laptop (1920x1080) as well as my personal laptop (1360x768)

I can help to add additional icon size if needed, but something should be adjusted in coding part

Version: / LibreOffice Community
Build ID: d156995180b565f34b52859aa1d6953995a76b9a
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: id-ID (id_ID.UTF-8); UI: id-ID
Calc: threaded
Comment 1 Mike Kaganski 2022-03-15 15:33:27 UTC
Comment 2 Commit Notification 2022-03-15 20:19:56 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":


tdf#134065, tdf#147998: fix thumbnail generation code

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:

Affected users are encouraged to test the fix and report feedback.
Comment 3 Mike Kaganski 2022-03-16 06:10:51 UTC
Created attachment 178904 [details]
Before the fix
Comment 4 Mike Kaganski 2022-03-16 06:11:07 UTC
Created attachment 178905 [details]
After the fix
Comment 5 Mike Kaganski 2022-03-16 06:41:53 UTC
(In reply to Rizal Muttaqin from comment #0)

The solution re-used the existing icons. I have no idea if it needs to be changed, but it is easy to do if needed.

In attachment 178905 [details]:

1. Default thumbnails ("Исследование антигена", "Songs of Fellowship 1 to 6", "formula1") that are shown for elements when there's no cached thumbnails from content available (and when generation of cached thumbnails is disabled using RecentDocsThumbnail in expert config) are 128 pixels images listed in BitmapForExtension [1].
2. Default thumbnails for password-protected documents ("withPwd") are 128 pixels images listed in EncryptedBitmapForExtension [2].
3. Overlays (shown in the bottom right in all other items) are 48 pixels images listed in OverlayBitmapForExtension [3].

These three lists are used exclusively for this task, and may be modified as needed (e.g., create new images and replace SFX_FILE_OVERLAY_* with MY_NEW_IMAGE_FOR_*, or use different existing images, like those 32-pixel ones used for "Create:" module list to the left, which I don't know image names for). Dimensions may be chosen freely, and don't need to be 128 or 48; as long as they fit to item rectangle (192 or 256 pixel depending on screen size), they will not be scaled.

[1] https://opengrok.libreoffice.org/xref/core/sfx2/source/control/recentdocsviewitem.cxx?r=1dbed50a#87
[2] https://opengrok.libreoffice.org/xref/core/sfx2/source/control/recentdocsviewitem.cxx?r=1dbed50a#95
[3] https://opengrok.libreoffice.org/xref/core/sfx2/source/control/recentdocsviewitem.cxx?r=1dbed50a#111
Comment 6 steve 2022-03-18 13:28:50 UTC
Thanks Mike for resolving another blurryness in LO 🎉

verified in Version: / LibreOffice Community
Build ID: 94016b435404f19d84ed636c5b3fd1ab0c02e020
CPU threads: 8; OS: Mac OS X 12.3; UI render: default; VCL: osx
Locale: de-DE (en_DE.UTF-8); UI: en-US
Calc: threaded