Bug 148035 - FILEOPEN: DOCX: incorrect formatting of sdt plain text fields
Summary: FILEOPEN: DOCX: incorrect formatting of sdt plain text fields
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: DOCX-Content_Control
  Show dependency treegraph
 
Reported: 2022-03-16 13:30 UTC by Xisco Faulí
Modified: 2022-06-02 11:38 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:
Regression By: Vasily Melenchuk


Attachments
Comparison MSO 2010 and LibreOffice 7.4 master (82.60 KB, image/png)
2022-03-16 13:30 UTC, Xisco Faulí
Details
Controls properties in Word 2013 (91.40 KB, image/png)
2022-04-01 07:30 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2022-03-16 13:30:16 UTC
Created attachment 178916 [details]
Comparison MSO 2010 and LibreOffice 7.4 master

Steps to reproduce:
1. Open attachment 55096 [details] from bug 41557
2. Check the first page

-> The font size of the title is too small. See comparison

Reproduced in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: cfd82e7a2cc2b45b738eb0efa0827196d2de61a4
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2022-03-16 13:31:44 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=b5c616d10bff3213840d4893d13b4493de71fa56

author	Vasily Melenchuk <vasily.melenchuk@cib.de>	2021-11-24 14:50:12 +0300
committer	Thorsten Behrens <thorsten.behrens@allotropia.de>	2021-12-20 00:16:12 +0100
commit b5c616d10bff3213840d4893d13b4493de71fa56 (patch)
tree d96535ffae96f4b0c35aee51a3257770826c8063
parent 302ef0c63b8e95d040cf5b19865e8540e78f9d15 (diff)
tdf#104823: support for sdt plain text fields

Bisected with: bibisect-linux64-7.4

Adding Cc: to Vasily Melenchuk
Comment 2 Xisco Faulí 2022-03-16 14:33:28 UTC
Also reproduced with attachment 52975 [details] from bug 42458
Comment 3 Gabor Kelemen (allotropia) 2022-04-01 07:30:17 UTC
Created attachment 179246 [details]
Controls properties in Word 2013

This has a direct formatting on the character size of 40 pt which is lost and the para style default 11pt is used only.

Same to the next "750 OR" control.

The Author control below has a direct formatting of Bold which is also lost.

Curiously the date control below also has a Bold direct format which is NOT lost on import.
Comment 4 Thorsten Behrens (allotropia) 2022-06-02 10:50:14 UTC
With the ongoing work in that area from Miklos, we're currently standing by (if that doesn't help, will look again)
Comment 5 Miklos Vajna 2022-06-02 11:38:53 UTC
At least attachment 55096 [details] has a document.xml where the SDT is around a table, i.e. a block SDT. My ongoing work is (at the moment) limited to run SDTs, so I'm afraid my effort won't change the problem around this bug.

In other words, SwContentControl is there for run SDTs (and inside that: rich text, checkbox, dropdown, picture & date). Other run SDTs and non-run SDTs behave as they did in the past, at least for now.