Bug 148125 - "Insert > Gallery" in Tabbed user interface doesn't do anything
Summary: "Insert > Gallery" in Tabbed user interface doesn't do anything
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.3.1.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Sidebar Gallery Notebookbar-Tabbed
  Show dependency tree / graph
 
Reported: 2022-03-22 02:06 UTC by Stéphane Guillou (stragu)
Modified: 2022-11-07 16:05 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2022-03-22 02:06:19 UTC 
Description:
This regression means the Tabbed user interface's "Gallery" button does not do anything when pressed.

Steps to Reproduce:
1. Open a LibreOffice component (Writer, Calc...)
2. Use the Tabbed interface in "View > User Interface..."
3. In the Insert tab, click on "Gallery"

Actual Results:
Nothing happens

Expected Results:
The sidebar should get expanded if it is collapsed, and its Gallery tab should be focused.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Reproduced in:

Version: 7.3.1.3 / LibreOffice Community
Build ID: a69ca51ded25f3eefd52d7bf9a5fad8c90b87951
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

But not reproducible in:

Version: 7.2.6.2 / LibreOffice Community
Build ID: b0ec3a565991f7569a5a7f5d24fed7f52653d754
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Stéphane Guillou (stragu) 2022-03-22 02:09:57 UTC 
Note that, although they sound similar, this issue is distinct to Bug 148124, They appeared at different times and relate to different controls.
Comment 2 Aron Budea 2022-03-29 05:00:53 UTC 
Confirmed using LO 7.4.0.0.alpha0+ (2f2df626117380427d2e5e8417316f52823f1e6f) / Ubuntu.

Bibisected to the following commit using repo bibisect-linux-64-7.3. Adding CC: to Szymon Kłos.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4fc8c453da759b34e7460da6338a5c2d80e3d3c4
author		Szymon Kłos <szymon.klos@collabora.com>	2021-11-10 11:33:03 +0100
committer	Andras Timar <andras.timar@collabora.com>	2021-11-11 16:00:35 +0100

Handle UNO command aliases in ToolBoxes
Comment 3 Julien Nabet 2022-04-08 19:52:47 UTC 
On pc Debian x86-64 with master sources updated today, I could reproduce this.

I confirm what Aron found, reverting the patch makes this bug disappear.

I maded other tests and the pb is in framework part.

Before the quoted commit aCommandURL ".uno:Gallery"
after, it's ".uno:Sidebar.GalleryDeck"

git grep -n 'uno:Sidebar.GalleryDeck'
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu:5469:          <value>.uno:Sidebar.GalleryDeck</value>

git grep -n '.uno:Gallery'
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu:5458:      <node oor:name=".uno:Gallery" oor:op="replace">
sc/uiconfig/scalc/menubar/menubar.xml:183:      <menu:menuitem menu:id=".uno:Gallery"/>
sc/uiconfig/scalc/menubar/menubar.xml:213:          <menu:menuitem menu:id=".uno:Gallery"/>
...
Comment 4 Szymon Kłos 2022-07-08 12:59:52 UTC 
This is already fixed:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=d7cbd78a810b263fd2f53ca58ec678008a387e22

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: a3e9fede7e998979db7941a527496eb98c822e98
CPU threads: 16; OS: Linux 5.3; UI render: default; VCL: x11
Locale: pl-PL (pl_PL.utf8); UI: en-US
Calc: threaded
Comment 5 Stéphane Guillou (stragu) 2022-11-07 16:05:35 UTC 
Verified as fixed in:

Version: 7.4.2.3 / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded