Bug 148263 - Calc: "Sheet" -> "Rows" is not very clear that it's about deleting
Summary: Calc: "Sheet" -> "Rows" is not very clear that it's about deleting
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:7.4.0 target:24.2.0 target:7.6...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-30 10:29 UTC by Michael Weghorn
Modified: 2023-06-16 07:20 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot with gtk3 VCL plugin (67.59 KB, image/png)
2022-03-30 10:29 UTC, Michael Weghorn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Weghorn 2022-03-30 10:29:29 UTC
Created attachment 179205 [details]
Screenshot with gtk3 VCL plugin

The previous "Sheet" -> "Delete Rows"/"Delete Columns" entries in the Calc menu now only show "Rows" and "Columns", which IMHO makes it a bit unclear what this is actually about, that this will delete the selected rows/columns, in particular e.g. with the gtk3 VCL plugin, where no icon is shown in addition that would clarify that.

Steps to reproduce:

1) Start Calc
2) open "Sheet" menu item
3) look at the items

Result:

It's not 100% clear what the "Rows" and "Columns" items refer to.

Expected result:

Items having a text that makes that clearer.

Screenshot of the current behaviour attached.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: ab9422621bc0aa26a00aa92f8bdebe91a6519792
CPU threads: 12; OS: Linux 5.16; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded
Comment 1 Michael Weghorn 2022-03-30 10:31:23 UTC
This changed in the following 2 commits.

commit 763e5d233d18a26f64dd8c4db67ce62ee289832e
Author: Julien Nabet <serval2412@yahoo.fr>
Date:   Wed Mar 16 20:35:33 2022 +0100

    Related tdf#114286: put duplicates commands in GenericCommands (DeleteColumns)
    
    Change-Id: Iecfa09729ea1b237fb6994be4b3ceaaa3ad126df
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131680
    Tested-by: Jenkins
    Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>


commit 52a695d2ceb4231a9fcc419959e29023ecef037b
Author: Julien Nabet <serval2412@yahoo.fr>
Date:   Thu Mar 17 11:01:47 2022 +0100

    Related tdf#114286: put duplicates commands in GenericCommands (DeleteRows)
    
    Change-Id: I100297d10b2643c5ddad7753a7c1032526ce06cd
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131699
    Tested-by: Jenkins
    Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

Adding CC: To Julien Nabet
Comment 2 Julien Nabet 2022-03-30 17:18:09 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this.

Good catch!
Comment 3 Julien Nabet 2022-03-30 17:27:00 UTC
Here's a patch I submitted for review:
https://gerrit.libreoffice.org/c/core/+/132325
Comment 4 Commit Notification 2022-03-30 19:48:56 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6fee8f6da0c25ab3c5c7a84da45f1f79a19d4951

tdf#148263: Calc: "Sheet" -> "Rows" is not very clear that it's about deleting

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Michael Weghorn 2022-03-31 07:08:16 UTC
Thanks!

Fix verified with

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 4ee8a4662bb85a130467805194124ab649acd7e7
CPU threads: 12; OS: Linux 5.16; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded
Comment 6 Commit Notification 2023-06-15 18:53:29 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/11ac3528f46443cb1f790d0e9ac710cea27fc3a0

Related tdf#148263: on Writer, no need to repeat "Delete" for columns

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-06-16 07:20:43 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/85c32bc8cfb22cc81ef5bf3ca3396b46376de59f

Related tdf#148263: on Writer, no need to repeat "Delete" for columns

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.