Bug 148312 - Navigator should not show ToC entries as hyperlinks, at all
Summary: Navigator should not show ToC entries as hyperlinks, at all
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0
Keywords:
Depends on:
Blocks: Navigator
  Show dependency treegraph
 
Reported: 2022-04-01 19:17 UTC by Eyal Rozenberg
Modified: 2022-06-07 20:42 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2022-04-01 19:17:00 UTC
The Navigator already has a hierarchy of items with outline-levels. It therefore does not make sense for it to also duplicate the hierarchy within a table of contents, as a sequence of Hyperlink-category items. Yet - they are.

Bug 52113 suggest these hyperlinks should be shown separately - I disagree, that's not going far enough. I claim it is a bug they are displayed at all.
Comment 1 Heiko Tietze 2022-04-11 10:14:32 UTC
Agree, and bug 52113 reads to me quite similar with just a different proposed solution namely to separate. But I also see no benefit in having the outline twice and concur with hiding it. 

Jim, is this one for you?
Comment 2 Jim Raykowski 2022-04-14 02:19:29 UTC
Here is a hack that makes hyperlinks in table of contents not show in the Navigator Hyperlinks entries. This could be made an option in the context menu if needed.

https://gerrit.libreoffice.org/c/core/+/132988
Comment 3 Commit Notification 2022-04-14 16:45:31 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/78b723c3a1fad1c095de1e5c746aef513556a53b

tdf#52113, tdf#148312 Don't include table of contents hyperlinks

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2022-05-04 04:06:48 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ca34204a39716ec9aa621e60ea50fb3c058c55f6

related tdf#148312 Don't search for hyperlinks in ToxContent to track

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Buovjaga 2022-06-07 16:38:27 UTC
Should bug 52113 be closed as well?
Comment 6 Eyal Rozenberg 2022-06-07 20:42:00 UTC
(In reply to Buovjaga from comment #5)
> Should bug 52113 be closed as well?

I think so, but tell people there they may reopen it if they believe something remains to be done.