Bug 148381 - closing the print preview page - with the X, too :)
Summary: closing the print preview page - with the X, too :)
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-05 07:46 UTC by peter josvai
Modified: 2022-04-06 12:43 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description peter josvai 2022-04-05 07:46:01 UTC
hi,

consistency in a navigation system is of great importance, 
BUT sometimes some some silly deviations can be really refreshing...

like being able to close the gdmn print preview windows with a regular close button:)

sure, there is a "close this view" button in the middle of the view, 
but on this planet, when we want to close a window, we'll go for the window closing X in the upper right corner


it would be great if we could have this comfort :)
and regardless of what I've just said about silly deviations, it would also make sense.. :)
Comment 1 V Stuart Foote 2022-04-05 13:11:56 UTC
You want a third 'X' icon on the right edge of the the UI--the app frame, the menu bar, and the print preview toolbar? You'll be annoyed when you get the wrong one.

Otherwise, the 'Print Preview' is just a Toolbar, not an app frame, and its 'Close Preview' is simply a button widget linked to UNO .uno:ClosePreview command; the <ESC> key will also close the preview mode.

The UNO command can be customized to appear on a menu, or another toolbar--but we do not support CSD, and no other Toolbar has a close action. 

The 'X' on the App Frame is os/DE provided. 

The 'X' on the main menu bar comes from UNO .uno:CloseDoc command.

It would be possible to overload that button, when the 'Print Preview' mode is active, and assign the .uno:ClosePreview action.

That would work OK for the standard Menu & Toolbar w/Sidebar mode--but would present issues with other MUFFIN modes which don't provide the 'X'

Just don't see much need for the work it would require--<ESC> or the current button suffice.  IMHO => WF
Comment 2 Heiko Tietze 2022-04-06 07:28:30 UTC
(In reply to V Stuart Foote from comment #1)
> ...the 'Print Preview' is just a Toolbar, not an app frame
> ...
> Just don't see much need for the work it would require--<ESC> or the current
> button suffice.  IMHO => WF

Fully agree. No inconsistency here.
Comment 3 sdc.blanco 2022-04-06 09:27:56 UTC
Note that Print Preview in Calc only shows "X", while Writer shows "X Close Preview" -- might be friendly to have Calc appear the same as Writer.
Comment 4 Heiko Tietze 2022-04-06 09:53:45 UTC
(In reply to sdc.blanco from comment #3)
> ... might be friendly to have Calc appear the same as Writer.

No objection. 

Writer uses in sw/uiconfig/swriter/toolbar/previewobjectbar.xml

<toolbar:toolbaritem xlink:href=".uno:ClosePreview" toolbar:style="image text"/>

And Calc in sc/uiconfig/scalc/toolbar/previewbar.xml

<toolbar:toolbaritem xlink:href=".uno:ClosePreview"/>

so adding the style might do the trick.
Comment 5 sdc.blanco 2022-04-06 10:26:27 UTC
(In reply to Heiko Tietze from comment #4)
> No objection. 
Rather than hijack this bug, made new ticket bug 148417