Bug 148491 - Close document X button doesn't close (qt5 and kf5 only)
Summary: Close document X button doesn't close (qt5 and kf5 only)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0 target:7.3.3
Keywords: bibisected, bisected, regression
Depends on:
Blocks: KDE, KF5
  Show dependency treegraph
 
Reported: 2022-04-10 06:12 UTC by Jim Raykowski
Modified: 2022-06-04 13:59 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2022-04-10 06:12:49 UTC
Steps to repro:

In order to test using qt5 backend you will need to have installed the libreoffice-qt5 package, for kf5 you will need to have installed the libreoffice-kf5 package.

1) start LO from command line with SAL_USE_VCLPLUGIN=qt5 or SAL_USE_VCLPLUGIN=kf5

Examples:
SAL_USE_VCLPLUGIN=qt5 /usr/local/bin/libreofficedev7.4 
SAL_USE_VCLPLUGIN=kf5 /usr/local/bin/libreofficedev7.4

2) open Writer, Calc, Impress, Draw, or Math (Base untested)

3) click the close document X button

Result: Module doesn't close

Expected result: Module closes

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: d34d1db55978bdcff082af1e0f75b18fa6fc94f4
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: d34d1db55978bdcff082af1e0f75b18fa6fc94f4
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: qt5 (qfont+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Michael Weghorn 2022-04-11 15:37:22 UTC
Confirmed.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 6f39602ecb9b90795bfd4101273f90b16f17b6d6
CPU threads: 12; OS: Linux 5.16; UI render: default; VCL: kf5 (cairo+wayland)
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded

Works again with these two local reverts

commit 740825bbb4242841733c9c97786dbbf96cea7aaf (HEAD -> master)
Date:   Mon Apr 11 17:34:04 2022 +0200

    Revert "tdf#145954 Qt unshare QMenubar usage"
    
    This reverts commit 9c4ef8ce3183e27ca174475cf4a8d15cc0368f60.

commit 949fe1b6a50e1f5105223b85f595831c7a4b0b33
Date:   Mon Apr 11 17:34:02 2022 +0200

    Revert "Qt drop unused QtMenu::mpCloseButton"
    
    This reverts commit 4a537cf77affc4f1f2e2e5be9ff0b1ff11724509.

Adding CC: to Jan-Marek Glogowski


Note that this *does* work when starting Writer as `libreoffice --writer` and using the close button then (which is what I was using when testing https://gerrit.libreoffice.org/c/core/+/132581 ...)
Comment 2 Commit Notification 2022-04-12 10:25:35 UTC
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f751417b77e6573a0c639778e76ec943449f4573

tdf#148491 Qt reconnect the QMenuBar close button

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2022-04-12 18:19:20 UTC
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/664ea7545a62e1329eb1761caea25b7f31cafa7a

tdf#148491 Qt reconnect the QMenuBar close button

It will be available in 7.3.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Jim Raykowski 2022-04-13 15:06:41 UTC
I verify the patch fixes the issue. Thanks!

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: a98971ac975e19efa2336b608506eefa85ce2485
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: qt5 (qfont+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 5 Commit Notification 2022-06-04 13:59:41 UTC Comment hidden (off-topic)