Bug 148519 - Change "Margin" to "Entire Frame" in "to" field for Vertical Position when anchoring "To frame" in Position and Shape tab
Summary: Change "Margin" to "Entire Frame" in "to" field for Vertical Position when a...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: sdc.blanco
URL:
Whiteboard: target:7.4.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicDesign
Depends on: 148782
Blocks: Dialog-UX 148485
  Show dependency treegraph
 
Reported: 2022-04-11 15:41 UTC by sdc.blanco
Modified: 2022-05-27 12:12 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
demonstration of difference, plus actual example for testing (38.79 KB, application/vnd.oasis.opendocument.text)
2022-04-11 15:41 UTC, sdc.blanco
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2022-04-11 15:41:28 UTC
Created attachment 179471 [details]
demonstration of difference, plus actual example for testing

Attachment explains and illustrates the issue, provides an actual example that can be used for testing, along with screenshots of the results. 

Here is the same issue, without the attachment. 

1. Insert or use an existing frame.
2. In the frame, insert a textbox or shape and an image.
3. Anchor both shape and image "To frame"
4. Right-click on Textbox or Shape, choose Position and Size > Position and Size tab.
5. In "to" field for Vertical Position, notice the options "Margin" and "Frame text area" in dropdown menu.
6. Right-click on the image, choose Properties
7. In "to" field for Vertical Position, notice the options "Entire frame" and "Frame text area" in dropdown menu.

Suggestion:  Change "Margin" in Shape to "Entire frame".

Reasons:  

1. Consistency across UI
2. "Entire frame" is more appropriate/meaningful than "Margin" in this case.
3. it will make it much easier to maintain the help pages.
Comment 1 sdc.blanco 2022-04-13 19:10:36 UTC
Revised suggestion.   

               (for Type tab - Image):   Entire frame --> Frame border
  (for Position and Size tab - Shape):   Margin -> Frame border

Reasons:

1. "Frame border" may be the "standard" terminology.
2.  Border tab exists in Frame, so some users will know about Frame border.
3.  The Horizontal Position "to" field has "Left frame border" and "Right frame border".  (best reason) because gives internal consistency to the dialogs, and makes it easier to recognize likely meaning of "frame border" vs. "frame text area".
Comment 2 Heiko Tietze 2022-04-26 07:23:30 UTC
Yes, Margin is wrong.

Code pointer is likely svx/inc/swframeposstrings.hrc -> NC_("RID_SVXSW_FRAMEPOSITIONS", "Margin"),
Comment 3 sdc.blanco 2022-04-26 08:00:40 UTC
https://gerrit.libreoffice.org/c/core/+/133290
Comment 4 Regina Henschel 2022-04-30 09:57:51 UTC
"Frame border" would be wrong. The suggestion "Entire Frame" of the OP is correct for replacement of the surely wrong "Margin". I would go with "Entire Frame" as immediate solution.

In a long term a complete change of the positioning section of that dialog is needed. For example "Left to" is wrong as the reference is an area. "Left in" might be more accurate. But that is a new issue. 

Reasoning:
'Frame border' is only the border itself. So positioning an object as "Center to frame border" for example, sounds as if the center of the object is aligned with the frame border.

'Frame border' would arise the question to which frame border, the left or the right one.

'Entire Frame' is correct from point of user, because it is invisible to the user, that a frame has a margin, which from technical point of view belongs to the frame.

'Border' in usual meaning is not an area but an edging or a surround, something which is called a "Umrandung" or "Einfassung" in German.
Comment 5 Commit Notification 2022-04-30 21:26:29 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2c19246a4090df14e8f97c35c7770b25c1974232

tdf#148519 change positioning option "Margin" -> "Entire frame"

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Regina Henschel 2022-05-07 16:40:35 UTC
The problem seems to be deeper than exchanging the resource string. With current master you get for a shape, which is _not_ anchored to a frame in the drop-down list the item 'Entire Frame' instead of 'Margin'. In this content 'Margin' would be correct, because it means 'paragraph including top paragraph margin'.
Comment 7 Regina Henschel 2022-05-07 18:12:24 UTC
The relevant vertical positions are FLY_REL_PG_FRAME and FLY_REL_PG_PRTAREA in include/svx/swframeposstrings.hxx. The corresponding (=same position) items in /svx/inc/swframeposstrings.hrc are "Entire frame" and "Frame text area" respectively. So the strings themselves are already correct.

The error is in cui/source/tabpages/swpossizetabpage.cxx were maps are created, which items are actually allowed in the drop-down list.
Comment 8 sdc.blanco 2022-05-10 04:18:43 UTC
https://gerrit.libreoffice.org/c/core/+/133871
Comment 9 Commit Notification 2022-05-10 15:57:06 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/05fa375ff0dba60af7093acb058e07b767f0adab

tdf#148519 correction to vertical "to frame" mapping for object position

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 sdc.blanco 2022-05-27 12:12:08 UTC
The changes in the option labels made in relation to this ticket seem to be functioning as expected, so closing as FIXED.