Bug 148823 - Mail Merge Email Settings confirmation should not be needed each time
Summary: Mail Merge Email Settings confirmation should not be needed each time
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
(earliest affected) alpha0+
Hardware: All All
: medium minor
Assignee: Not Assigned
Keywords: difficultyMedium, easyHack, skillCpp, skillDebug
Depends on:
Blocks: Mail-Merge
  Show dependency treegraph
Reported: 2022-04-27 15:40 UTC by Timur
Modified: 2023-05-06 22:31 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Screenshot (16.52 KB, image/png)
2022-04-29 08:33 UTC, Heiko Tietze

Note You need to log in before you can comment on or make changes to this bug.
Description Timur 2022-04-27 15:40:33 UTC
This is about sending mail with merged documents. Setup in Options-Writer-Mail Merge Email. Addresses directly or with Mail Merge Wizard. Start with Mail Merge tool-bar. As in attachment 132759 [details]. 

Send E-mail messages opens "Email merged document" dialog. Fill and "Send Documents". You get no-title confirmation dialog where  LO requires info about email account with buttons: Cancel No Yes. 
Cancel and No are the same, Yes opens Email Settings dialog and it must be used. 

But this is not needed each time, usually it's rarely changes. It is of no use if info is static. Needs to be changed. 

Not sure what's optima. Maybe to add check box "Use info from Options-LO Writer-Mail Merge" so that confirmation dialog doesn't open if checked, just Email Settings dialog if not.
Comment 1 Timur 2022-04-28 12:38:06 UTC
There's a different issue that I note here, not to open a new bug, hopefully it can be fixed together.
"Email merged document" dialog in Send Records has a text "Send all documents". 
It may be confusing, so better wording would be "Send to all recipients".
Comment 2 Heiko Tietze 2022-04-29 08:33:19 UTC
Created attachment 179836 [details]

How about to not show the dialog if Tools > Options are filled with information. We could add it as static label "From" under "To" in the Email Options dialog before this confirmation.
Comment 3 Heiko Tietze 2022-04-29 08:33:44 UTC
Jan-Marek, any concerns?
Comment 4 Timur 2022-04-29 10:54:19 UTC
Comment 2 sounds good to me. Except that No and Cancel would be the same.
Comment 5 Heiko Tietze 2022-05-02 07:55:31 UTC
Code pointer: In sw/source/ui/dbui/mmresultdialogs.cxx at IMPL_LINK_NOARG(SwMMResultEmailDialog, SendDocumentsHdl_Impl, weld::Button&, void) we have

   if (xConfigItem->GetMailServer().isEmpty() ||
       !SwMailMergeHelper::CheckMailAddress(xConfigItem->GetMailAddress()) )

which seems to cause the trouble. Some debugging needed here.
Comment 6 Baole Fang 2023-05-06 22:31:30 UTC
Hi, is this ticket fixed? When I'm reproducing, no confirmation dialog pops up.