Bug 148971 - PDF Accessibility: Checker dialog should be non modal
Summary: PDF Accessibility: Checker dialog should be non modal
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.3 release
Hardware: All All
: medium normal
Assignee: Samuel Mehrbrodt (allotropia)
URL:
Whiteboard: target:7.5.0 inReleaseNotes:7.5
Keywords: accessibility
Depends on:
Blocks: a11y, Accessibility 148999
  Show dependency treegraph
 
Reported: 2022-05-06 19:58 UTC by Olivier Hallot
Modified: 2022-12-04 22:46 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2022-05-06 19:58:43 UTC
Description:
When opening Accessibility checker the dialog show a set of issues and often shows too a button got to the issue in the text.

However the dialog is MODAL and does not let user fix the issue (for example add the <alt> tag (alternate text) to an image. Therefore user has to close the A11y checker dialog and fix the issues. To continue, user need to check a11y again, which is time consuming.

So better set the dialog as NON-MODAL and let the user fix the issues while the A11y dialog is open.

Steps to Reproduce:
1.Open A11Y checker in Tools > Accessibility check on a document
2.Click on the "Go To Issue" button 
3.Try to fix in the text

Actual Results:
Cannot fix in the text while the Accessibility Checker dialog is open. User must close the dialog before fixing the issue.

Expected Results:
Allow Accessibility checker dialog to stay open while user fix the issue.


Reproducible: Always


User Profile Reset: No



Additional Info:
Dialog should stay open while user fix the issues flagged.
Comment 1 BogdanB 2022-05-07 12:40:38 UTC
Confirm your request. Hard to correct all this way.

Version: 7.3.3.2 / LibreOffice Community
Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 2 Christophe Strobbe 2022-11-14 10:24:25 UTC
Using a dialog is one way of presenting the results of the automated check.
The first ODT accessibility checker, AccessODF, which was developed as a LibreOffice extension in Java, used the side panel. (Unfortunately, it became incompatible with LibreOffice after the side panel code from IBM Lotus Symphony was integrated into Apache OpenOffice and then into LibreOffice.)
You can see what the UI looked like in the screenshots in the AccessODF wiki on SourceForge: https://sourceforge.net/p/accessodf/wiki/UserGuide/. 

I think using the side panel would result in a nicer user experience than a non-modal dialog, but it is probably also a lot more challenging.
Comment 3 Commit Notification 2022-11-14 14:24:41 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1409159d6117d49e61fe5369f858239ff259fc1e

tdf#148971 Make a11y check dlg non-modal

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Adolfo Jayme Barrientos 2022-11-14 17:50:44 UTC
Converting the dialog to a sidebar deck should be in its own enhancement request.

Thanks Samuel!
Comment 5 Stéphane Guillou (stragu) 2022-12-04 22:46:26 UTC
Earliest affected is 7.0 when tool was introduced as experimental.

The idea of an accessibility sidebar was discussed in Bug 142978 and was closed as "won't fix". More info there.

Verified as fixed in:

Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: c50cf1883af26daebdfc9d796ced3c20c222f43b
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thanks Samuel!