Bug 152150 - gtk3: Non-modal dialog on top of modal dialog unusable
Summary: gtk3: Non-modal dialog on top of modal dialog unusable
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.5.0
Keywords:
Depends on:
Blocks: PDF-Accessibility
  Show dependency treegraph
 
Reported: 2022-11-21 07:50 UTC by Samuel Mehrbrodt (allotropia)
Modified: 2022-11-24 10:18 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Mehrbrodt (allotropia) 2022-11-21 07:50:51 UTC
1. Open Writer
2. File->Export As->Export as PDF
3. Enable "Universal Accessibility (PDF/UA)
4. Export

-> Accessibility Check dialog appears

Expected: Any of the buttons in the dialog can be clicked

Actual: Buttons not clickable

Works with gen, doesn't work with gtk3.

Problem since 1409159d6117d49e61fe5369f858239ff259fc1e
Comment 1 Caolán McNamara 2022-11-21 17:06:10 UTC
On the other hand with "gen" I can create multiple accessibility check dialogs by repeatedly pressing "export" in the underlying dialog, and then dismiss the underlying pdf dialog, at which point clicking ok or cancel in an accessibility check dialog will crash.

Do we really want it modeless when it's a child of this modal pdf dialog? We could just have it modal (and a child of the pdf dialog instead of a child of the pdf dialog's parent) in this case and sidestep the question: https://gerrit.libreoffice.org/c/core/+/143044
Comment 2 Commit Notification 2022-11-22 13:14:12 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5d9b8c367e70ac0a11f368ea702967ee4e0d5f06

tdf#152150 make AccessibilityCheckDialog modal when child of modal pdf dialog

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Caolán McNamara 2022-11-22 13:14:38 UTC
hopefully that's "good enough"
Comment 4 Stéphane Guillou (stragu) 2022-11-24 08:38:49 UTC
Confirmed with:

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a41c82407bbb73a4d87070326485ec4b4e954a65
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Verified as fixed in trunk by Caolán's commit, with a build from today, thank you! :)

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c130063895c7a733ad121db1bf5fbceac38f6ad5
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 5 Samuel Mehrbrodt (allotropia) 2022-11-24 10:18:30 UTC
(In reply to Caolán McNamara from comment #3)
> hopefully that's "good enough"

It is, thanks!