Bug 149144 - sm Formula editor needs an icon motif for the newly implemented Elements SB deck
Summary: sm Formula editor needs an icon motif for the newly implemented Elements SB deck
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium trivial
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.6.0 target:7.5.3
Keywords:
Depends on:
Blocks: Sidebar-New-Decks Elements-Pane Icon-Theme-Breeze Icon-Theme-Colibre Icon-Theme-KarasaJaga Icon-Theme-Elementary Icon-Request Icon-Theme-Sifr Icon-Theme-Sukapura
  Show dependency treegraph
 
Reported: 2022-05-18 01:50 UTC by V Stuart Foote
Modified: 2023-03-17 11:55 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Image showing the current icon (77.63 KB, image/png)
2022-05-18 20:21 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description V Stuart Foote 2022-05-18 01:50:49 UTC
The new SB implementation for sm Formula editor module is using a generic folder icon for the 'Elements' deck.  Have an opportunity to design a new motif for use in each of the project icon themes.
Comment 1 Rafael Lima 2022-05-18 20:21:21 UTC
Created attachment 180202 [details]
Image showing the current icon

In my case it is using the "Gallery" icon. See attached image showing the sidebar and the icon.

I agree that a dedicated icon for Math Elements would be much nicer.

System info:
Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: b2467d6c7af988f8ed4e090ebf9472be6c84fb06
CPU threads: 12; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL
Comment 2 Mike Kaganski 2022-08-26 07:51:32 UTC
(In reply to Rafael Lima from comment #1)
> In my case it is using the "Gallery" icon.

Yes, unfortunately I lack designer skills completely; and the Gallery icon was chosen explicitly as the temporary icon. The code pointer is in officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu:

https://git.libreoffice.org/core/+/3524e4f7352993517ebdd514435378f6de0ca713%5E%21/#F1
Comment 3 Rizal Muttaqin 2022-08-27 08:17:54 UTC
(In reply to Mike Kaganski from comment #2)
> (In reply to Rafael Lima from comment #1)
> > In my case it is using the "Gallery" icon.
> 
> Yes, unfortunately I lack designer skills completely; and the Gallery icon
> was chosen explicitly as the temporary icon. The code pointer is in
> officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu:
> 
> https://git.libreoffice.org/core/+/
> 3524e4f7352993517ebdd514435378f6de0ca713%5E%21/#F1

Could you please tell me in which line the code to point current gallery icon?
Comment 4 Mike Kaganski 2022-08-27 10:20:56 UTC
(In reply to Rizal Muttaqin from comment #3)

In officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu, in node named Elements Deck, there's property IconURL, with value private:graphicrepository/sfx2/res/symphony/sidebar-gallery-large.png.
Comment 5 Commit Notification 2023-03-09 09:15:09 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/db06ae5475bfd64c8acf3073c72193babbd4b822

tdf#149144 Icons for sm Formula Editor in Sidebar Deck

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2023-03-12 11:34:28 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/ed8d5af0db52ac3d766dad342f81ed9de5248390

tdf#149144 Icons for sm Formula Editor in Sidebar Deck

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.