Bug 125931 - Implement the Sidebar in Math formula editor, with decks for format options and Greek and special symbols
Summary: Implement the Sidebar in Math formula editor, with decks for format options a...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Formula Editor (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0
Keywords: needsUXEval
: 92171 96543 (view as bug list)
Depends on: 150940
Blocks: Formula-Editor Sidebar-New-Decks Elements-Pane
  Show dependency treegraph
 
Reported: 2019-06-14 19:47 UTC by Roman Kuznetsov
Modified: 2023-11-06 16:55 UTC (History)
15 users (show)

See Also:
Crash report or crash signature:


Attachments
Sidebar in the Math (88.14 KB, image/png)
2019-06-14 19:48 UTC, Roman Kuznetsov
Details
Sidebar in the Math. version 2 - all in one (59.03 KB, image/png)
2019-06-20 18:34 UTC, Roman Kuznetsov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2019-06-14 19:47:51 UTC
Description:
Add Sidebar to Math with format options and with Greek and special symbols

Steps to Reproduce:
-

Actual Results:
We don't have Sidebar in Math

Expected Results:
We have Sidebar in Math


Reproducible: Always


User Profile Reset: No



Additional Info:
-
Comment 1 Roman Kuznetsov 2019-06-14 19:48:29 UTC
Created attachment 152206 [details]
Sidebar in the Math
Comment 2 V Stuart Foote 2019-06-15 13:48:58 UTC Comment hidden (obsolete)
Comment 3 Roman Kuznetsov 2019-06-15 13:52:22 UTC
let's make conversely. My bug has the mockup for discuss but bug 96543 doesn't
Comment 4 Roman Kuznetsov 2019-06-15 13:53:02 UTC
*** Bug 96543 has been marked as a duplicate of this bug. ***
Comment 5 V Stuart Foote 2019-06-15 14:16:29 UTC
OK, sure. Adjusting metas
Comment 6 V Stuart Foote 2019-06-15 14:16:43 UTC
*** Bug 92171 has been marked as a duplicate of this bug. ***
Comment 7 V Stuart Foote 2019-06-15 14:22:38 UTC
So, UX question as to re implementing the 'elements' panels as new SideBar based decks or would it be retained for now and only add the needed parts for formatting, layout and symbol/font customization (what is held on sm menues now).
Comment 8 Roman Kuznetsov 2019-06-15 14:26:02 UTC
I suggest don't touch Element dock and just add the Sidebar. Then we'll have on screen all tools for creating a formula
Comment 9 Heiko Tietze 2019-06-16 07:21:17 UTC
(In reply to V Stuart Foote from comment #6)
> *** Bug 92171 has been marked as a duplicate of this bug. ***

Would rather do it the other way around, at least www.dmaths.org is a valuable input for the design (actually I miss a bit the discussion about why like "Eve wants ... to achieve ...").
Comment 10 V Stuart Foote 2019-06-16 14:28:30 UTC
(In reply to Heiko Tietze from comment #9)
> (In reply to V Stuart Foote from comment #6)
> > *** Bug 92171 has been marked as a duplicate of this bug. ***
> 
> Would rather do it the other way around, at least www.dmaths.org is a
> valuable input for the design (actually I miss a bit the discussion about
> why like "Eve wants ... to achieve ...").

Well to be honest both 92171 and 96543 were languishing. And we'd had no input from the Dmaths.org club, or regards the TexMaths extension (though I've added both Dieter and Roland here).

General HIG for the Sidebar is here: https://wiki.documentfoundation.org/Design/SideBar

Kind of agree with Roman that a start should be to just get the menu configuration controls for Math into the right attached Sidebar for starters.  Rework of the left side Elements pane panels, and the formula box is much more involved and can follow later.

Here is the comment from bug 92171 OP arguing that the function of elements panels in Math need to be moved into the Sidebar structure:

"This is an enhancement request.

The sidebar of Math differs from other LibO component sidebar. In Writer, Calc, Draw, etc, the different elements of the sidebar are accessible through a button. On the other hand, the Math sidebar has a dropdown menu, with its different elements only in text form.

This makes searching for a specific element in the Math sidebar more tedious than the navigation through the sidebar of the rest of the components. The number of clicks to search for an option in Math is doubled with respect to the other scheme: in Math, you first must select the dropdown button, then click again the corresponding option. With the scheme in the rest of the LibO apps, only one click in the corresponding button is necessary.

My proposal is to have an element disposition of the Math sidebar analogue to the rest of the components of LibO. That is, buttons with a descriptive icon at right."

With that I think it all has been consolidated here in one issue that can be pursued efficiently...

Stuart
Comment 11 Heiko Tietze 2019-06-17 11:19:59 UTC
(In reply to V Stuart Foote from comment #10)
> ...
> The sidebar of Math differs from other LibO component sidebar. In Writer,
> Calc, Draw, etc, the different elements of the sidebar are accessible
> through a button.
> ...
> With that I think it all has been consolidated here in one issue that can be
> pursued efficiently...

While other modules have many properties that require frequently user input, it's not the same for Math, IMHO. For example, how often do users change the font size? Maybe from time to time but all those relative values? 

More input for requirements is in bug 39750 (unsure if everything is possible what Bjoern asks for) and bug 99169 requests panel integration in Writer. dmath.org seems to be discontinued.

(In reply to Roman Kuznetsov from comment #1)
> Created attachment 152206 [details]
> Sidebar in the Math

Good start and easy to realize solution, we just take what's in the existing dialogs and put it into the sidebar.
However, I always disliked those heavy UIs. Some details: the basic font size could go next to the font name (and bold/italic). Alignment could be done smaller with toggle buttons. And the percentual values are good for sliders. And while the symbols are something different it would be more interesting to show them on the primary panel. So I suggest to collapse the relative section and have the symbols there too.
Comment 12 Francisco 2019-06-17 19:54:15 UTC
(In reply to Heiko Tietze from comment #11)
> 
> While other modules have many properties that require frequently user input,
> it's not the same for Math, IMHO. For example, how often do users change the
> font size? Maybe from time to time but all those relative values? 
>

Hello, Heiko, all,

I'm a researcher and university teacher. I change font size and typeface in equation quite frequently, depending on the document.

The most silly (and frequent) example is copying an equation from and ODT in a manual to a presentation for the class. Size in document is small compared to the one needed in the presentation. Also, my presentations use to have sans typeface, and documents serif typefaces.

Also between presentations. Since a few days ago, our institute claims that our presentations and documents should be in "Montserrat" typeface, just because. And now I must manually change all the equations I already have.

Another example is for conferences, some of the requires an specific typeface for the manuscripts sent. Generally is Times but... I don't use Times.

Regards,

Francisco
Comment 13 Heiko Tietze 2019-06-18 12:59:52 UTC
(In reply to Francisco from comment #12)
> I change font size and typeface in equation quite frequently...

Thanks for the use case, I would expect the formula to take the font of the paragraph unless it is set explicitly. And we should hide the percentage values by collapsing this section.
Comment 14 V Stuart Foote 2019-06-18 13:42:58 UTC
(In reply to Heiko Tietze from comment #13)
> 
> Thanks for the use case, I would expect the formula to take the font of the
> paragraph unless it is set explicitly. And we should hide the percentage
> values by collapsing this section.

Unfortunately we in no way implement that. We hardocde default fonts, and for actual sm node construction only parse StarSymbol/OpenSymbol and can't directly control that (bug 101174) needing to use the font replacement table to bring in more complete fonts with symbol coverage. With some annoying glyph metrics and PUA assignments that crop up.

Text mode sets formula scaling to anchor and render the OLE in line with paragraph text, but it is not very appealing. With similar font issues.
Comment 15 Roman Kuznetsov 2019-06-20 18:34:25 UTC
Created attachment 152318 [details]
Sidebar in the Math. version 2 - all in one
Comment 16 Roman Kuznetsov 2019-06-20 18:38:21 UTC
Ok, we can remove from Sidebar all Spacing options and all Relative font size options. 
Scale all brackets option should be move to Math Options dialog, I think

In this case we can get all main formula format options together with Symbols on one section in Sidebar (see version 2 mockup in attach)
Comment 17 Heiko Tietze 2019-06-21 06:49:47 UTC
(In reply to Roman Kuznetsov from comment #15)
> Created attachment 152318 [details]
> Sidebar in the Math. version 2 - all in one

+1, reduced to the relevant properties and just combining what's in the dialogs. Objections to this proposal? What shall we do with the legacy dialogs when this solution goes live?
Comment 18 Roman Kuznetsov 2019-06-21 07:03:28 UTC
(In reply to Heiko Tietze from comment #17)
> (In reply to Roman Kuznetsov from comment #15)
> > Created attachment 152318 [details]
> > Sidebar in the Math. version 2 - all in one
> 
> +1, reduced to the relevant properties and just combining what's in the
> dialogs. Objections to this proposal? What shall we do with the legacy
> dialogs when this solution goes live?

There is the bug 114395 about format dialogs in Math
Comment 19 V Stuart Foote 2019-06-21 14:01:29 UTC
(In reply to Heiko Tietze from comment #17)
> +1, reduced to the relevant properties and just combining what's in the
> dialogs. Objections to this proposal? What shall we do with the legacy
> dialogs when this solution goes live?


(In reply to Roman Kuznetsov from comment
> 
> There is the bug 114395 about format dialogs in Math

We'll need UNO for all controls of the dialog going into the content panels of the Sidebar anyway. So current dialogs should remain, but be tweaked for use from menu or sidebar. 

The Relative size by category is a challenge--it is not often used, but when you need it to adjust manuscript node composition it is critical. As are the spacing adjustments applied when placing the OLE into 'Text mode'. 

So all of the functions of dialog rework of bug 114395 should be available to Sidebar. Add them as additional content panels.

Something to consider though--are the setting from the dialog applicable to the current formula, or to what will be applied to a new formula? And, how do you restore UI to template defaults--for current formula, for new formulas?

Also, that wrapping a formula in a 'size NN { formula}' overrides the dialog (and nascent Sidebar content panel) leaving other spacing unchanged--just the base size is reset. Do we need to indicate that somehow visually?

So while this gets us onto the Sidebar, sm needs major rework that would affect these GUI contols. Two specifically, the multi-glyph (bug 32362) for 'Scale all brackets' control; and removing hardcoded dependency on OpenSymbol font (bug 101174) for the sm 'Symbols...' picker dialog.
Comment 20 AJ Justin 2019-12-21 15:03:15 UTC Comment hidden (spam)
Comment 21 Thomas 2020-04-13 14:42:53 UTC Comment hidden (spam)
Comment 22 Lucille Morn 2020-04-16 13:52:43 UTC Comment hidden (spam)
Comment 23 Chris Coleman 2020-04-16 14:18:23 UTC Comment hidden (spam)
Comment 24 xtian90 2020-05-13 13:43:43 UTC Comment hidden (spam)
Comment 25 boisemetalroofing 2020-09-09 20:22:36 UTC Comment hidden (spam)
Comment 26 freefirepc 2020-10-22 07:30:52 UTC Comment hidden (spam)
Comment 27 Commit Notification 2022-04-26 15:02:28 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9098d5a2e43b156648f187559790547d1b536896

tdf#125931: Enable sidebar in Math

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 28 Commit Notification 2022-04-26 15:02:37 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3524e4f7352993517ebdd514435378f6de0ca713

tdf#125931: Add Elements deck and Elements panel to Math's sidebar

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 29 Commit Notification 2022-04-27 14:34:05 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8ae17abbcce62dab714e8e36ef5225e6fef75334

tdf#125931: add Properties panel to Math's Properties deck

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 30 V Stuart Foote 2022-04-27 17:35:51 UTC
> Mike Kaganski committed a patch related to this issue.

> https://git.libreoffice.org/core/commit/9098d5a2e43b156648f187559790547d1b536896

> https://git.libreoffice.org/core/commit/3524e4f7352993517ebdd514435378f6de0ca713

@Mike, took these out for a spin. seems well behaved. Will try the Properties deck as a launcher for the 'Format' menu items once that rolls.

Two "tweaks" to consider in bring SB to sm:

1.) The current 'Elements' panel is positioned docked left--do we want to emmulate that by forcing the sm Sidebar to dock left as well? As is done now for the second <F5> detached instance of the SB Navigator deck.

2.) The 'Elements' pannel is fully resizable--and while SB deck can be made so globally with the 'MinimumWidth' boolean from Expert Config--should we have the SB framework 'Elements' panel bypass 'MinimumWidth' by default as well?

Are you stopping here maybe after enabling a simple deck as a luancher for Symbols dialog? Seems a good spot to pause... unless you have the cycles for a more complete refactoring of the dialogs into SB content panels.
Comment 31 V Stuart Foote 2022-05-17 16:40:48 UTC
On Windows 10 with
Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 817b8fe7001a83cb74910eb09b7c14a3b95b8a39
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

I had one crash on a dual head system when undocking the new SB deck. It pops open on the other display, and attempting to drag it back to the primary monitor for docking to the oposite side of the Formula window.  Had seen similar in dealing with undocked SB, but could be isolated to this system Skia GPU (nVidai K2000) Vulkan driver pair issue--bug 143396

Toggling off the 'Elements' sidebar, and undocking/docking to left the new SideBar deck, the layout is functional.

Of the two SB 'Decks' provided so far, the 'Elements' deck is a direct analog for the 'Elements' pane. Think the 'Elements' deck is going to need a new icon motif for the various themes--Rizol, Andreas, ideas?

While the Properties deck is limited to the menu entries from the Format menu, excluding the 'Text Mode' toggle. 

The UNO launchers for each of the format menu dialogs suffice, but it would be helpful having provided the button actions 'Font', 'Font Size', 'Spacing', or 'Alignment'--if clicking a different button would closeout an open dialog and launch the corresponding. Guess the UNO action would need to be tweaked for that as that is the behavior now of the Format menu.

@Mike, can the 'Text Mode' toggle be added to the 'Properties' deck?  Also, should the 'Symbols...' dialog toolbar button be added? Or would that do better as a new deck w/content panels to hold the current dialog's content?
Comment 32 Rizal Muttaqin 2022-05-17 21:34:53 UTC
(In reply to V Stuart Foote from comment #31)

> Of the two SB 'Decks' provided so far, the 'Elements' deck is a direct
> analog for the 'Elements' pane. Think the 'Elements' deck is going to need a
> new icon motif for the various themes--Rizal, Andreas, ideas?
> 

Yes fully agree, a new dedicated bug report would be welcome. I have no idea right now how icon should looks like. Let's discuss on new bug report
Comment 33 V Stuart Foote 2022-05-18 01:59:42 UTC
(In reply to Rizal Muttaqin from comment #32)

done, bug 149144
Comment 34 safiradara 2023-11-06 16:55:11 UTC Comment hidden (spam)