Bug 150489 - Drop separate docking Elements window, and use Sidebar instead
Summary: Drop separate docking Elements window, and use Sidebar instead
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Formula Editor (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Mike Kaganski
URL:
Whiteboard: target:7.5.0 inReleaseNotes:7.5
Keywords:
: 99169 (view as bug list)
Depends on:
Blocks: Formula-Editor
  Show dependency treegraph
 
Reported: 2022-08-19 06:29 UTC by Mike Kaganski
Modified: 2022-12-08 13:21 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2022-08-19 06:29:06 UTC
In 7.4, a sidebar was implemented for Math (as part of tdf#125931), with Elements deck on it [1].

IMO, it's time (in 7.5 release cycle) to drop the separate Elements docking window shown on the right side, in the same spirit as commit b4558b508141af16d335f45a0f12bdd34521e944 did in 2014 for Writer and Impress. The sidebar has already been made open by default [2], and Elements was made the default deck on it [3], so users will have the same set of controls shown on screen by default.

IMO, the idea to have separate window with elements, side by side with other (potential) decks open at the same time, belongs to the sidebar panel undocking functionality implementation (bug 85905). We made an exclusion for the Navigator panel implemented both as sidebar and separate window (see discussion in bug 73151), because removing stand-alone Navigator would *break* already existing workflow with several windows open at the same time; there is no such breakage in Math Elements panel case, and the imagined improvement with several windows (bug 125931) should, as mentioned, be implemented as undocking sidebar panel functionality.

[1] https://gerrit.libreoffice.org/c/core/+/133393
[2] https://gerrit.libreoffice.org/c/core/+/138456
[3] https://gerrit.libreoffice.org/c/core/+/138457
Comment 1 Mike Kaganski 2022-08-19 06:32:36 UTC
https://gerrit.libreoffice.org/c/core/+/138458 is my take on this (subject to discussion, indeed).
Comment 2 V Stuart Foote 2022-08-19 08:05:40 UTC
+1, the Elements docking window can be eliminated and replaced by content panel in the  SideBar framework.

Agree that completing bug 85905 SB framework for undocking selective decks is the right functionality, eventually. Meanwhile eliminating the left-attached elements panel (Quikee's work at 4.1 to replace the floating elements widget) is over due to bring the Sidebar Deck and Content panels into the sm Formula editor.

One UX consideration is if the sm Decks and Content panels should continue to be anchored left as the elements docking window was, of if we should move to the right side attachment for consistency with SB norm in the other modules?

Seems a little awkward, but if we add additional Content panels for current menu controls (e.g. to hold dialog mockups from bug 114395) positioning the SB on the right really is the better location to hold a SB deck wider than the removed panel.  Having the wider panel attached left would not be comfortable.
Comment 3 Heiko Tietze 2022-08-19 08:38:12 UTC
(In reply to V Stuart Foote from comment #2)
> +1, the Elements docking window can be eliminated and replaced by content
> panel in the  SideBar framework.

Me concurs

> One UX consideration is if the sm Decks and Content panels should continue
> to be anchored left as the elements docking window was, of if we should move
> to the right side attachment for consistency with SB norm in the other
> modules?

The sidebar is right-hand, would not make an exception in Math.

What is needed, however, is to always show the sidebar. So it's not the "Standard Toolbar" interface (in terms of Writer) but "Sidebar". Have you considered this, Mike?

Keeping UX for a while since CC was missing.
Comment 4 Mike Kaganski 2022-08-19 08:42:24 UTC
(In reply to Heiko Tietze from comment #3)
> What is needed, however, is to always show the sidebar. So it's not the
> "Standard Toolbar" interface (in terms of Writer) but "Sidebar". Have you
> considered this, Mike?

The change from comment 1 makes sure that the sidebar is not only open (i.e., its categories are shown on screen), but also expanded (the code to keep it collapsed in sfx2/source/sidebar/SidebarChildWindow.cxx does not affect Math). So yes, I guess that we are on the same page here.
Comment 5 Heiko Tietze 2022-08-19 09:04:42 UTC
(In reply to Heiko Tietze from comment #3)
> (In reply to V Stuart Foote from comment #2)
> > +1, the Elements docking window can be eliminated and replaced by content
> > panel in the  SideBar framework.
> 
> Me concurs

Concerns might arise when the elements pane is used frequently as well as the properties sidebar and both need to be visible at the same time. Not the fact currently.

Roman commented on the patch: "1. There is tdf#125931 and I suggested there the idea about additional (!) Sidebar sections for Math options and Greek symbols. And I thought to have on the screen both panes Elements and Sidebar in the same time. It would be really useful for the workflow. It's the same situation that we have in Writer with Navigator: there is Navigator window and there is Sidebar's Navigator. So I can have Navigator in left side and (for example) Styles on the Sidebar in the same time, it's really comfortable, but other people can use only Sidebar's Navigator if they want...
2. I didn't see any bug reports or enhancements or even just discussion about deleting the Element pane from Math"
Comment 6 Mike Kaganski 2022-08-19 10:47:24 UTC
Let me remove the ASSIGNED status for now, to avoid impression that this is a decided matter. As Heiko mentioned in comment 3, more UX is welcome; and one concern is expressed in comment 5.

I would love to discuss this before merging the patch. Indeed, even after that, it could be reverted; but given that I intend to build more changes upon that, it could be much work then.
Comment 7 V Stuart Foote 2022-08-19 14:43:44 UTC
(In reply to Mike Kaganski from comment #6)
>... but given that I intend to build more changes
> upon that, it could be much work then.

@Mike, please just do it. These are legitimate improvements to the formula editor. If we decide to spin off the Elements deck/contentpanel(s) into a new SB framework'd panel to attach left (as we've done for F5 detached Navigator) allowing use of two SB decks that would be OK until refactoring for bug 85905 handling. The precedent and support for doing it is already there.

Meanwhile it lets you and Dante and anyone else with an interest in the sm Formula editor to get on with it.
Comment 8 Heiko Tietze 2022-08-26 07:40:29 UTC
The topic was on the agenda of the design meeting but didn't receive further opinions. The only objection by Roman is weak since we do not have that many attributes to change that would require having the elements pane in parallel to properties. So please go ahead - and let's see what users think.
Comment 9 Commit Notification 2022-08-26 08:42:48 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dbe125fce5d226641bf84ac3be12ea88c41f6d91

tdf#150489: Drop Elements docking window

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Stéphane Guillou (stragu) 2022-12-06 09:18:18 UTC
Verified as fixed in:

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a41c82407bbb73a4d87070326485ec4b4e954a65
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thanks Mike!
Comment 11 Stéphane Guillou (stragu) 2022-12-08 13:21:00 UTC
*** Bug 99169 has been marked as a duplicate of this bug. ***