Bug 149351 - SLIDESHOW: Feature request to add well known keyboard shortcut from Powerpoint CTRL+A
Summary: SLIDESHOW: Feature request to add well known keyboard shortcut from Powerpoin...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.3.3.2 release
Hardware: All All
: medium enhancement
Assignee: Gabor Kelemen (allotropia)
URL:
Whiteboard: target:7.5.0 target:7.4.0.0.beta2 inR...
Keywords:
Depends on:
Blocks: Presenter-Console
  Show dependency treegraph
 
Reported: 2022-05-28 22:45 UTC by lord.diablo
Modified: 2022-12-22 09:02 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot from MSO help (55.74 KB, image/png)
2022-06-02 12:18 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description lord.diablo 2022-05-28 22:45:11 UTC
Description:
Please add the well known shortcut to always switch back from pen to the arrow using CTRL+A.

See also the Microsoft documentation for this shortcut:
https://support.microsoft.com/en-us/office/use-keyboard-shortcuts-to-deliver-powerpoint-presentations-1524ffce-bd2a-45f4-9a7f-f18b992b93a0

This shortcut is important to make some hardware presenter devices work as expected.

Alternatively the shortcuts for the slideshow could be customizable, but I didn't found any possibility for doing this.

Steps to Reproduce:
1. In Impress start the presentation with F5
2. Press CTRL+P to start using the pen
3. Press CTRL+A to switch back to the arrow (currently NOT working)

Actual Results:
In slideshow nothing happens, when CTRL+A is pressed.

Expected Results:
In slideshow switch back to arrow from pen, when CTRL+A is pressed.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.3.2 (x64) / LibreOffice Community
Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL
Comment 1 Martin Srdoš 2022-05-29 09:04:26 UTC
Hello Lord, you can switching between arrow and pen by ctrl+p. Why it is not enough?
Comment 2 V Stuart Foote 2022-05-29 13:16:07 UTC
Yes, the <Ctrl>+P is a toggle for the Pen function, question any need to provide a MSO compatible <Ctrl>+A to exit back to presentation.  IMHO => WF

@Seth, description of the <Ctrl>+P "Pen" shortcut is not present in the 'Shortcut Keys for Slide Shows' that I could find, did I miss it, or worth describing in Help?
Comment 3 V Stuart Foote 2022-05-29 13:40:28 UTC
(In reply to V Stuart Foote from comment #2)
> Yes, the <Ctrl>+P is a toggle for the Pen function, question any need to
> provide a MSO compatible <Ctrl>+A to exit back to presentation.  IMHO => WF
> 
> @Seth, description of the <Ctrl>+P "Pen" shortcut is not present in the
> 'Shortcut Keys for Slide Shows' that I could find, did I miss it, or worth
> describing in Help?

Actually has the accelerator defined in UI [1][2], which (on Windows at least) picks up with either <Alt> or <Ctrl>, as at [3][4]. But still only the extended tip, and not Customizable from Tools -> Customize

=-ref-=

[1] <https://opengrok.libreoffice.org/xref/core/sd/uiconfig/simpress/ui/slidecontextmenu.ui?r=e872d77c#38>

[2] <https://opengrok.libreoffice.org/xref/core/sd/uiconfig/simpress/ui/presentationdialog.ui?r=c7fcd5a3#589>

[3] <https://opengrok.libreoffice.org/xref/core/slideshow/source/engine/slideshowimpl.cxx?r=f9e79a91#1581>

[4] <https://opengrok.libreoffice.org/xref/core/sd/source/ui/slideshow/slideshowimpl.cxx?r=5060c501#2612>
Comment 4 sdc.blanco 2022-05-29 16:03:24 UTC
(In reply to V Stuart Foote from comment #2)
> description of the <Ctrl>+P "Pen" shortcut is not present ... did I miss it
No (with reasonable certainty).

> or worth describing in Help?
Do not know if there is already a ticket for this shortcut, otherwise, maybe this ticket can be converted into a documentation request to add it.

Obvious places to include it would be Shortcut keys for Impress:
https://help.libreoffice.org/7.4/en-US/text/simpress/04/01020000.html?&DbPAR=IMPRESS

and might possibly be appropriate in: 
https://help.libreoffice.org/7.4/en-US/text/simpress/01/06080000.html?&DbPAR=IMPRESS

If this is MSO-specific, then indicate as such, because the help pages can provide information conditionally on the OS.
Comment 5 lord.diablo 2022-05-30 04:35:50 UTC
(In reply to Martin Srdoš from comment #1)
> Hello Lord, you can switching between arrow and pen by ctrl+p. Why it is not
> enough?

Dear Martin,
yes, I can confirm turning pen on and off with "p" with the keyboard is working.

The reason why I request also CTRL+A are hardware presenter / air mouse devices.

Here is case which has a "pen" key, which maps to the actions:
1. CTRL+P (activate pen)
2. Click, while button is pressed (draw)
3. CTRL+A (deactivate pen)

Such a device relies on the CTRL+A working. As it is basically recognized as a combined keyboard and mouse device, a remapping for the hardware is not trivially possible.

I understand, when you would disagree with this shortcut, but in this case a customization option for the shortcuts in presentation mode would be helpful and nice.

Best regards
Comment 6 Heiko Tietze 2022-05-30 09:38:04 UTC
The air mouse argument is striking to me.

Shortcuts are hard-coded in sd/source/ui/slideshow/slideshowimpl.cxx SlideshowImpl::keyInput() with onscreen help at officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu. Not sure what else is needed.

If we modify the pen function and use KEY_A we also have to change note scrolling from the current A/Y assignment.

Full customization would be nice but probably involves a lot of effort. The alternative might be a compatibility flag that either uses the one or the other hard-coded shortcuts.
Comment 7 Heiko Tietze 2022-06-02 12:18:23 UTC
Created attachment 180538 [details]
Screenshot from MSO help

These are the shortcuts from MSO PP.
Comment 8 Heiko Tietze 2022-06-02 12:18:57 UTC
No further opinion, let's follow MSO with the shortcuts.
Comment 9 lord.diablo 2022-06-02 13:56:21 UTC
(In reply to Heiko Tietze from comment #8)
> No further opinion, let's follow MSO with the shortcuts.

Indeed the official documentation shows CTRL+P to switch to pen and CTRL+A to switch (back) to arrow.

But if you are in pen mode in MSO, you can also use CTRL+P again to switch back to arrow as it is currently also done in LibreOffice.
It is not explicitly mentioned in the MSO documentation, but you can of course easily try it.

This behavior should be kept and be still possible in future.
So in pen mode, I suggest to use either CTRL+P or CTRL+A to switch back to arrow, as it is implemented in MSO.

(That is important, as you can also find other air mouse devices, which only have a toggle button mapped to CTRL+P to toggle pen on and off.
While others use the shortcut mentioned above to turn on pen, draw directly and turn pen off using a single button.)
Comment 10 Gabor Kelemen (allotropia) 2022-06-10 08:32:31 UTC
Proposed patch: https://gerrit.libreoffice.org/c/core/+/135579
Comment 11 Gabor Kelemen (allotropia) 2022-06-10 08:37:38 UTC
(In reply to Heiko Tietze from comment #6)
> The air mouse argument is striking to me.
> 
> Shortcuts are hard-coded in sd/source/ui/slideshow/slideshowimpl.cxx
> SlideshowImpl::keyInput() with onscreen help at
> officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu. Not sure
> what else is needed.

I changed these, seems to work.

> 
> If we modify the pen function and use KEY_A we also have to change note
> scrolling from the current A/Y assignment.
> 
No, that's not strictly needed.
I checked and these work when focus is in the note view of the presenter console.
For that the keys are handled separately. Now depending on context Ctrl+A (but not simple A alone) turns off the mouse pen, or 'A' scrolls the note view. 

> Full customization would be nice but probably involves a lot of effort. The
> alternative might be a compatibility flag that either uses the one or the
> other hard-coded shortcuts.

Yes. These are not proper UNO commands, so we need to keep duplicate implementations of key shortcuts for the slideshow view and the Presenter console, and their shortcuts cannot be customized. But reimplementing these as UNO commands would be a lot of time.
Comment 12 Heiko Tietze 2022-06-10 08:41:09 UTC
(In reply to Gabor Kelemen (allotropia) from comment #11)
> > If we modify the pen function and use KEY_A we also have to change note
> > scrolling from the current A/Y assignment.
> > 
> No, that's not strictly needed.
> I checked and these work when focus is in the note view of the presenter
> console.

So we silently support the pen-off function and show the on-screen help still in respect to the notes. Hackish compromise, so +1/-1 from my side :-).
Comment 13 Commit Notification 2022-06-14 14:38:50 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/76f7f0c167a5148c01cdb1e0d8ea56b905f5a875

tdf#149351 Add a 'Turn off mouse as pen' shortcut

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Commit Notification 2022-06-15 22:08:53 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/27ddda4356f18f464a41cc828cf42bf9d5e053b8

tdf#149351 Add a 'Turn off mouse as pen' shortcut

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2022-07-21 08:44:15 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/da7edbd2fd925bd80fdd6affe2ff6510c8ac1c5d

(related) tdf#134281 tdf#149351 Update shortcuts descriptions
Comment 16 Stéphane Guillou (stragu) 2022-12-22 09:02:37 UTC
Fix verified in:

Version: 7.5.0.0.beta1 (X86_64) / LibreOffice Community
Build ID: 3aca23eec42e9d6fbe57071d7633ae1fc4bc5fcc
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Added to the 7.5 release notes, as it wasn't mentioned for 7.4.

https://wiki.documentfoundation.org/index.php?title=ReleaseNotes%2F7.5&type=revision&diff=602691&oldid=602690

Thanks Gabor!