Bug 149412 - Incorrect/unexpected click+drag behavior in animations list (gtk3)
Summary: Incorrect/unexpected click+drag behavior in animations list (gtk3)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.0.0.3 release
Hardware: All All
: medium minor
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.6.0 target:7.5.1
Keywords: bibisected, bisected, regression
Depends on:
Blocks: GTK3 Sidebar-Animation
  Show dependency treegraph
 
Reported: 2022-05-31 21:59 UTC by Eyal Rozenberg
Modified: 2023-03-17 14:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
dnd screencast (629.73 KB, video/webm)
2023-01-19 15:40 UTC, Caolán McNamara
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2022-05-31 21:59:55 UTC
If I select several (consecutive) animation effects in the animations sidebar pane, then click+drag them in some direction - instead of them all being dragged, the click selects just one of them, and it alone gets dragged.

Build info: 
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: d9b33ed6644203141fdb0776c291425c2bc9f5ac
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US
Comment 1 Buovjaga 2023-01-19 08:27:32 UTC
This only affects gtk3.

This changed in 7.0 with https://git.libreoffice.org/core/commit/21e8ce9ab9a522d25e95773af59b7ccccaee4e54
weld custom animation panel

I checked based on my result in bug 149031, so I did not have to bisect.
Comment 2 Caolán McNamara 2023-01-19 11:42:08 UTC
I can drag multiple rows in gtk (don't release mouse after selecting the last one and drag and drop the group), but gtk's built-in dnd icon generation always uses just the last selected row.

Fairly tricky to get our own icon in there, to show multiple rows in the icon, but maybe doable.
Comment 3 Caolán McNamara 2023-01-19 15:40:49 UTC
Created attachment 184781 [details]
dnd screencast

what I now see with https://gerrit.libreoffice.org/c/core/+/145818 applied
Comment 4 Eyal Rozenberg 2023-01-19 21:12:39 UTC
(In reply to Caolán McNamara from comment #3)
> what I now see with https://gerrit.libreoffice.org/c/core/+/145818 applied

So... it's fixed, then?
Comment 5 Commit Notification 2023-01-20 08:54:02 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/231ad90b597410cab7f4f2e9a7b4547d97fb9972

tdf#149412 gtk3: show all selected rows in dnd icon

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Caolán McNamara 2023-01-20 08:58:27 UTC
works for me, maybe a little finicky to do the drag and drop, but that seems to just be how GtkTreeView operates, but it does work and now the dnd icon indicates the full set of rows it will move.

done in trunk, backport to 7-5 in gerrit
Comment 7 Commit Notification 2023-01-20 13:52:42 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/e033e1f2a8e202f5ded99729fe896f72e9a0c3be

tdf#149412 gtk3: show all selected rows in dnd icon

It will be available in 7.5.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.